feat: add new resource aws_ebs_snapshot_block_public_access

[stefanfreitag]

Description

Add a new resource allowing to block the public sharing of EBS snapshots.

Relations

• Closes Block Public Sharing of Amazon EBS Snapshots #34347
• Closes New resource aws_ebs_snapshot_lock #37436
  The pull request created by @obounaim was moved into draft status a few days ago. I used it as starting point added a few bits here and there.

References

#34347 contains links to the AWS announcement and blog posts

Output from Acceptance Testing

❯ make  testacc TESTS=TestAccEC2EBSSnapshotBlockPublicAccess_ PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2EBSSnapshotBlockPublicAccess_'  -timeout 360m
=== RUN   TestAccEC2EBSSnapshotBlockPublicAccess_basic
=== PAUSE TestAccEC2EBSSnapshotBlockPublicAccess_basic
=== CONT  TestAccEC2EBSSnapshotBlockPublicAccess_basic
--- PASS: TestAccEC2EBSSnapshotBlockPublicAccess_basic (20.76s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        21.054s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[stefanfreitag]

One check is failing, but not sure what needs to be fixed here.
I checked the raw logs and noticed on unrelated resources

2024-08-01T18:46:23.5187111Z   [✖] https://docs.aws.amazon.com/transfer/latest/userguide/API_SftpConnectorConfig.html → Status: 404
2024-08-01T18:46:23.5187125Z 
2024-08-01T18:46:23.5187731Z   ERROR: 1 dead links found in website/docs/r/transfer_connector.html.markdown !
2024-08-01T18:46:23.5188701Z   [✖] https://docs.aws.amazon.com/transfer/latest/userguide/API_SftpConnectorConfig.html → Status: 404

[justinretzolk]

Hey @stefanfreitag 👋 Thank you for taking the time to raise this! I think there was a docs outage related to Transfer this morning that seemed like it could have been related, so I queued the job to re-run.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccEC2EBSSnapshotBlockPublicAccess_' PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccEC2EBSSnapshotBlockPublicAccess_ -timeout 360m
=== RUN   TestAccEC2EBSSnapshotBlockPublicAccess_basic
=== PAUSE TestAccEC2EBSSnapshotBlockPublicAccess_basic
=== CONT  TestAccEC2EBSSnapshotBlockPublicAccess_basic
--- PASS: TestAccEC2EBSSnapshotBlockPublicAccess_basic (24.73s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	29.896s

[ewbankkit]

@stefanfreitag Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.