Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Add eks_properties.*.pod_properties.*.image_pull_secret argument #38520

Closed
YakDriver opened this issue Jul 24, 2024 · 4 comments · Fixed by #38517
Closed

[Enhancement]: Add eks_properties.*.pod_properties.*.image_pull_secret argument #38520

YakDriver opened this issue Jul 24, 2024 · 4 comments · Fixed by #38517
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/batch Issues and PRs that pertain to the batch service.
Milestone

Comments

@YakDriver
Copy link
Member

YakDriver commented Jul 24, 2024

Description

In Batch Job Definition, eks_properties.*.pod_properties.*.image_pull_secretreferences a Kubernetes secret resource. Currently, this cannot be defined.

Affected Resource(s) and/or Data Source(s)

  • aws_batch_job_definition

Potential Terraform Configuration

resource "aws_batch_job_definition" "test" {
  name = "chihiro"
  type = "container"
  eks_properties {
    pod_properties {
      host_network = true
      containers {
        image = "public.ecr.aws/amazonlinux/amazonlinux:1"
        command = [
          "sleep",
          "60"
        ]
        resources {
          limits = {
            cpu    = "1"
            memory = "1024Mi"
          }
        }
      }
      image_pull_secret {
        name = "my-secret"
      }
      image_pull_secret {
        name = "my-secret2"
      }
      metadata {
        labels = {
          environment = "test"
          name        = "haku"
        }
      }
    }
  }
}

References

Would you like to implement a fix?

None

@YakDriver YakDriver added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 24, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/batch Issues and PRs that pertain to the batch service. label Jul 24, 2024
@YakDriver YakDriver self-assigned this Jul 24, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jul 24, 2024
Copy link

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.60.0 milestone Jul 24, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jul 25, 2024
Copy link

This functionality has been released in v5.60.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/batch Issues and PRs that pertain to the batch service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant