-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add scaling_configuration.seconds_before_timeout arg for aws_db_cluster #38451
feat: Add scaling_configuration.seconds_before_timeout arg for aws_db_cluster #38451
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Thank you for your contribution! 🚀 Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the Additional details:
|
2255531
to
6ba717f
Compare
Thank you for your contribution! 🚀 Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the Additional details:
|
6ba717f
to
ae33369
Compare
Thank you for your contribution! 🚀 Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the Additional details:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccRDSCluster_scaling\|TestAccRDSCluster_basic' PKG=rds ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/rds/... -v -count 1 -parallel 3 -run=TestAccRDSCluster_scaling\|TestAccRDSCluster_basic -timeout 720m
=== RUN TestAccRDSCluster_basic
=== PAUSE TestAccRDSCluster_basic
=== RUN TestAccRDSCluster_scaling
=== PAUSE TestAccRDSCluster_scaling
=== CONT TestAccRDSCluster_basic
=== CONT TestAccRDSCluster_scaling
--- PASS: TestAccRDSCluster_basic (145.22s)
--- PASS: TestAccRDSCluster_scaling (324.41s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/rds 329.338s
@acwwat Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.60.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR is to add the
seconds_before_timeout
argument to thescaling_configuration
configuration block of theaws_db_cluster
resource.Relations
Closes #38119
References
Referred to ScalingConfiguration for specs.
Output from Acceptance Testing