Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/aws_efs_access_point: Set id to access point ID #38372

Merged
merged 4 commits into from
Jul 15, 2024

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Jul 15, 2024

Description

Sets id to access point ID, not file system ID.

Relations

Closes #38355.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccEFSAccessPointDataSource_' PKG=efs
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/efs/... -v -count 1 -parallel 20  -run=TestAccEFSAccessPointDataSource_ -timeout 360m
=== RUN   TestAccEFSAccessPointDataSource_basic
=== PAUSE TestAccEFSAccessPointDataSource_basic
=== CONT  TestAccEFSAccessPointDataSource_basic
--- PASS: TestAccEFSAccessPointDataSource_basic (21.52s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/efs	26.416s

@ewbankkit ewbankkit requested a review from a team as a code owner July 15, 2024 11:50
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@ewbankkit ewbankkit changed the title B d/aws efs access point.id regression d/aws_efs_access_point: Set id to access point ID Jul 15, 2024
@terraform-aws-provider terraform-aws-provider bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/efs Issues and PRs that pertain to the efs service. size/XS Managed by automation to categorize the size of a PR. labels Jul 15, 2024
@ewbankkit ewbankkit added the bug Addresses a defect in current functionality. label Jul 15, 2024
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

% make testacc TESTARGS='-run=TestAccEFSAccessPointDataSource_' PKG=efs

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/efs/... -v -count 1 -parallel 20  -run=TestAccEFSAccessPointDataSource_ -timeout 360m
=== RUN   TestAccEFSAccessPointDataSource_basic
=== PAUSE TestAccEFSAccessPointDataSource_basic
=== CONT  TestAccEFSAccessPointDataSource_basic
--- PASS: TestAccEFSAccessPointDataSource_basic (24.67s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/efs	30.615s

@ewbankkit ewbankkit merged commit 8da1c64 into main Jul 15, 2024
53 checks passed
@ewbankkit ewbankkit deleted the b-d/aws_efs_access_point.id-regression branch July 15, 2024 13:49
@github-actions github-actions bot added this to the v5.59.0 milestone Jul 15, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Jul 15, 2024
Copy link

This functionality has been released in v5.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/efs Issues and PRs that pertain to the efs service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Unexpected id from data.aws_efs_access_point when upgrading yo 5.58.0
2 participants