Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_elasticache_serverless_cache #38269

Merged

Conversation

nikhil-goenka
Copy link
Contributor

@nikhil-goenka nikhil-goenka commented Jul 6, 2024

Description

Relations

Closes #36317

References

Update requires no interruption for cache_usage_limits
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-elasticache-serverlesscache-cacheusagelimits.html

Output from Acceptance Testing

% make testacc TESTS=TestAccElastiCacheServerlessCache_updatesc PKG=elasticache
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/elasticache/... -v -count 1 -parallel 20 -run='TestAccElastiCacheServerlessCache_updatesc'  -timeout 360m
=== RUN   TestAccElastiCacheServerlessCache_updatesc
=== PAUSE TestAccElastiCacheServerlessCache_updatesc
=== CONT  TestAccElastiCacheServerlessCache_updatesc
--- PASS: TestAccElastiCacheServerlessCache_updatesc (678.82s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elasticache	704.465s
% make testacc TESTS=TestAccElastiCacheServerlessCache_ PKG=elasticache 
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/elasticache/... -v -count 1 -parallel 20 -run='TestAccElastiCacheServerlessCache_'  -timeout 360m
=== RUN   TestAccElastiCacheServerlessCache_basic
=== PAUSE TestAccElastiCacheServerlessCache_basic
=== RUN   TestAccElastiCacheServerlessCache_basicRedis
=== PAUSE TestAccElastiCacheServerlessCache_basicRedis
=== RUN   TestAccElastiCacheServerlessCache_full
=== PAUSE TestAccElastiCacheServerlessCache_full
=== RUN   TestAccElastiCacheServerlessCache_fullRedis
=== PAUSE TestAccElastiCacheServerlessCache_fullRedis
=== RUN   TestAccElastiCacheServerlessCache_update
=== PAUSE TestAccElastiCacheServerlessCache_update
=== RUN   TestAccElastiCacheServerlessCache_updatesc
=== PAUSE TestAccElastiCacheServerlessCache_updatesc
=== RUN   TestAccElastiCacheServerlessCache_disappears
=== PAUSE TestAccElastiCacheServerlessCache_disappears
=== RUN   TestAccElastiCacheServerlessCache_tags
=== PAUSE TestAccElastiCacheServerlessCache_tags
=== CONT  TestAccElastiCacheServerlessCache_basic
=== CONT  TestAccElastiCacheServerlessCache_update
=== CONT  TestAccElastiCacheServerlessCache_disappears
=== CONT  TestAccElastiCacheServerlessCache_tags
=== CONT  TestAccElastiCacheServerlessCache_fullRedis
=== CONT  TestAccElastiCacheServerlessCache_updatesc
=== CONT  TestAccElastiCacheServerlessCache_full
=== CONT  TestAccElastiCacheServerlessCache_basicRedis
--- PASS: TestAccElastiCacheServerlessCache_disappears (383.64s)
--- PASS: TestAccElastiCacheServerlessCache_basicRedis (509.98s)
--- PASS: TestAccElastiCacheServerlessCache_tags (539.34s)
--- PASS: TestAccElastiCacheServerlessCache_fullRedis (550.91s)
--- PASS: TestAccElastiCacheServerlessCache_basic (553.92s)
--- PASS: TestAccElastiCacheServerlessCache_full (573.27s)
--- PASS: TestAccElastiCacheServerlessCache_update (592.73s)
--- PASS: TestAccElastiCacheServerlessCache_updatesc (833.35s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elasticache	853.832s

...

@nikhil-goenka nikhil-goenka requested a review from a team as a code owner July 6, 2024 15:27
Copy link

github-actions bot commented Jul 6, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/elasticache Issues and PRs that pertain to the elasticache service. labels Jul 6, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jul 6, 2024
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jul 8, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccElastiCacheServerlessCache_updatesc\|TestAccElastiCacheServerlessCache_fullRedis' PKG=elasticache
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/elasticache/... -v -count 1 -parallel 20  -run=TestAccElastiCacheServerlessCache_updatesc\|TestAccElastiCacheServerlessCache_fullRedis -timeout 360m
=== RUN   TestAccElastiCacheServerlessCache_fullRedis
=== PAUSE TestAccElastiCacheServerlessCache_fullRedis
=== RUN   TestAccElastiCacheServerlessCache_updatesc
=== PAUSE TestAccElastiCacheServerlessCache_updatesc
=== CONT  TestAccElastiCacheServerlessCache_fullRedis
=== CONT  TestAccElastiCacheServerlessCache_updatesc
--- PASS: TestAccElastiCacheServerlessCache_fullRedis (345.53s)
--- PASS: TestAccElastiCacheServerlessCache_updatesc (673.12s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elasticache	678.149s

@ewbankkit ewbankkit added the bug Addresses a defect in current functionality. label Jul 8, 2024
@ewbankkit
Copy link
Contributor

@nikhil-goenka Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit fe926cd into hashicorp:main Jul 8, 2024
47 checks passed
@github-actions github-actions bot added this to the v5.58.0 milestone Jul 8, 2024
Copy link

This functionality has been released in v5.58.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@nikhil-goenka nikhil-goenka deleted the b/aws_elasticache_serverless_cache branch July 16, 2024 16:58
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/elasticache Issues and PRs that pertain to the elasticache service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
2 participants