fix: Add master password to ModifyDbClusterInput when creating DocumentDb from Snapshot

[VictorCodesseira]

Description

When creating a DocDB cluster from a Snapshot, the master user password is not changed. This prevents running automations based on generated random_password, along other issues.

The change is basically checking for this variable and adding to the ModifyDbClusterInput object, when snapshot_identifier is set.

Relations

Closes #13472

Output from Acceptance Testing

I didn't run acceptance tests, since there was already no test where snapshot_identifier is set.

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @VictorCodesseira 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAcc.*_basic$$' PKG=docdb ACCTEST_PARALLELISM=4
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/docdb/... -v -count 1 -parallel 4  -run=TestAcc.*_basic$ -timeout 360m
2024/10/29 14:09:43 Initializing Terraform AWS Provider...
=== RUN   TestAccDocDBClusterInstance_basic
=== PAUSE TestAccDocDBClusterInstance_basic
=== RUN   TestAccDocDBClusterParameterGroup_basic
=== PAUSE TestAccDocDBClusterParameterGroup_basic
=== RUN   TestAccDocDBClusterSnapshot_basic
=== PAUSE TestAccDocDBClusterSnapshot_basic
=== RUN   TestAccDocDBCluster_basic
=== PAUSE TestAccDocDBCluster_basic
=== RUN   TestAccDocDBEngineVersionDataSource_basic
=== PAUSE TestAccDocDBEngineVersionDataSource_basic
=== RUN   TestAccDocDBEventSubscription_basic
=== PAUSE TestAccDocDBEventSubscription_basic
=== RUN   TestAccDocDBGlobalCluster_basic
=== PAUSE TestAccDocDBGlobalCluster_basic
=== RUN   TestAccDocDBGlobalCluster_SourceDBClusterIdentifier_basic
=== PAUSE TestAccDocDBGlobalCluster_SourceDBClusterIdentifier_basic
=== RUN   TestAccDocDBOrderableDBInstanceDataSource_basic
=== PAUSE TestAccDocDBOrderableDBInstanceDataSource_basic
=== RUN   TestAccDocDBSubnetGroup_basic
=== PAUSE TestAccDocDBSubnetGroup_basic
=== CONT  TestAccDocDBClusterInstance_basic
=== CONT  TestAccDocDBEventSubscription_basic
=== CONT  TestAccDocDBCluster_basic
=== CONT  TestAccDocDBOrderableDBInstanceDataSource_basic
--- PASS: TestAccDocDBOrderableDBInstanceDataSource_basic (9.07s)
=== CONT  TestAccDocDBSubnetGroup_basic
--- PASS: TestAccDocDBSubnetGroup_basic (20.64s)
=== CONT  TestAccDocDBClusterSnapshot_basic
--- PASS: TestAccDocDBCluster_basic (117.47s)
=== CONT  TestAccDocDBClusterParameterGroup_basic
--- PASS: TestAccDocDBClusterParameterGroup_basic (13.24s)
=== CONT  TestAccDocDBEngineVersionDataSource_basic
--- PASS: TestAccDocDBEngineVersionDataSource_basic (8.09s)
=== CONT  TestAccDocDBGlobalCluster_SourceDBClusterIdentifier_basic
--- PASS: TestAccDocDBEventSubscription_basic (178.64s)
=== CONT  TestAccDocDBGlobalCluster_basic
--- PASS: TestAccDocDBGlobalCluster_basic (14.44s)
--- PASS: TestAccDocDBGlobalCluster_SourceDBClusterIdentifier_basic (118.03s)
--- PASS: TestAccDocDBClusterSnapshot_basic (272.18s)
--- PASS: TestAccDocDBClusterInstance_basic (1779.67s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/docdb	1784.821s

[ewbankkit]

@VictorCodesseira Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.74.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.