-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add approximate_creation_date_time_precision
to aws_dynamodb_kinesis_streaming_destination
#38098
Add approximate_creation_date_time_precision
to aws_dynamodb_kinesis_streaming_destination
#38098
Conversation
… generated attribute files
…both on create and on read, document default behaviour
…ion date time precision
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @rob93c 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
This commit adds an initial implementation of the `iceberg` destination type for Firehose delivery streams.
….14 (terraform_deprecated_interpolation)'.
# Conflicts: # internal/service/dynamodb/kinesis_streaming_destination.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccDynamoDBKinesisStreamingDestination_' PKG=dynamodb ACCTEST_PARALLELISM=2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/dynamodb/... -v -count 1 -parallel 2 -run=TestAccDynamoDBKinesisStreamingDestination_ -timeout 360m
2024/10/23 12:16:06 Initializing Terraform AWS Provider...
=== RUN TestAccDynamoDBKinesisStreamingDestination_basic
=== PAUSE TestAccDynamoDBKinesisStreamingDestination_basic
=== RUN TestAccDynamoDBKinesisStreamingDestination_approximateCreationDateTimePrecision
=== PAUSE TestAccDynamoDBKinesisStreamingDestination_approximateCreationDateTimePrecision
=== RUN TestAccDynamoDBKinesisStreamingDestination_disappears
=== PAUSE TestAccDynamoDBKinesisStreamingDestination_disappears
=== RUN TestAccDynamoDBKinesisStreamingDestination_Disappears_dynamoDBTable
=== PAUSE TestAccDynamoDBKinesisStreamingDestination_Disappears_dynamoDBTable
=== CONT TestAccDynamoDBKinesisStreamingDestination_basic
=== CONT TestAccDynamoDBKinesisStreamingDestination_disappears
--- PASS: TestAccDynamoDBKinesisStreamingDestination_disappears (53.81s)
=== CONT TestAccDynamoDBKinesisStreamingDestination_approximateCreationDateTimePrecision
--- PASS: TestAccDynamoDBKinesisStreamingDestination_basic (61.46s)
=== CONT TestAccDynamoDBKinesisStreamingDestination_Disappears_dynamoDBTable
--- PASS: TestAccDynamoDBKinesisStreamingDestination_approximateCreationDateTimePrecision (55.03s)
--- PASS: TestAccDynamoDBKinesisStreamingDestination_Disappears_dynamoDBTable (52.87s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb 119.626s
% make testacc TESTARGS='-run=TestAccFirehoseDeliveryStream_basic\|TestAccFirehoseDeliveryStream_iceberg' PKG=firehose
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/firehose/... -v -count 1 -parallel 20 -run=TestAccFirehoseDeliveryStream_basic\|TestAccFirehoseDeliveryStream_iceberg -timeout 360m
2024/10/23 14:33:05 Initializing Terraform AWS Provider...
=== RUN TestAccFirehoseDeliveryStream_basic
=== PAUSE TestAccFirehoseDeliveryStream_basic
=== RUN TestAccFirehoseDeliveryStream_icebergUpdates
delivery_stream_test.go:1011: Unresolvable Glue permission issue
--- SKIP: TestAccFirehoseDeliveryStream_icebergUpdates (0.00s)
=== CONT TestAccFirehoseDeliveryStream_basic
--- PASS: TestAccFirehoseDeliveryStream_basic (160.11s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/firehose 165.175s
This functionality has been released in v5.73.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Add
approximate_creation_date_time_precision
toaws_dynamodb_kinesis_streaming_destination
resource to be able to set a timestamp precision (only accepted values are either MILLISECOND or MICROSECOND).References
EnableKinesisStreamingConfiguration API documentation
Closes #38753.
Closes #39844.
Output from Acceptance Testing