Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase limit for Amazon API Gateway integration timeout beyond 29 s… #38010

Merged
merged 4 commits into from
Jun 17, 2024
Merged

Increase limit for Amazon API Gateway integration timeout beyond 29 s… #38010

merged 4 commits into from
Jun 17, 2024

Conversation

Bhavyeshshah
Copy link
Contributor

@Bhavyeshshah Bhavyeshshah commented Jun 17, 2024

Description

AWS recently announced that the REST API Gateways had an increased timeout limit and this bumps that max timeout validation check from 29 seconds to 300 seconds.

User need to raise a Service Quota Ticket to increase time beyond 29 seconds

Currently in Terraform we have update the range and documentation of api_gateway from lower limit as 50 milliseconds and upper limit can be 3,00,000 milliseconds

Relations

Closes #23417.
Closes #37859.
Closes #37905.

References

https://aws.amazon.com/about-aws/whats-new/2024/06/amazon-api-gateway-integration-timeout-limit-29-seconds
https://docs.aws.amazon.com/general/latest/gr/aws_service_limits.html
https://docs.aws.amazon.com/apigateway/latest/developerguide/limits.html#api-gateway-execution-service-limits-table

Output from Acceptance Testing

% make testacc TESTS=TestAccAPIGatewayIntegration_basic PKG=apigateway      
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apigateway/... -v -count 1 -parallel 20 -run='TestAccAPIGatewayIntegration_basic'  -timeout 600m
=== RUN   TestAccAPIGatewayIntegration_basic
=== PAUSE TestAccAPIGatewayIntegration_basic
=== CONT  TestAccAPIGatewayIntegration_basic
--- PASS: TestAccAPIGatewayIntegration_basic (92.87s)
PASS
ok      [github.com/hashicorp/terraform-provider-aws/internal/service/apigateway](http://github.com/hashicorp/terraform-provider-aws/internal/service/apigateway) 212.006s

...

@Bhavyeshshah Bhavyeshshah requested a review from a team as a code owner June 17, 2024 11:13
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/apigateway Issues and PRs that pertain to the apigateway service. labels Jun 17, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jun 17, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @Bhavyeshshah 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jun 17, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit
Copy link
Contributor

@Bhavyeshshah Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit a9c9838 into hashicorp:main Jun 17, 2024
50 checks passed
@github-actions github-actions bot added this to the v5.55.0 milestone Jun 17, 2024
Copy link

This functionality has been released in v5.55.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/apigateway Issues and PRs that pertain to the apigateway service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
2 participants