-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_vpc_endpoint_private_dns: new resource #37628
Conversation
Community NoteVoting for Prioritization
For Submitters
|
9690cfb
to
dc0533c
Compare
This resource will allow practitioners to enable and disable private DNS for a VPC endpoint. This allows private DNS to be enabled on the VPC endpoint distinctly from the initial create operation, supporting use cases where additional actions must be taken between creation of the endpoint and enabling of private DNS. ```terraform resource "aws_vpc_endpoint" "test" { vpc_id = aws_vpc.test.id service_name = "producer service name" vpc_endpoint_type = "Interface" } resource "aws_vpc_endpoint_connection_accepter" "test" { vpc_endpoint_service_id = "producer service id" vpc_endpoint_id = aws_vpc_endpoint.test.id } resource "aws_vpc_endpoint_private_dns" "test" { depends_on = [aws_vpc_endpoint_connection_accepter.test] vpc_endpoint_id = aws_vpc_endpoint.test.id private_dns_enabled = true } ``` ```console % make testacc PKG=ec2 TESTS="TestAccVPCEndpointPrivateDNS_" ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCEndpointPrivateDNS_' -timeout 360m --- PASS: TestAccVPCEndpointPrivateDNS_disappears_Endpoint (127.05s) --- PASS: TestAccVPCEndpointPrivateDNS_basic (167.16s) --- PASS: TestAccVPCEndpointPrivateDNS_update (167.83s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 172.994s ```
dc0533c
to
7a03500
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
make testacc TESTARGS="-run=TestAccVPCEndpointPrivateDNS_" PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccVPCEndpointPrivateDNS_ -timeout 360m
--- PASS: TestAccVPCEndpointPrivateDNS_update (147.14s)
--- PASS: TestAccVPCEndpointPrivateDNS_basic (149.55s)
--- PASS: TestAccVPCEndpointPrivateDNS_disappears_Endpoint (157.96s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 163.744s
This functionality has been released in v5.51.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This resource will allow practitioners to enable and disable private DNS for a VPC endpoint.
This allows private DNS to be enabled on the VPC endpoint distinctly from the initial create operation, supporting use cases where additional actions must be taken between creation of the endpoint and enabling of private DNS.
Relations
Closes #7148
References
Output from Acceptance Testing