Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource Export #36847

Merged
merged 15 commits into from
Apr 22, 2024
Merged

New Resource Export #36847

merged 15 commits into from
Apr 22, 2024

Conversation

nam054
Copy link
Contributor

@nam054 nam054 commented Apr 11, 2024

Description

Add new resource Export to service BCM Data Exports.

Relations

Closes #35343

References

Output from Acceptance Testing

> make testacc TESTARGS="-run=TestAccBCMDataExportsExport_" PKG=bcmdataexports
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/bcmdataexports/... -v -count 1 -parallel 20  -run=TestAccBCMDataExportsExport_ -timeout 360m
=== RUN   TestAccBCMDataExportsExport_basic
=== PAUSE TestAccBCMDataExportsExport_basic
=== RUN   TestAccBCMDataExportsExport_disappears
=== PAUSE TestAccBCMDataExportsExport_disappears
=== RUN   TestAccBCMDataExportsExport_tags
=== PAUSE TestAccBCMDataExportsExport_tags
=== RUN   TestAccBCMDataExportsExport_updateTable
=== PAUSE TestAccBCMDataExportsExport_updateTable
=== CONT  TestAccBCMDataExportsExport_basic
=== CONT  TestAccBCMDataExportsExport_disappears
=== CONT  TestAccBCMDataExportsExport_tags
=== CONT  TestAccBCMDataExportsExport_updateTable
--- PASS: TestAccBCMDataExportsExport_disappears (18.74s)
--- PASS: TestAccBCMDataExportsExport_basic (20.92s)
--- PASS: TestAccBCMDataExportsExport_updateTable (32.98s)
--- PASS: TestAccBCMDataExportsExport_tags (43.09s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/bcmdataexports     48.967s
...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. tags Pertains to resource tagging. generators Relates to code generators. service/bcmdataexports Issues and PRs that pertain to the bcmdataexports service. labels Apr 11, 2024
Copy link

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 11, 2024
@github-actions github-actions bot added the sweeper Pertains to changes to or issues with the sweeper. label Apr 16, 2024
@nam054 nam054 force-pushed the f-export-resource branch from e6515be to e9f3584 Compare April 17, 2024 00:01
@nam054 nam054 marked this pull request as ready for review April 17, 2024 18:29
internal/service/bcmdataexports/export.go Outdated Show resolved Hide resolved
internal/service/bcmdataexports/export.go Outdated Show resolved Hide resolved
internal/service/bcmdataexports/sweep.go Outdated Show resolved Hide resolved
@nam054 nam054 requested a review from johnsonaj April 22, 2024 17:41
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

% make testacc TESTARGS="-run=TestAccBCMDataExportsExport_" PKG=bcmdataexports

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/bcmdataexports/... -v -count 1 -parallel 20  -run=TestAccBCMDataExportsExport_ -timeout 360m
=== RUN   TestAccBCMDataExportsExport_basic
=== PAUSE TestAccBCMDataExportsExport_basic
=== RUN   TestAccBCMDataExportsExport_disappears
=== PAUSE TestAccBCMDataExportsExport_disappears
=== RUN   TestAccBCMDataExportsExport_tags
=== PAUSE TestAccBCMDataExportsExport_tags
=== RUN   TestAccBCMDataExportsExport_updateTable
=== PAUSE TestAccBCMDataExportsExport_updateTable
=== CONT  TestAccBCMDataExportsExport_basic
=== CONT  TestAccBCMDataExportsExport_tags
=== CONT  TestAccBCMDataExportsExport_updateTable
=== CONT  TestAccBCMDataExportsExport_disappears
--- PASS: TestAccBCMDataExportsExport_disappears (16.59s)
--- PASS: TestAccBCMDataExportsExport_basic (18.49s)
--- PASS: TestAccBCMDataExportsExport_updateTable (28.81s)
--- PASS: TestAccBCMDataExportsExport_tags (37.65s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/bcmdataexports	43.467s

@nam054 nam054 merged commit 2ded024 into main Apr 22, 2024
45 checks passed
@nam054 nam054 deleted the f-export-resource branch April 22, 2024 19:11
@github-actions github-actions bot added this to the v5.47.0 milestone Apr 22, 2024
github-actions bot pushed a commit that referenced this pull request Apr 22, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 26, 2024
Copy link

This functionality has been released in v5.47.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/bcmdataexports Issues and PRs that pertain to the bcmdataexports service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Support Billing and Cost Management Data Exports (ie CUR 2.0)
2 participants