Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: DMS aws_dms_replication_task descriptive ARN #36505

Closed
RobbertDM opened this issue Mar 21, 2024 · 5 comments · Fixed by #36901
Closed

[Enhancement]: DMS aws_dms_replication_task descriptive ARN #36505

RobbertDM opened this issue Mar 21, 2024 · 5 comments · Fixed by #36901
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/dms Issues and PRs that pertain to the dms service.
Milestone

Comments

@RobbertDM
Copy link

Description

In the AWS console, when creating a new DMS replication task, you can set a Task identifier, but also an ARN:

Descriptive Amazon Resource Name (ARN) - optional
A friendly name to override the default DMS ARN. You cannot modify it after creation

That way, you don't end up with unpredictable ARNs for ReplicationTasks, like
arn:aws:dms:eu-west-3:123456789012:task:KAEGH2KCHYX4SVGK34ZFEDMG5VGASMXBXDXZ7ZI
but rather
arn:aws:dms:eu-west-3:123456789012:task:my-descriptive-task .

In the AWS API, this field is called ResourceIdentifier

Affected Resource(s) and/or Data Source(s)

aws_dms_replication_task

Potential Terraform Configuration

# Create a new replication task
resource "aws_dms_replication_task" "test" {
  cdc_start_time            = "1993-05-21T05:50:00Z"
  migration_type            = "full-load"
  replication_instance_arn  = aws_dms_replication_instance.test-dms-replication-instance-tf.replication_instance_arn
  replication_task_id       = "test-dms-replication-task-tf"
  replication_task_settings = "..."
  source_endpoint_arn       = aws_dms_endpoint.test-dms-source-endpoint-tf.endpoint_arn
  table_mappings            = "{\"rules\":[{\"rule-type\":\"selection\",\"rule-id\":\"1\",\"rule-name\":\"1\",\"object-locator\":{\"schema-name\":\"%\",\"table-name\":\"%\"},\"rule-action\":\"include\"}]}"

  tags = {
    Name = "test"
  }

  target_endpoint_arn = aws_dms_endpoint.test-dms-target-endpoint-tf.endpoint_arn
  resource_identifier = "my-descriptive-resource-identifier"
}

References

No response

Would you like to implement a fix?

None

@RobbertDM RobbertDM added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 21, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/dms Issues and PRs that pertain to the dms service. label Mar 21, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 21, 2024
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Mar 21, 2024
Copy link

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.46.0 milestone Apr 15, 2024
@RobbertDM
Copy link
Author

Thanks a lot for your work @nikhil-goenka
I guess the same applies for aws_dms_endpoint, aws_dms_s3_endpoint and aws_dms_replication_instance.
TBH it's a bit weird to me that DMS has this field and doesn't just use the name to generate an ARN like other services 🤷

Copy link

This functionality has been released in v5.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/dms Issues and PRs that pertain to the dms service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants