Add dedicated_log_volume argument to aws_db_instance resource.

[askreet]

Description

Dedicated log volumes can be used to reduce I/O on the primary storage and WAL disks. They're recommended by AWS for PostgreSQL, MariaDB and MySQL databases over 5 TB in size.

This patch adds support for configuring the DedicatedLogVolume property of a DB Instance.

Relations

Closes #36276.

References

See inline doc updates.

Output from Acceptance Testing

Include a new acceptance test which enables this setting on a DB Instance. The DB instance is pinned to PG 15.6, as the latest PG database available (16.x) does not support DLV yet.

❯ make testacc TESTS=TestAccRDSInstance_dedicatedLogVolume_enable PKG=rds AWS_PROFILE=default AWS_DEFAULT_REGION=us-east-1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSInstance_dedicatedLogVolume_enable'  -timeout 360m
=== RUN   TestAccRDSInstance_dedicatedLogVolume_enable
=== PAUSE TestAccRDSInstance_dedicatedLogVolume_enable
=== CONT  TestAccRDSInstance_dedicatedLogVolume_enable
--- PASS: TestAccRDSInstance_dedicatedLogVolume_enable (852.09s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	857.782s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @askreet 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[askreet]

Hey @justinretzolk, anything I can do to help move this one along?

[gdavison]

Thanks for the PR, @askreet. 🚀

I've made a couple tweaks to the tests

[askreet]

Thanks @gdavison. Excited this is landing. I appreciate the help!

[github-actions]

This functionality has been released in v5.47.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.