-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support replication specification for aws keyspaces #36331
Support replication specification for aws keyspaces #36331
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @shrutha1988 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
# Conflicts: # internal/service/keyspaces/keyspace_test.go
…: 0 or 2; Actual: 1]'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccKeyspacesKeyspace_' PKG=keyspaces ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/keyspaces/... -v -count 1 -parallel 3 -run=TestAccKeyspacesKeyspace_ -timeout 360m
2024/10/29 16:11:05 Initializing Terraform AWS Provider...
=== RUN TestAccKeyspacesKeyspace_basic
=== PAUSE TestAccKeyspacesKeyspace_basic
=== RUN TestAccKeyspacesKeyspace_replicationSpecificationMulti
=== PAUSE TestAccKeyspacesKeyspace_replicationSpecificationMulti
=== RUN TestAccKeyspacesKeyspace_disappears
=== PAUSE TestAccKeyspacesKeyspace_disappears
=== RUN TestAccKeyspacesKeyspace_tags
=== PAUSE TestAccKeyspacesKeyspace_tags
=== CONT TestAccKeyspacesKeyspace_basic
=== CONT TestAccKeyspacesKeyspace_disappears
=== CONT TestAccKeyspacesKeyspace_replicationSpecificationMulti
--- PASS: TestAccKeyspacesKeyspace_disappears (57.98s)
=== CONT TestAccKeyspacesKeyspace_tags
--- PASS: TestAccKeyspacesKeyspace_basic (59.89s)
--- PASS: TestAccKeyspacesKeyspace_replicationSpecificationMulti (117.32s)
--- PASS: TestAccKeyspacesKeyspace_tags (75.54s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/keyspaces 138.499s
Completing the pull request. |
@shrutha1988 Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.74.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
AWS Keyspaces started supporting Multi region replication since mid of last year. The current Pull Request adds supports for optionally specifying the replication specification while creating AWS keyspaces. The replication specification includes ReplicationStrategy(Can hold values of SINGLE_REGION and MULTI_REGION), the region list if the MULTI_REGION replication strategy is specified. Please review and let me know if the changes are sufficient. Let me know in case more changes are needed to handle this scenario. In tests, we have covered both the replication scenarios and the tests are creating the required keyspaces with valid replications. All the tests have passed now.
Expected resource would look like this:
Relations
Closes #32150.
References
https://aws.amazon.com/blogs/database/announcing-amazon-keyspaces-multi-region-replication/
Output from Acceptance Testing