-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement apprunner_hosted_zone_id #36288
feat: implement apprunner_hosted_zone_id #36288
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @mussinbenarbia 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
Hello, this is my first contribution, please pardon any oversights. I read and tried to follow the raising a pull request guide and I have a couple of questions: Implicit IDThe guide mentions:
Does this apply to this data source? I feel like the resource id the guide refers to, and the hosted zone ID this data source aims to provide are slightly different. Should the field have a different name? I tried following the existing https://github.com/hashicorp/terraform-provider-aws/blob/main/internal/service/elbv2/hosted_zone_id_data_source.go Should I use SetID and Set()?I just noticed the guide recommends using I'll address any comments as soon as possible. Thank you! |
@mussinbenarbia Thanks for the contribution 🎉 👏. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccAppRunnerHostedZoneIDDataSource_' PKG=apprunner
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apprunner/... -v -count 1 -parallel 20 -run=TestAccAppRunnerHostedZoneIDDataSource_ -timeout 360m
=== RUN TestAccAppRunnerHostedZoneIDDataSource_basic
=== PAUSE TestAccAppRunnerHostedZoneIDDataSource_basic
=== CONT TestAccAppRunnerHostedZoneIDDataSource_basic
--- PASS: TestAccAppRunnerHostedZoneIDDataSource_basic (18.76s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/apprunner 25.373s
@mussinbenarbia Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.41.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Adds a Data Source to get the HostedZoneId of an AWS App Runner service.
This can be consumed for the purpose of using it in an AWS Route53 Alias record, when associating a custom domain with a service.
Similar to https://github.com/hashicorp/terraform-provider-aws/blob/main/internal/service/elbv2/hosted_zone_id_data_source.go
Relations
There is currently no issue for this. Should I open one?
Closes #36359.
References
https://docs.aws.amazon.com/apprunner/latest/dg/manage-custom-domains-route53.html
https://docs.aws.amazon.com/general/latest/gr/apprunner.html
Output from Acceptance Testing