resource/aws_db_instance: Sets parameter_group_name on replica when source is in different region

[gdavison]

Description

When creating a replica RDS Instance, the parameter group was set during a modify step after creation. This is because the parameter group cannot be set when creating a replica in the same region as the source. When using parameter values that cannot be changed after creation, such as the max_string_size for Oracle, this would cause errors when creating a replica.

Now sets the parameter group on creation when the source DB is located in a different region.

Relations

Closes #31719

References

Output from Acceptance Testing

% make testacc PKG=rds TESTS=TestAccRDSInstance_ReplicateSourceDB

--- PASS: TestAccRDSInstance_ReplicateSourceDB_allowMajorVersionUpgrade (1313.53s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_iops (1374.11s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_allocatedStorage (1496.60s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_availabilityZone (1505.49s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_backupWindow (1506.24s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_maintenanceWindow (1506.33s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_dbSubnetGroupNameVPCSecurityGroupIDs (1556.60s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_performanceInsightsEnabled (1567.78s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_autoMinorVersionUpgrade (1576.46s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_iamDatabaseAuthenticationEnabled (1576.64s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_allocatedStorageAndIops (1623.85s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_addLater (1628.32s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_nameGenerated (1642.10s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_maxAllocatedStorage (1706.99s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_basic (1707.61s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_parameterGroupNameSetOnReplica (1737.21s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_dbSubnetGroupName (1833.15s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_backupRetentionPeriod (1920.85s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_namePrefix (1452.86s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_networkType (1423.24s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_replicaMode (2847.91s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_vpcSecurityGroupIDs (1329.94s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_parameterGroupNameSameSetOnBoth (1409.32s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_caCertificateIdentifier (1481.40s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_port (1622.38s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_monitoring (1677.64s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_parameterGroupNameReplicaCopiesValue (1804.33s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_monitoring_sourceAlreadyExists (1733.31s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_parameterGroupNameDifferentSetOnBoth (1904.54s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_multiAZ (2119.87s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_CrossRegion_parameterGroupNameEquivalent (3843.25s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_parameterGroupTwoStep (3090.11s)

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRDSInstance_ReplicateSourceDB_CrossRegion_parameterGroupNameEquivalent\|TestAccRDSInstance_ReplicateSourceDB_basic' PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20  -run=TestAccRDSInstance_ReplicateSourceDB_CrossRegion_parameterGroupNameEquivalent\|TestAccRDSInstance_ReplicateSourceDB_basic -timeout 360m
=== RUN   TestAccRDSInstance_ReplicateSourceDB_basic
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_basic
=== RUN   TestAccRDSInstance_ReplicateSourceDB_CrossRegion_parameterGroupNameEquivalent
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_CrossRegion_parameterGroupNameEquivalent
=== CONT  TestAccRDSInstance_ReplicateSourceDB_basic
=== CONT  TestAccRDSInstance_ReplicateSourceDB_CrossRegion_parameterGroupNameEquivalent
--- PASS: TestAccRDSInstance_ReplicateSourceDB_basic (1614.40s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_CrossRegion_parameterGroupNameEquivalent (3721.72s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	3730.069s

[github-actions]

This functionality has been released in v5.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.