Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_cloudsearch_domain: fix index_field crash on read #35900

Merged
merged 2 commits into from
Feb 21, 2024
Merged

r/aws_cloudsearch_domain: fix index_field crash on read #35900

merged 2 commits into from
Feb 21, 2024

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Feb 20, 2024

Description

A missing nil check in the flattener for the index_field argument could, under certain conditions, cause the read operation to panic.

Relations

Closes #35884

References

Output from Acceptance Testing

% make testacc PKG=cloudsearch TESTS=TestAccCloudSearchDomain_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudsearch/... -v -count 1 -parallel 20 -run='TestAccCloudSearchDomain_'  -timeout 360m

--- PASS: TestAccCloudSearchDomain_basic (708.55s)
--- PASS: TestAccCloudSearchDomain_disappears (746.41s)
--- PASS: TestAccCloudSearchDomain_sourceFields (1712.89s)
--- PASS: TestAccCloudSearchDomain_indexFields (1859.65s)
--- PASS: TestAccCloudSearchDomain_update (2328.91s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudsearch        2336.129s

@jar-b
r/aws_cloudsearch_domain: fix index_field crash on read
685e295 
A missing nil check in the flattener for the `index_field` argument could, under certain conditions, cause the read operation to panic.

```
make testacc PKG=cloudsearch TESTS=TestAccCloudSearchDomain_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudsearch/... -v -count 1 -parallel 20 -run='TestAccCloudSearchDomain_'  -timeout 360m
--- PASS: TestAccCloudSearchDomain_basic (708.55s)
--- PASS: TestAccCloudSearchDomain_disappears (746.41s)
--- PASS: TestAccCloudSearchDomain_sourceFields (1712.89s)
--- PASS: TestAccCloudSearchDomain_indexFields (1859.65s)
--- PASS: TestAccCloudSearchDomain_update (2328.91s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudsearch        2336.129s
```
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. service/cloudsearch Issues and PRs that pertain to the cloudsearch service. labels Feb 20, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 20, 2024
ewbankkit
ewbankkit approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@jar-b jar-b merged commit 3d74da9 into main Feb 21, 2024
34 checks passed
@jar-b jar-b deleted the b-cloudsearch_domain-import branch February 21, 2024 13:50
@github-actions github-actions bot added this to the v5.38.0 milestone Feb 21, 2024
github-actions bot pushed a commit that referenced this pull request Feb 21, 2024
Update CHANGELOG.md for #35900
f197c8e
@i-ate-a-vm
Copy link

Thanks for getting this fixed so quickly!

@github-actions GitHub Actions
Copy link

This functionality has been released in v5.38.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 23, 2024
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
service/cloudsearch Issues and PRs that pertain to the cloudsearch service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v5.38.0
Development

Successfully merging this pull request may close these issues.

[Bug]: Provider Crashes While Importing Cloudsearch Resource
3 participants
@jar-b @i-ate-a-vm @ewbankkit