Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_db_proxy: Change auth from TypeList to TypeSet #35819

Merged
merged 39 commits into from
Feb 15, 2024
Merged

r/aws_db_proxy: Change auth from TypeList to TypeSet #35819

merged 39 commits into from
Feb 15, 2024

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Feb 14, 2024 •
edited
Loading

Description

Changes aws_db_proxy.auth from TypeList to TypeSet to prevent re-ordering diffs.

Relations

Closes #34142.
Relates #32976.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccRDSProxy_\|TestAccRDSProxyDataSource_' PKG=rds ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 3  -run=TestAccRDSProxy_\|TestAccRDSProxyDataSource_ -timeout 360m
=== RUN   TestAccRDSProxyDataSource_basic
=== PAUSE TestAccRDSProxyDataSource_basic
=== RUN   TestAccRDSProxy_basic
=== PAUSE TestAccRDSProxy_basic
=== RUN   TestAccRDSProxy_name
=== PAUSE TestAccRDSProxy_name
=== RUN   TestAccRDSProxy_debugLogging
=== PAUSE TestAccRDSProxy_debugLogging
=== RUN   TestAccRDSProxy_idleClientTimeout
=== PAUSE TestAccRDSProxy_idleClientTimeout
=== RUN   TestAccRDSProxy_requireTLS
=== PAUSE TestAccRDSProxy_requireTLS
=== RUN   TestAccRDSProxy_roleARN
=== PAUSE TestAccRDSProxy_roleARN
=== RUN   TestAccRDSProxy_vpcSecurityGroupIDs
=== PAUSE TestAccRDSProxy_vpcSecurityGroupIDs
=== RUN   TestAccRDSProxy_authDescription
=== PAUSE TestAccRDSProxy_authDescription
=== RUN   TestAccRDSProxy_authIAMAuth
=== PAUSE TestAccRDSProxy_authIAMAuth
=== RUN   TestAccRDSProxy_authSecretARN
=== PAUSE TestAccRDSProxy_authSecretARN
=== RUN   TestAccRDSProxy_tags
=== PAUSE TestAccRDSProxy_tags
=== RUN   TestAccRDSProxy_disappears
=== PAUSE TestAccRDSProxy_disappears
=== CONT  TestAccRDSProxyDataSource_basic
=== CONT  TestAccRDSProxy_disappears
=== CONT  TestAccRDSProxy_tags
--- PASS: TestAccRDSProxy_disappears (499.79s)
=== CONT  TestAccRDSProxy_authSecretARN
--- PASS: TestAccRDSProxyDataSource_basic (552.59s)
=== CONT  TestAccRDSProxy_authIAMAuth
--- PASS: TestAccRDSProxy_tags (619.74s)
=== CONT  TestAccRDSProxy_authDescription
--- PASS: TestAccRDSProxy_authSecretARN (516.62s)
=== CONT  TestAccRDSProxy_vpcSecurityGroupIDs
--- PASS: TestAccRDSProxy_authDescription (451.24s)
=== CONT  TestAccRDSProxy_roleARN
--- PASS: TestAccRDSProxy_authIAMAuth (542.67s)
=== CONT  TestAccRDSProxy_requireTLS
--- PASS: TestAccRDSProxy_roleARN (562.92s)
=== CONT  TestAccRDSProxy_idleClientTimeout
--- PASS: TestAccRDSProxy_vpcSecurityGroupIDs (656.12s)
=== CONT  TestAccRDSProxy_debugLogging
--- PASS: TestAccRDSProxy_requireTLS (544.01s)
=== CONT  TestAccRDSProxy_name
--- PASS: TestAccRDSProxy_name (624.99s)
=== CONT  TestAccRDSProxy_basic
--- PASS: TestAccRDSProxy_idleClientTimeout (684.08s)
--- PASS: TestAccRDSProxy_debugLogging (704.35s)
--- PASS: TestAccRDSProxy_basic (492.41s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	2778.961s
% make testacc TESTARGS='-run=TestAccRDSSubnetGroupDataSource_\|TestAccRDSSubnetGroup_' PKG=rds ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 3  -run=TestAccRDSSubnetGroupDataSource_\|TestAccRDSSubnetGroup_ -timeout 360m
=== RUN   TestAccRDSSubnetGroupDataSource_basic
=== PAUSE TestAccRDSSubnetGroupDataSource_basic
=== RUN   TestAccRDSSubnetGroup_basic
=== PAUSE TestAccRDSSubnetGroup_basic
=== RUN   TestAccRDSSubnetGroup_disappears
=== PAUSE TestAccRDSSubnetGroup_disappears
=== RUN   TestAccRDSSubnetGroup_nameGenerated
=== PAUSE TestAccRDSSubnetGroup_nameGenerated
=== RUN   TestAccRDSSubnetGroup_namePrefix
=== PAUSE TestAccRDSSubnetGroup_namePrefix
=== RUN   TestAccRDSSubnetGroup_tags
=== PAUSE TestAccRDSSubnetGroup_tags
=== RUN   TestAccRDSSubnetGroup_dualStack
=== PAUSE TestAccRDSSubnetGroup_dualStack
=== RUN   TestAccRDSSubnetGroup_updateDescription
=== PAUSE TestAccRDSSubnetGroup_updateDescription
=== RUN   TestAccRDSSubnetGroup_updateSubnets
=== PAUSE TestAccRDSSubnetGroup_updateSubnets
=== CONT  TestAccRDSSubnetGroup_tags
=== CONT  TestAccRDSSubnetGroupDataSource_basic
=== CONT  TestAccRDSSubnetGroup_updateDescription
--- PASS: TestAccRDSSubnetGroupDataSource_basic (31.84s)
=== CONT  TestAccRDSSubnetGroup_updateSubnets
--- PASS: TestAccRDSSubnetGroup_updateDescription (54.51s)
=== CONT  TestAccRDSSubnetGroup_nameGenerated
--- PASS: TestAccRDSSubnetGroup_tags (75.34s)
=== CONT  TestAccRDSSubnetGroup_namePrefix
--- PASS: TestAccRDSSubnetGroup_updateSubnets (66.59s)
=== CONT  TestAccRDSSubnetGroup_dualStack
--- PASS: TestAccRDSSubnetGroup_nameGenerated (53.69s)
=== CONT  TestAccRDSSubnetGroup_disappears
--- PASS: TestAccRDSSubnetGroup_namePrefix (87.49s)
=== CONT  TestAccRDSSubnetGroup_basic
--- PASS: TestAccRDSSubnetGroup_disappears (66.11s)
--- PASS: TestAccRDSSubnetGroup_dualStack (78.25s)
--- PASS: TestAccRDSSubnetGroup_basic (41.49s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	215.116s
% make testacc TESTARGS='-run=TestAccRDSEventSubscription_' PKG=rds ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 3  -run=TestAccRDSEventSubscription_ -timeout 360m
=== RUN   TestAccRDSEventSubscription_basic
=== PAUSE TestAccRDSEventSubscription_basic
=== RUN   TestAccRDSEventSubscription_disappears
=== PAUSE TestAccRDSEventSubscription_disappears
=== RUN   TestAccRDSEventSubscription_Name_generated
=== PAUSE TestAccRDSEventSubscription_Name_generated
=== RUN   TestAccRDSEventSubscription_namePrefix
=== PAUSE TestAccRDSEventSubscription_namePrefix
=== RUN   TestAccRDSEventSubscription_tags
=== PAUSE TestAccRDSEventSubscription_tags
=== RUN   TestAccRDSEventSubscription_categories
=== PAUSE TestAccRDSEventSubscription_categories
=== RUN   TestAccRDSEventSubscription_sourceIDs
=== PAUSE TestAccRDSEventSubscription_sourceIDs
=== CONT  TestAccRDSEventSubscription_basic
=== CONT  TestAccRDSEventSubscription_tags
=== CONT  TestAccRDSEventSubscription_Name_generated
--- PASS: TestAccRDSEventSubscription_basic (85.48s)
=== CONT  TestAccRDSEventSubscription_disappears
--- PASS: TestAccRDSEventSubscription_Name_generated (85.49s)
=== CONT  TestAccRDSEventSubscription_namePrefix
--- PASS: TestAccRDSEventSubscription_tags (110.68s)
=== CONT  TestAccRDSEventSubscription_sourceIDs
--- PASS: TestAccRDSEventSubscription_disappears (78.75s)
=== CONT  TestAccRDSEventSubscription_categories
--- PASS: TestAccRDSEventSubscription_namePrefix (81.11s)
--- PASS: TestAccRDSEventSubscription_sourceIDs (94.57s)
--- PASS: TestAccRDSEventSubscription_categories (190.35s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	365.091s
% make testacc TESTARGS='-run=TestAccRDSProxyEndpoint_' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSProxyEndpoint_ -timeout 360m
=== RUN   TestAccRDSProxyEndpoint_basic
=== PAUSE TestAccRDSProxyEndpoint_basic
=== RUN   TestAccRDSProxyEndpoint_targetRole
=== PAUSE TestAccRDSProxyEndpoint_targetRole
=== RUN   TestAccRDSProxyEndpoint_vpcSecurityGroupIDs
=== PAUSE TestAccRDSProxyEndpoint_vpcSecurityGroupIDs
=== RUN   TestAccRDSProxyEndpoint_tags
=== PAUSE TestAccRDSProxyEndpoint_tags
=== RUN   TestAccRDSProxyEndpoint_disappears
=== PAUSE TestAccRDSProxyEndpoint_disappears
=== RUN   TestAccRDSProxyEndpoint_Disappears_proxy
=== PAUSE TestAccRDSProxyEndpoint_Disappears_proxy
=== CONT  TestAccRDSProxyEndpoint_basic
=== CONT  TestAccRDSProxyEndpoint_tags
--- PASS: TestAccRDSProxyEndpoint_basic (982.02s)
=== CONT  TestAccRDSProxyEndpoint_Disappears_proxy
--- PASS: TestAccRDSProxyEndpoint_tags (997.26s)
=== CONT  TestAccRDSProxyEndpoint_vpcSecurityGroupIDs
--- PASS: TestAccRDSProxyEndpoint_Disappears_proxy (851.16s)
=== CONT  TestAccRDSProxyEndpoint_disappears
--- PASS: TestAccRDSProxyEndpoint_vpcSecurityGroupIDs (929.69s)
=== CONT  TestAccRDSProxyEndpoint_targetRole
--- PASS: TestAccRDSProxyEndpoint_disappears (1076.80s)
--- PASS: TestAccRDSProxyEndpoint_targetRole (990.13s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	2928.857s
% make testacc TESTARGS='-run=TestAccRDSProxyTarget_' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSProxyTarget_ -timeout 360m
=== RUN   TestAccRDSProxyTarget_instance
=== PAUSE TestAccRDSProxyTarget_instance
=== RUN   TestAccRDSProxyTarget_cluster
=== PAUSE TestAccRDSProxyTarget_cluster
=== RUN   TestAccRDSProxyTarget_disappears
=== PAUSE TestAccRDSProxyTarget_disappears
=== CONT  TestAccRDSProxyTarget_instance
=== CONT  TestAccRDSProxyTarget_disappears
--- PASS: TestAccRDSProxyTarget_disappears (2255.30s)
=== CONT  TestAccRDSProxyTarget_cluster
--- PASS: TestAccRDSProxyTarget_instance (2256.76s)
--- PASS: TestAccRDSProxyTarget_cluster (468.93s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	2735.418s
% make testacc TESTARGS='-run=TestAccRDSProxyDefaultTargetGroup_' PKG=rds ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 3  -run=TestAccRDSProxyDefaultTargetGroup_ -timeout 360m
=== RUN   TestAccRDSProxyDefaultTargetGroup_basic
=== PAUSE TestAccRDSProxyDefaultTargetGroup_basic
=== RUN   TestAccRDSProxyDefaultTargetGroup_emptyConnectionPool
=== PAUSE TestAccRDSProxyDefaultTargetGroup_emptyConnectionPool
=== RUN   TestAccRDSProxyDefaultTargetGroup_connectionBorrowTimeout
=== PAUSE TestAccRDSProxyDefaultTargetGroup_connectionBorrowTimeout
=== RUN   TestAccRDSProxyDefaultTargetGroup_initQuery
=== PAUSE TestAccRDSProxyDefaultTargetGroup_initQuery
=== RUN   TestAccRDSProxyDefaultTargetGroup_maxConnectionsPercent
=== PAUSE TestAccRDSProxyDefaultTargetGroup_maxConnectionsPercent
=== RUN   TestAccRDSProxyDefaultTargetGroup_maxIdleConnectionsPercent
=== PAUSE TestAccRDSProxyDefaultTargetGroup_maxIdleConnectionsPercent
=== RUN   TestAccRDSProxyDefaultTargetGroup_sessionPinningFilters
=== PAUSE TestAccRDSProxyDefaultTargetGroup_sessionPinningFilters
=== RUN   TestAccRDSProxyDefaultTargetGroup_disappears
=== PAUSE TestAccRDSProxyDefaultTargetGroup_disappears
=== CONT  TestAccRDSProxyDefaultTargetGroup_basic
=== CONT  TestAccRDSProxyDefaultTargetGroup_maxConnectionsPercent
=== CONT  TestAccRDSProxyDefaultTargetGroup_sessionPinningFilters
--- PASS: TestAccRDSProxyDefaultTargetGroup_basic (500.63s)
=== CONT  TestAccRDSProxyDefaultTargetGroup_disappears
--- PASS: TestAccRDSProxyDefaultTargetGroup_maxConnectionsPercent (557.42s)
=== CONT  TestAccRDSProxyDefaultTargetGroup_connectionBorrowTimeout
--- PASS: TestAccRDSProxyDefaultTargetGroup_sessionPinningFilters (561.56s)
=== CONT  TestAccRDSProxyDefaultTargetGroup_initQuery
--- PASS: TestAccRDSProxyDefaultTargetGroup_disappears (485.29s)
=== CONT  TestAccRDSProxyDefaultTargetGroup_emptyConnectionPool
--- PASS: TestAccRDSProxyDefaultTargetGroup_connectionBorrowTimeout (467.68s)
=== CONT  TestAccRDSProxyDefaultTargetGroup_maxIdleConnectionsPercent
--- PASS: TestAccRDSProxyDefaultTargetGroup_initQuery (467.41s)
--- PASS: TestAccRDSProxyDefaultTargetGroup_emptyConnectionPool (453.13s)
--- PASS: TestAccRDSProxyDefaultTargetGroup_maxIdleConnectionsPercent (509.57s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	1546.212s

@ewbankkit
r/aws_db_proxy: Move functions around.
11a07a4
@ewbankkit
'FindDBProxyByName' -> 'findDBProxyByName'.
ecf3237
@ewbankkit
'ResourceProxy' -> 'resourceProxy'.
2678293
@ewbankkit
r/aws_db_proxy: Rename flatteners and expanders.
faace01
@ewbankkit
rds: Generate AWS SDK for Go v2 tagging code.
b63418a
@ewbankkit
Add 'names.RDSEndpointID'.
2a7053f
@ewbankkit
r/aws_db_proxy: Migrate to AWS SDK for Go v2.
341f851
@ewbankkit
d/aws_db_proxy: Migrate to AWS SDK for Go v2.
37799eb
@ewbankkit
aws_db_proxy: Migrate acceptance tests to AWS SDK for Go v2.
82eeac5
@ewbankkit
Acceptance test output:
4bba388 
% make testacc TESTARGS='-run=TestAccRDSProxy_\|TestAccRDSProxyDataSource_' PKG=rds ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 3  -run=TestAccRDSProxy_\|TestAccRDSProxyDataSource_ -timeout 360m
=== RUN   TestAccRDSProxyDataSource_basic
=== PAUSE TestAccRDSProxyDataSource_basic
=== RUN   TestAccRDSProxy_basic
=== PAUSE TestAccRDSProxy_basic
=== RUN   TestAccRDSProxy_name
=== PAUSE TestAccRDSProxy_name
=== RUN   TestAccRDSProxy_debugLogging
=== PAUSE TestAccRDSProxy_debugLogging
=== RUN   TestAccRDSProxy_idleClientTimeout
=== PAUSE TestAccRDSProxy_idleClientTimeout
=== RUN   TestAccRDSProxy_requireTLS
=== PAUSE TestAccRDSProxy_requireTLS
=== RUN   TestAccRDSProxy_roleARN
=== PAUSE TestAccRDSProxy_roleARN
=== RUN   TestAccRDSProxy_vpcSecurityGroupIDs
=== PAUSE TestAccRDSProxy_vpcSecurityGroupIDs
=== RUN   TestAccRDSProxy_authDescription
=== PAUSE TestAccRDSProxy_authDescription
=== RUN   TestAccRDSProxy_authIAMAuth
=== PAUSE TestAccRDSProxy_authIAMAuth
=== RUN   TestAccRDSProxy_authSecretARN
=== PAUSE TestAccRDSProxy_authSecretARN
=== RUN   TestAccRDSProxy_authUsername
=== PAUSE TestAccRDSProxy_authUsername
=== RUN   TestAccRDSProxy_tags
=== PAUSE TestAccRDSProxy_tags
=== RUN   TestAccRDSProxy_disappears
=== PAUSE TestAccRDSProxy_disappears
=== CONT  TestAccRDSProxyDataSource_basic
=== CONT  TestAccRDSProxy_vpcSecurityGroupIDs
=== CONT  TestAccRDSProxy_authUsername
--- PASS: TestAccRDSProxy_authUsername (533.08s)
=== CONT  TestAccRDSProxy_disappears
--- PASS: TestAccRDSProxyDataSource_basic (563.98s)
=== CONT  TestAccRDSProxy_tags
--- PASS: TestAccRDSProxy_vpcSecurityGroupIDs (762.96s)
=== CONT  TestAccRDSProxy_idleClientTimeout
--- PASS: TestAccRDSProxy_tags (467.78s)
=== CONT  TestAccRDSProxy_roleARN
--- PASS: TestAccRDSProxy_disappears (529.28s)
=== CONT  TestAccRDSProxy_requireTLS
--- PASS: TestAccRDSProxy_idleClientTimeout (450.48s)
=== CONT  TestAccRDSProxy_authIAMAuth
--- PASS: TestAccRDSProxy_roleARN (475.23s)
=== CONT  TestAccRDSProxy_authSecretARN
--- PASS: TestAccRDSProxy_requireTLS (511.96s)
=== CONT  TestAccRDSProxy_name
--- PASS: TestAccRDSProxy_authIAMAuth (451.03s)
=== CONT  TestAccRDSProxy_debugLogging
--- PASS: TestAccRDSProxy_authSecretARN (451.04s)
=== CONT  TestAccRDSProxy_authDescription
--- PASS: TestAccRDSProxy_name (572.30s)
=== CONT  TestAccRDSProxy_basic
--- PASS: TestAccRDSProxy_debugLogging (512.14s)
--- PASS: TestAccRDSProxy_authDescription (411.80s)
--- PASS: TestAccRDSProxy_basic (451.87s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	2610.708s
@ewbankkit
r/aws_db_proxy_endpoint: Migrate to AWS SDK for Go v2.
ee8c01d
@ewbankkit
r/aws_db_proxy_endpoint: Migrate acceptance tests to AWS SDK for Go v2.
9793f8f
@ewbankkit
Acceptance test output:
95fda63 
% make testacc TESTARGS='-run=TestAccRDSProxyEndpoint_' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSProxyEndpoint_ -timeout 360m
=== RUN   TestAccRDSProxyEndpoint_basic
=== PAUSE TestAccRDSProxyEndpoint_basic
=== RUN   TestAccRDSProxyEndpoint_targetRole
=== PAUSE TestAccRDSProxyEndpoint_targetRole
=== RUN   TestAccRDSProxyEndpoint_vpcSecurityGroupIDs
=== PAUSE TestAccRDSProxyEndpoint_vpcSecurityGroupIDs
=== RUN   TestAccRDSProxyEndpoint_tags
=== PAUSE TestAccRDSProxyEndpoint_tags
=== RUN   TestAccRDSProxyEndpoint_disappears
=== PAUSE TestAccRDSProxyEndpoint_disappears
=== RUN   TestAccRDSProxyEndpoint_Disappears_proxy
=== PAUSE TestAccRDSProxyEndpoint_Disappears_proxy
=== CONT  TestAccRDSProxyEndpoint_basic
=== CONT  TestAccRDSProxyEndpoint_tags
--- PASS: TestAccRDSProxyEndpoint_basic (982.02s)
=== CONT  TestAccRDSProxyEndpoint_Disappears_proxy
--- PASS: TestAccRDSProxyEndpoint_tags (997.26s)
=== CONT  TestAccRDSProxyEndpoint_vpcSecurityGroupIDs
--- PASS: TestAccRDSProxyEndpoint_Disappears_proxy (851.16s)
=== CONT  TestAccRDSProxyEndpoint_disappears
--- PASS: TestAccRDSProxyEndpoint_vpcSecurityGroupIDs (929.69s)
=== CONT  TestAccRDSProxyEndpoint_targetRole
--- PASS: TestAccRDSProxyEndpoint_disappears (1076.80s)
--- PASS: TestAccRDSProxyEndpoint_targetRole (990.13s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	2928.857s
@ewbankkit
r/aws_db_proxy_target: Migrate to AWS SDK for Go v2.
9ab59a5
@ewbankkit
r/aws_db_proxy_target: Migrate acceptance tests to AWS SDK for Go v2.
2fa5361
@ewbankkit
Acceptance test output:
a19c38b 
% make testacc TESTARGS='-run=TestAccRDSProxyTarget_' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSProxyTarget_ -timeout 360m
=== RUN   TestAccRDSProxyTarget_instance
=== PAUSE TestAccRDSProxyTarget_instance
=== RUN   TestAccRDSProxyTarget_cluster
=== PAUSE TestAccRDSProxyTarget_cluster
=== RUN   TestAccRDSProxyTarget_disappears
=== PAUSE TestAccRDSProxyTarget_disappears
=== CONT  TestAccRDSProxyTarget_instance
=== CONT  TestAccRDSProxyTarget_disappears
--- PASS: TestAccRDSProxyTarget_disappears (2255.30s)
=== CONT  TestAccRDSProxyTarget_cluster
--- PASS: TestAccRDSProxyTarget_instance (2256.76s)
--- PASS: TestAccRDSProxyTarget_cluster (468.93s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	2735.418s
@ewbankkit
r/aws_db_proxy_default_target_group: Alphabetize attributes.
d7a56e2
@ewbankkit
r/aws_db_proxy_default_target_group: Migrate to AWS SDK for Go v2.
fcdf46b
@ewbankkit
r/aws_db_proxy_default_target_group: Migrate acceptance tests to AWS …
0c9a926 
…SDK for Go v2.
@ewbankkit
Acceptance test output:
7d2136e 
% make testacc TESTARGS='-run=TestAccRDSProxyDefaultTargetGroup_' PKG=rds ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 3  -run=TestAccRDSProxyDefaultTargetGroup_ -timeout 360m
=== RUN   TestAccRDSProxyDefaultTargetGroup_basic
=== PAUSE TestAccRDSProxyDefaultTargetGroup_basic
=== RUN   TestAccRDSProxyDefaultTargetGroup_emptyConnectionPool
=== PAUSE TestAccRDSProxyDefaultTargetGroup_emptyConnectionPool
=== RUN   TestAccRDSProxyDefaultTargetGroup_connectionBorrowTimeout
=== PAUSE TestAccRDSProxyDefaultTargetGroup_connectionBorrowTimeout
=== RUN   TestAccRDSProxyDefaultTargetGroup_initQuery
=== PAUSE TestAccRDSProxyDefaultTargetGroup_initQuery
=== RUN   TestAccRDSProxyDefaultTargetGroup_maxConnectionsPercent
=== PAUSE TestAccRDSProxyDefaultTargetGroup_maxConnectionsPercent
=== RUN   TestAccRDSProxyDefaultTargetGroup_maxIdleConnectionsPercent
=== PAUSE TestAccRDSProxyDefaultTargetGroup_maxIdleConnectionsPercent
=== RUN   TestAccRDSProxyDefaultTargetGroup_sessionPinningFilters
=== PAUSE TestAccRDSProxyDefaultTargetGroup_sessionPinningFilters
=== RUN   TestAccRDSProxyDefaultTargetGroup_disappears
=== PAUSE TestAccRDSProxyDefaultTargetGroup_disappears
=== CONT  TestAccRDSProxyDefaultTargetGroup_basic
=== CONT  TestAccRDSProxyDefaultTargetGroup_maxConnectionsPercent
=== CONT  TestAccRDSProxyDefaultTargetGroup_sessionPinningFilters
--- PASS: TestAccRDSProxyDefaultTargetGroup_basic (500.63s)
=== CONT  TestAccRDSProxyDefaultTargetGroup_disappears
--- PASS: TestAccRDSProxyDefaultTargetGroup_maxConnectionsPercent (557.42s)
=== CONT  TestAccRDSProxyDefaultTargetGroup_connectionBorrowTimeout
--- PASS: TestAccRDSProxyDefaultTargetGroup_sessionPinningFilters (561.56s)
=== CONT  TestAccRDSProxyDefaultTargetGroup_initQuery
--- PASS: TestAccRDSProxyDefaultTargetGroup_disappears (485.29s)
=== CONT  TestAccRDSProxyDefaultTargetGroup_emptyConnectionPool
--- PASS: TestAccRDSProxyDefaultTargetGroup_connectionBorrowTimeout (467.68s)
=== CONT  TestAccRDSProxyDefaultTargetGroup_maxIdleConnectionsPercent
--- PASS: TestAccRDSProxyDefaultTargetGroup_initQuery (467.41s)
--- PASS: TestAccRDSProxyDefaultTargetGroup_emptyConnectionPool (453.13s)
--- PASS: TestAccRDSProxyDefaultTargetGroup_maxIdleConnectionsPercent (509.57s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	1546.212s
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/rds Issues and PRs that pertain to the rds service. sweeper Pertains to changes to or issues with the sweeper. generators Relates to code generators. labels Feb 14, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 14, 2024
@github-actions GitHub Actions
Copy link

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

@ewbankkit ewbankkit added the bug Addresses a defect in current functionality. label Feb 14, 2024
@ewbankkit
r/aws_db_proxy: Change auth from TypeList to TypeSet as order i…
2db643f 
…s not significant.
@ewbankkit
Fix golangci-lint 'unused'.
f391060
@ewbankkit
Fix golangci-lint 'nolintlint'.
1a8bd5d
@ewbankkit
d/aws_db_proxy: Tidy up acceptance tests.
e1b8c77
@ewbankkit
r/aws_db_proxy.auth: Add custom set hash function.
221c50c
@ewbankkit
r/aws_db_proxy.auth: Fix some acceptance tests.
1315362
@ewbankkit
Add 'sdkv2.SimpleSchemaSetFunc'.
f209842
@ewbankkit
r/aws_db_subnet_group: Migrate to AWS SDK for Go v2.
8ad0df2
@ewbankkit
d/aws_db_subnet_group: Migrate to AWS SDK for Go v2.
f8e6241
@ewbankkit
r/aws_db_subnet_group: Migrate acceptance tests to AWS SDK for Go v2.
4bae096
@ewbankkit
Acceptance test output:
423bfff 
% make testacc TESTARGS='-run=TestAccRDSSubnetGroupDataSource_\|TestAccRDSSubnetGroup_' PKG=rds ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 3  -run=TestAccRDSSubnetGroupDataSource_\|TestAccRDSSubnetGroup_ -timeout 360m
=== RUN   TestAccRDSSubnetGroupDataSource_basic
=== PAUSE TestAccRDSSubnetGroupDataSource_basic
=== RUN   TestAccRDSSubnetGroup_basic
=== PAUSE TestAccRDSSubnetGroup_basic
=== RUN   TestAccRDSSubnetGroup_disappears
=== PAUSE TestAccRDSSubnetGroup_disappears
=== RUN   TestAccRDSSubnetGroup_nameGenerated
=== PAUSE TestAccRDSSubnetGroup_nameGenerated
=== RUN   TestAccRDSSubnetGroup_namePrefix
=== PAUSE TestAccRDSSubnetGroup_namePrefix
=== RUN   TestAccRDSSubnetGroup_tags
=== PAUSE TestAccRDSSubnetGroup_tags
=== RUN   TestAccRDSSubnetGroup_dualStack
=== PAUSE TestAccRDSSubnetGroup_dualStack
=== RUN   TestAccRDSSubnetGroup_updateDescription
=== PAUSE TestAccRDSSubnetGroup_updateDescription
=== RUN   TestAccRDSSubnetGroup_updateSubnets
=== PAUSE TestAccRDSSubnetGroup_updateSubnets
=== CONT  TestAccRDSSubnetGroup_tags
=== CONT  TestAccRDSSubnetGroupDataSource_basic
=== CONT  TestAccRDSSubnetGroup_updateDescription
--- PASS: TestAccRDSSubnetGroupDataSource_basic (31.84s)
=== CONT  TestAccRDSSubnetGroup_updateSubnets
--- PASS: TestAccRDSSubnetGroup_updateDescription (54.51s)
=== CONT  TestAccRDSSubnetGroup_nameGenerated
--- PASS: TestAccRDSSubnetGroup_tags (75.34s)
=== CONT  TestAccRDSSubnetGroup_namePrefix
--- PASS: TestAccRDSSubnetGroup_updateSubnets (66.59s)
=== CONT  TestAccRDSSubnetGroup_dualStack
--- PASS: TestAccRDSSubnetGroup_nameGenerated (53.69s)
=== CONT  TestAccRDSSubnetGroup_disappears
--- PASS: TestAccRDSSubnetGroup_namePrefix (87.49s)
=== CONT  TestAccRDSSubnetGroup_basic
--- PASS: TestAccRDSSubnetGroup_disappears (66.11s)
--- PASS: TestAccRDSSubnetGroup_dualStack (78.25s)
--- PASS: TestAccRDSSubnetGroup_basic (41.49s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	215.116s
@ewbankkit
Fix 'TestAccRDSProxy_authSecretARN'.
5744aaa
@ewbankkit
r/aws_db_event_subscription: Migrate to AWS SDK for Go v2.
417fe91
@ewbankkit
r/aws_db_event_subscription: Migrate acceptance tests to AWS SDK for …
39b7f58 
…Go v2.
@ewbankkit
Acceptance test output:
b69e7ee 
% make testacc TESTARGS='-run=TestAccRDSEventSubscription_' PKG=rds ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 3  -run=TestAccRDSEventSubscription_ -timeout 360m
=== RUN   TestAccRDSEventSubscription_basic
=== PAUSE TestAccRDSEventSubscription_basic
=== RUN   TestAccRDSEventSubscription_disappears
=== PAUSE TestAccRDSEventSubscription_disappears
=== RUN   TestAccRDSEventSubscription_Name_generated
=== PAUSE TestAccRDSEventSubscription_Name_generated
=== RUN   TestAccRDSEventSubscription_namePrefix
=== PAUSE TestAccRDSEventSubscription_namePrefix
=== RUN   TestAccRDSEventSubscription_tags
=== PAUSE TestAccRDSEventSubscription_tags
=== RUN   TestAccRDSEventSubscription_categories
=== PAUSE TestAccRDSEventSubscription_categories
=== RUN   TestAccRDSEventSubscription_sourceIDs
=== PAUSE TestAccRDSEventSubscription_sourceIDs
=== CONT  TestAccRDSEventSubscription_basic
=== CONT  TestAccRDSEventSubscription_tags
=== CONT  TestAccRDSEventSubscription_Name_generated
--- PASS: TestAccRDSEventSubscription_basic (85.48s)
=== CONT  TestAccRDSEventSubscription_disappears
--- PASS: TestAccRDSEventSubscription_Name_generated (85.49s)
=== CONT  TestAccRDSEventSubscription_namePrefix
--- PASS: TestAccRDSEventSubscription_tags (110.68s)
=== CONT  TestAccRDSEventSubscription_sourceIDs
--- PASS: TestAccRDSEventSubscription_disappears (78.75s)
=== CONT  TestAccRDSEventSubscription_categories
--- PASS: TestAccRDSEventSubscription_namePrefix (81.11s)
--- PASS: TestAccRDSEventSubscription_sourceIDs (94.57s)
--- PASS: TestAccRDSEventSubscription_categories (190.35s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	365.091s
@ewbankkit
'internal/sdktypes' -> 'internal/sdkv2/types'.
6836c5c
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/acm Issues and PRs that pertain to the acm service. service/elasticbeanstalk Issues and PRs that pertain to the elasticbeanstalk service. labels Feb 15, 2024
@ewbankkit ewbankkit changed the title [WIP] r/aws_db_proxy: Change auth from TypeList to TypeSet r/aws_db_proxy: Change auth from TypeList to TypeSet Feb 15, 2024
@ewbankkit ewbankkit merged commit 3ade388 into main Feb 15, 2024
39 checks passed
@ewbankkit ewbankkit deleted the b-aws_db_proxy.auth-TypeSet branch February 15, 2024 17:12
@github-actions github-actions bot added this to the v5.37.0 milestone Feb 15, 2024
github-actions bot pushed a commit that referenced this pull request Feb 15, 2024
Update CHANGELOG.md for #35819
6e6034a
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.37.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 15, 2024
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/acm Issues and PRs that pertain to the acm service. service/elasticbeanstalk Issues and PRs that pertain to the elasticbeanstalk service. service/rds Issues and PRs that pertain to the rds service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.37.0
1 participant
@ewbankkit