Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_bedrock_provisioned_model_throughput: New resource #35689

Merged
merged 30 commits into from
Feb 14, 2024

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Feb 7, 2024

Description

Adds the aws_bedrock_provisioned_model_throughput resource.

Relations

Closes #33809.
Closes #34664.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccBedrock_serial/ModelInvocationLoggingConfiguration' PKG=bedrock
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/bedrock/... -v -count 1 -parallel 20  -run=TestAccBedrock_serial/ModelInvocationLoggingConfiguration -timeout 360m
=== RUN   TestAccBedrock_serial
=== PAUSE TestAccBedrock_serial
=== CONT  TestAccBedrock_serial
=== RUN   TestAccBedrock_serial/ModelInvocationLoggingConfiguration
=== RUN   TestAccBedrock_serial/ModelInvocationLoggingConfiguration/basic
=== RUN   TestAccBedrock_serial/ModelInvocationLoggingConfiguration/disappears
--- PASS: TestAccBedrock_serial (62.43s)
    --- PASS: TestAccBedrock_serial/ModelInvocationLoggingConfiguration (62.43s)
        --- PASS: TestAccBedrock_serial/ModelInvocationLoggingConfiguration/basic (30.58s)
        --- PASS: TestAccBedrock_serial/ModelInvocationLoggingConfiguration/disappears (31.85s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/bedrock	73.407s
% make testacc TESTARGS='-run=TestAccBedrockProvisionedModelThroughput_' PKG=bedrock
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/bedrock/... -v -count 1 -parallel 20  -run=TestAccBedrockProvisionedModelThroughput_ -timeout 360m
=== RUN   TestAccBedrockProvisionedModelThroughput_basic
    acctest.go:94: Bedrock Provisioned Model Throughput has a minimum 1 month commitment and costs > $10K/month
--- SKIP: TestAccBedrockProvisionedModelThroughput_basic (0.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/bedrock	10.465s
% make testacc TESTARGS='-run=TestAccLexV2ModelsIntent_' PKG=lexv2models ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lexv2models/... -v -count 1 -parallel 2  -run=TestAccLexV2ModelsIntent_ -timeout 360m
=== RUN   TestAccLexV2ModelsIntent_basic
=== PAUSE TestAccLexV2ModelsIntent_basic
=== RUN   TestAccLexV2ModelsIntent_disappears
=== PAUSE TestAccLexV2ModelsIntent_disappears
=== RUN   TestAccLexV2ModelsIntent_updateConfirmationSetting
=== PAUSE TestAccLexV2ModelsIntent_updateConfirmationSetting
=== RUN   TestAccLexV2ModelsIntent_updateClosingSetting
=== PAUSE TestAccLexV2ModelsIntent_updateClosingSetting
=== RUN   TestAccLexV2ModelsIntent_updateInputContext
=== PAUSE TestAccLexV2ModelsIntent_updateInputContext
=== RUN   TestAccLexV2ModelsIntent_updateInitialResponseSetting
=== PAUSE TestAccLexV2ModelsIntent_updateInitialResponseSetting
=== RUN   TestAccLexV2ModelsIntent_updateFulfillmentCodeHook
=== PAUSE TestAccLexV2ModelsIntent_updateFulfillmentCodeHook
=== RUN   TestAccLexV2ModelsIntent_updateDialogCodeHook
=== PAUSE TestAccLexV2ModelsIntent_updateDialogCodeHook
=== RUN   TestAccLexV2ModelsIntent_updateOutputContext
=== PAUSE TestAccLexV2ModelsIntent_updateOutputContext
=== RUN   TestAccLexV2ModelsIntent_updateSampleUtterance
=== PAUSE TestAccLexV2ModelsIntent_updateSampleUtterance
=== CONT  TestAccLexV2ModelsIntent_basic
=== CONT  TestAccLexV2ModelsIntent_updateInitialResponseSetting
--- PASS: TestAccLexV2ModelsIntent_basic (48.10s)
=== CONT  TestAccLexV2ModelsIntent_updateClosingSetting
--- PASS: TestAccLexV2ModelsIntent_updateInitialResponseSetting (66.78s)
=== CONT  TestAccLexV2ModelsIntent_updateInputContext
--- PASS: TestAccLexV2ModelsIntent_updateClosingSetting (63.77s)
=== CONT  TestAccLexV2ModelsIntent_updateOutputContext
--- PASS: TestAccLexV2ModelsIntent_updateInputContext (67.45s)
=== CONT  TestAccLexV2ModelsIntent_updateSampleUtterance
--- PASS: TestAccLexV2ModelsIntent_updateOutputContext (61.04s)
=== CONT  TestAccLexV2ModelsIntent_updateDialogCodeHook
--- PASS: TestAccLexV2ModelsIntent_updateSampleUtterance (62.89s)
=== CONT  TestAccLexV2ModelsIntent_updateConfirmationSetting
--- PASS: TestAccLexV2ModelsIntent_updateDialogCodeHook (65.59s)
=== CONT  TestAccLexV2ModelsIntent_disappears
--- PASS: TestAccLexV2ModelsIntent_updateConfirmationSetting (62.64s)
=== CONT  TestAccLexV2ModelsIntent_updateFulfillmentCodeHook
--- PASS: TestAccLexV2ModelsIntent_disappears (44.37s)
--- PASS: TestAccLexV2ModelsIntent_updateFulfillmentCodeHook (63.24s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lexv2models	334.567s
% make testacc TESTARGS='-run=TestAccAppSync_serial/Resolver/disappears\|TestAccAppSync_serial/DataSource/Type_rdbms' PKG=appsync
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appsync/... -v -count 1 -parallel 20  -run=TestAccAppSync_serial/Resolver/disappears\|TestAccAppSync_serial/DataSource/Type_rdbms -timeout 360m
=== RUN   TestAccAppSync_serial
=== PAUSE TestAccAppSync_serial
=== CONT  TestAccAppSync_serial
=== RUN   TestAccAppSync_serial/Resolver
=== RUN   TestAccAppSync_serial/Resolver/disappears
=== RUN   TestAccAppSync_serial/DataSource
=== RUN   TestAccAppSync_serial/DataSource/Type_rdbms
=== RUN   TestAccAppSync_serial/DataSource/Type_rdbms_options
--- PASS: TestAccAppSync_serial (626.95s)
    --- PASS: TestAccAppSync_serial/Resolver (33.77s)
        --- PASS: TestAccAppSync_serial/Resolver/disappears (33.77s)
    --- PASS: TestAccAppSync_serial/DataSource (593.18s)
        --- PASS: TestAccAppSync_serial/DataSource/Type_rdbms (283.98s)
        --- PASS: TestAccAppSync_serial/DataSource/Type_rdbms_options (309.20s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appsync	647.401s

…d' from attributes iniside optional SingleNestedBlock.
% make testacc TESTARGS='-run=TestAccBedrock_serial/ModelInvocationLoggingConfiguration' PKG=bedrock
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/bedrock/... -v -count 1 -parallel 20  -run=TestAccBedrock_serial/ModelInvocationLoggingConfiguration -timeout 360m
=== RUN   TestAccBedrock_serial
=== PAUSE TestAccBedrock_serial
=== CONT  TestAccBedrock_serial
=== RUN   TestAccBedrock_serial/ModelInvocationLoggingConfiguration
=== RUN   TestAccBedrock_serial/ModelInvocationLoggingConfiguration/basic
=== RUN   TestAccBedrock_serial/ModelInvocationLoggingConfiguration/disappears
--- PASS: TestAccBedrock_serial (62.43s)
    --- PASS: TestAccBedrock_serial/ModelInvocationLoggingConfiguration (62.43s)
        --- PASS: TestAccBedrock_serial/ModelInvocationLoggingConfiguration/basic (30.58s)
        --- PASS: TestAccBedrock_serial/ModelInvocationLoggingConfiguration/disappears (31.85s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/bedrock	73.407s
Copy link

github-actions bot commented Feb 7, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/bedrock Issues and PRs that pertain to the bedrock service. labels Feb 7, 2024
Copy link

github-actions bot commented Feb 7, 2024

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 7, 2024
@ewbankkit ewbankkit mentioned this pull request Feb 7, 2024
7 tasks
@ewbankkit
Copy link
Contributor Author

Waiting for quota increase request to be fulfilled before I can test.

@ewbankkit ewbankkit added the new-resource Introduces a new resource. label Feb 14, 2024
@ewbankkit ewbankkit changed the title [WIP] r/aws_bedrock_provisioned_model_throughput: New resource r/aws_bedrock_provisioned_model_throughput: New resource Feb 14, 2024
@github-actions github-actions bot added the service/appsync Issues and PRs that pertain to the appsync service. label Feb 14, 2024
@ewbankkit ewbankkit merged commit bf43506 into main Feb 14, 2024
53 checks passed
@ewbankkit ewbankkit deleted the f-r/aws_bedrock_provisioned_model_throughput branch February 14, 2024 19:19
@github-actions github-actions bot added this to the v5.37.0 milestone Feb 14, 2024
github-actions bot pushed a commit that referenced this pull request Feb 14, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 15, 2024
Copy link

This functionality has been released in v5.37.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. service/appsync Issues and PRs that pertain to the appsync service. service/bedrock Issues and PRs that pertain to the bedrock service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: AutoFlEx Support for SingleNestedObjects [New Service]: Amazon Bedrock
1 participant