Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_lakeformation_resource: add hybrid_access_enabled argument #35571

Merged

Conversation

prithvi514
Copy link
Contributor

@prithvi514 prithvi514 commented Jan 30, 2024

Description

This argument will allow users to configure the value of HybridAccessEnabled parameter boolean in the underlying AWS RegisterResource API. Users can then register S3 data location in Hybrid access mode.

Relations

Closes #35548

References

https://docs.aws.amazon.com/lake-formation/latest/APIReference/API_RegisterResource.html

Output from Acceptance Testing

% make testacc PKG=lakeformation TESTS=TestAccLakeFormationResource_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lakeformation/... -v -count 1 -parallel 20 -run='TestAccLakeFormationResource_'  -timeout 360m
=== RUN   TestAccLakeFormationResource_basic
=== PAUSE TestAccLakeFormationResource_basic
=== RUN   TestAccLakeFormationResource_disappears
=== PAUSE TestAccLakeFormationResource_disappears
=== RUN   TestAccLakeFormationResource_serviceLinkedRole
=== PAUSE TestAccLakeFormationResource_serviceLinkedRole
=== RUN   TestAccLakeFormationResource_updateRoleToRole
=== PAUSE TestAccLakeFormationResource_updateRoleToRole
=== RUN   TestAccLakeFormationResource_updateSLRToRole
=== PAUSE TestAccLakeFormationResource_updateSLRToRole
=== RUN   TestAccLakeFormationResource_hybridAccessEnabled
=== PAUSE TestAccLakeFormationResource_hybridAccessEnabled
=== CONT  TestAccLakeFormationResource_basic
=== CONT  TestAccLakeFormationResource_updateRoleToRole
=== CONT  TestAccLakeFormationResource_serviceLinkedRole
=== CONT  TestAccLakeFormationResource_disappears
=== CONT  TestAccLakeFormationResource_updateSLRToRole
=== CONT  TestAccLakeFormationResource_hybridAccessEnabled
--- PASS: TestAccLakeFormationResource_basic (31.81s)
--- PASS: TestAccLakeFormationResource_hybridAccessEnabled (32.86s)
--- PASS: TestAccLakeFormationResource_serviceLinkedRole (33.00s)
--- PASS: TestAccLakeFormationResource_disappears (33.28s)
--- PASS: TestAccLakeFormationResource_updateRoleToRole (49.31s)
--- PASS: TestAccLakeFormationResource_updateSLRToRole (50.01s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lakeformation	58.692s


...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/lakeformation Issues and PRs that pertain to the lakeformation service. labels Jan 30, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 30, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @prithvi514 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 1, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccLakeFormationResource_' PKG=lakeformation ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lakeformation/... -v -count 1 -parallel 2  -run=TestAccLakeFormationResource_ -timeout 360m
=== RUN   TestAccLakeFormationResource_basic
=== PAUSE TestAccLakeFormationResource_basic
=== RUN   TestAccLakeFormationResource_disappears
=== PAUSE TestAccLakeFormationResource_disappears
=== RUN   TestAccLakeFormationResource_serviceLinkedRole
=== PAUSE TestAccLakeFormationResource_serviceLinkedRole
=== RUN   TestAccLakeFormationResource_updateRoleToRole
=== PAUSE TestAccLakeFormationResource_updateRoleToRole
=== RUN   TestAccLakeFormationResource_updateSLRToRole
=== PAUSE TestAccLakeFormationResource_updateSLRToRole
=== RUN   TestAccLakeFormationResource_hybridAccessEnabled
=== PAUSE TestAccLakeFormationResource_hybridAccessEnabled
=== CONT  TestAccLakeFormationResource_basic
=== CONT  TestAccLakeFormationResource_updateRoleToRole
--- PASS: TestAccLakeFormationResource_basic (24.45s)
=== CONT  TestAccLakeFormationResource_hybridAccessEnabled
--- PASS: TestAccLakeFormationResource_updateRoleToRole (41.10s)
=== CONT  TestAccLakeFormationResource_updateSLRToRole
--- PASS: TestAccLakeFormationResource_hybridAccessEnabled (22.61s)
=== CONT  TestAccLakeFormationResource_serviceLinkedRole
--- PASS: TestAccLakeFormationResource_serviceLinkedRole (21.66s)
=== CONT  TestAccLakeFormationResource_disappears
--- PASS: TestAccLakeFormationResource_updateSLRToRole (40.24s)
--- PASS: TestAccLakeFormationResource_disappears (22.54s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lakeformation	102.310s

@ewbankkit ewbankkit merged commit 191165a into hashicorp:main Feb 1, 2024
43 checks passed
@github-actions github-actions bot added this to the v5.35.0 milestone Feb 1, 2024
Copy link

github-actions bot commented Feb 2, 2024

This functionality has been released in v5.35.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Mar 4, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/lakeformation Issues and PRs that pertain to the lakeformation service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: aws_lakeformation_resource to register an S3 location in Hybrid mode
2 participants