-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Resource]: aws_rds_certificate #35003
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Use AWS Go SDK V2 pointer conversion for dereferencing
AWS Go SDK pointer conversion function for d.Set() value is extraneous
All AWS API calls should use the WithContext version
AWS Go SDK pointer conversion function for d.Set() value is extraneous
Fix tfproviderdocs action
6db848b
to
dc2d73f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccRDSCertificate_serial' PKG=rds
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/rds/... -v -count 1 -parallel 20 -run=TestAccRDSCertificate_serial -timeout 360m
=== RUN TestAccRDSCertificate_serial
=== PAUSE TestAccRDSCertificate_serial
=== CONT TestAccRDSCertificate_serial
=== RUN TestAccRDSCertificate_serial/basic
=== RUN TestAccRDSCertificate_serial/disappears
--- PASS: TestAccRDSCertificate_serial (26.48s)
--- PASS: TestAccRDSCertificate_serial/basic (17.61s)
--- PASS: TestAccRDSCertificate_serial/disappears (8.86s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/rds 31.485s
@obounaim Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Provides a resource to override the system-default Secure Sockets Layer/Transport Layer Security (SSL/TLS) certificate for Amazon RDS for new DB instances in the current AWS region.
Relations
Closes #33196
References
AWS RDS CA
Output from Acceptance Testing