Amazon FXx ONTAP File System HA Pair update

[awsaxeman]

Description

This update adds the ability to use the new scale out features of FSx for ONTAP. Adding the ability to specify multiple HA pairs and throughput per HA pair. Also updates the limits for IOPS to the new limit.

Relations

Closes #34953

References

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccFSxONTAPFileSystem_haPair' PKG_NAME=internal/service/fsx ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fsx/... -v -count 1 -parallel 1  -run=TestAccFSxONTAPFileSystem_haPair -timeout 360m
=== RUN   TestAccFSxONTAPFileSystem_haPair
=== PAUSE TestAccFSxONTAPFileSystem_haPair
=== CONT  TestAccFSxONTAPFileSystem_haPair
--- PASS: TestAccFSxONTAPFileSystem_haPair (1804.69s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/fsx        1815.896s

%  make testacc TESTARGS='-run=TestAccFSxONTAPFileSystemDataSource_haPair' PKG_NAME=internal/service/fsx ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fsx/... -v -count 1 -parallel 1  -run=TestAccFSxONTAPFileSystemDataSource_haPair -timeout 360m
=== RUN   TestAccFSxONTAPFileSystemDataSource_haPair
=== PAUSE TestAccFSxONTAPFileSystemDataSource_haPair
=== CONT  TestAccFSxONTAPFileSystemDataSource_haPair
--- PASS: TestAccFSxONTAPFileSystemDataSource_haPair (1898.70s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/fsx        1906.625s

...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccFSxONTAPFileSystemDataSource_Id\|TestAccFSxONTAPFileSystem_basic\|TestAccFSxONTAPFileSystem_singleAZ\|TestAccFSxONTAPFileSystem_haPair\|TestAccFSxONTAPFileSystem_throughputCapacity' PKG=fsx ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fsx/... -v -count 1 -parallel 2  -run=TestAccFSxONTAPFileSystemDataSource_Id\|TestAccFSxONTAPFileSystem_basic\|TestAccFSxONTAPFileSystem_singleAZ\|TestAccFSxONTAPFileSystem_haPair\|TestAccFSxONTAPFileSystem_throughputCapacity -timeout 720m
=== RUN   TestAccFSxONTAPFileSystemDataSource_Id
=== PAUSE TestAccFSxONTAPFileSystemDataSource_Id
=== RUN   TestAccFSxONTAPFileSystem_basic
=== PAUSE TestAccFSxONTAPFileSystem_basic
=== RUN   TestAccFSxONTAPFileSystem_singleAZ
=== PAUSE TestAccFSxONTAPFileSystem_singleAZ
=== RUN   TestAccFSxONTAPFileSystem_haPair
=== PAUSE TestAccFSxONTAPFileSystem_haPair
=== RUN   TestAccFSxONTAPFileSystem_throughputCapacity
=== PAUSE TestAccFSxONTAPFileSystem_throughputCapacity
=== CONT  TestAccFSxONTAPFileSystemDataSource_Id
=== CONT  TestAccFSxONTAPFileSystem_haPair
--- PASS: TestAccFSxONTAPFileSystemDataSource_Id (2179.81s)
--- PASS: TestAccFSxONTAPFileSystem_haPair (1917.37s)
=== CONT  TestAccFSxONTAPFileSystem_throughputCapacity
--- FAIL: TestAccFSxONTAPFileSystemDataSource_Id (2151.98s)
=== CONT  TestAccFSxONTAPFileSystem_singleAZ
--- PASS: TestAccFSxONTAPFileSystem_singleAZ (2165.70s)
=== CONT  TestAccFSxONTAPFileSystem_basic
--- PASS: TestAccFSxONTAPFileSystem_throughputCapacity (3798.55s)
--- PASS: TestAccFSxONTAPFileSystem_basic (2213.81s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fsx	6537.425s

[ewbankkit]

@awsaxeman Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.