Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding pagination support for RAM GetResourceShareAssociation #34738

Merged
merged 6 commits into from
Jan 11, 2024

Conversation

AliAllomani
Copy link
Contributor

@AliAllomani AliAllomani commented Dec 5, 2023

Description

Adding pagination support for aws_ram_principal_association to fix reading RAM Resource Share (YYY) Principal Association (XXXX): couldn't find resource (21 retries) errors when a high number of principals are associated with a resource share.

Relations

Closes #33985

References

Output from Acceptance Testing

% make testacc TESTS=TestAccRAMPrincipalAssociation_basic PKG=ram

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ram/... -v -count 1 -parallel 20 -run='TestAccRAMPrincipalAssociation_basic'  -timeout 360m
=== RUN   TestAccRAMPrincipalAssociation_basic
=== PAUSE TestAccRAMPrincipalAssociation_basic
=== CONT  TestAccRAMPrincipalAssociation_basic
--- PASS: TestAccRAMPrincipalAssociation_basic (43.81s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ram        224.356s
...

Copy link

github-actions bot commented Dec 5, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/ram Issues and PRs that pertain to the ram service. labels Dec 5, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 5, 2023
@AliAllomani AliAllomani marked this pull request as draft December 5, 2023 14:11
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 6, 2023
@AliAllomani AliAllomani marked this pull request as ready for review December 6, 2023 22:42
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRAMPrincipalAssociation_' PKG=ram
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ram/... -v -count 1 -parallel 20  -run=TestAccRAMPrincipalAssociation_ -timeout 360m
=== RUN   TestAccRAMPrincipalAssociation_basic
=== PAUSE TestAccRAMPrincipalAssociation_basic
=== RUN   TestAccRAMPrincipalAssociation_disappears
=== PAUSE TestAccRAMPrincipalAssociation_disappears
=== CONT  TestAccRAMPrincipalAssociation_basic
=== CONT  TestAccRAMPrincipalAssociation_disappears
--- PASS: TestAccRAMPrincipalAssociation_disappears (26.42s)
--- PASS: TestAccRAMPrincipalAssociation_basic (28.96s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ram	35.350s

@ewbankkit
Copy link
Contributor

@AliAllomani Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 11ec582 into hashicorp:main Jan 11, 2024
33 checks passed
@github-actions github-actions bot added this to the v5.32.0 milestone Jan 11, 2024
Copy link

This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/ram Issues and PRs that pertain to the ram service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: reading RAM Resource Share (YYY) Principal Association (XXXX): couldn't find resource (21 retries)
3 participants