-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding pagination support for RAM GetResourceShareAssociation #34738
Adding pagination support for RAM GetResourceShareAssociation #34738
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccRAMPrincipalAssociation_' PKG=ram
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ram/... -v -count 1 -parallel 20 -run=TestAccRAMPrincipalAssociation_ -timeout 360m
=== RUN TestAccRAMPrincipalAssociation_basic
=== PAUSE TestAccRAMPrincipalAssociation_basic
=== RUN TestAccRAMPrincipalAssociation_disappears
=== PAUSE TestAccRAMPrincipalAssociation_disappears
=== CONT TestAccRAMPrincipalAssociation_basic
=== CONT TestAccRAMPrincipalAssociation_disappears
--- PASS: TestAccRAMPrincipalAssociation_disappears (26.42s)
--- PASS: TestAccRAMPrincipalAssociation_basic (28.96s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ram 35.350s
@AliAllomani Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Adding pagination support for
aws_ram_principal_association
to fixreading RAM Resource Share (YYY) Principal Association (XXXX): couldn't find resource (21 retries)
errors when a high number of principals are associated with a resource share.Relations
Closes #33985
References
Output from Acceptance Testing