Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/backup_vault_policy: add iam retry for eventual consistency #34671

Merged
merged 4 commits into from
Dec 4, 2023

Conversation

nam054
Copy link
Contributor

@nam054 nam054 commented Nov 30, 2023

Description

Add iam retry for eventual consistency.

Relations

Closes #33173

References

Output from Acceptance Testing

> make testacc TESTS=TestAccBackupVaultPolicy_eventual_consistency PKG=backup
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/backup/... -v -count 1 -parallel 20 -run='TestAccBackupVaultPolicy_eventual_consistency'  -timeout 360m
=== RUN   TestAccBackupVaultPolicy_eventual_consistency
=== PAUSE TestAccBackupVaultPolicy_eventual_consistency
=== CONT  TestAccBackupVaultPolicy_eventual_consistency
--- PASS: TestAccBackupVaultPolicy_eventual_consistency (28.91s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/backup     32.108s

...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/backup Issues and PRs that pertain to the backup service. labels Nov 30, 2023
Copy link

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Nov 30, 2023
@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed size/XS Managed by automation to categorize the size of a PR. labels Dec 1, 2023
@nam054 nam054 force-pushed the b-vault-backup-iam branch from d297c2e to 0b1b4c6 Compare December 1, 2023 02:46
@johnsonaj johnsonaj changed the title add iam retry r/backup_vault_policy: add iam retry for eventual consistency Dec 4, 2023
@nam054 nam054 marked this pull request as ready for review December 4, 2023 17:13
@johnsonaj johnsonaj self-assigned this Dec 4, 2023
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

% make testacc TESTS=TestAccBackupVaultPolicy_eventualConsistency PKG=backup
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/backup/... -v -count 1 -parallel 20 -run='TestAccBackupVaultPolicy_eventualConsistency'  -timeout 360m
=== RUN   TestAccBackupVaultPolicy_eventualConsistency
=== PAUSE TestAccBackupVaultPolicy_eventualConsistency
=== CONT  TestAccBackupVaultPolicy_eventualConsistency
--- PASS: TestAccBackupVaultPolicy_eventualConsistency (71.10s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/backup	74.307s

@johnsonaj johnsonaj added the bug Addresses a defect in current functionality. label Dec 4, 2023
@johnsonaj johnsonaj merged commit 5b99325 into main Dec 4, 2023
55 checks passed
@johnsonaj johnsonaj deleted the b-vault-backup-iam branch December 4, 2023 18:58
@github-actions github-actions bot added this to the v5.30.0 milestone Dec 4, 2023
@github-actions github-actions bot removed the bug Addresses a defect in current functionality. label Dec 7, 2023
Copy link

github-actions bot commented Dec 7, 2023

This functionality has been released in v5.30.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Jan 7, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2024
@justinretzolk justinretzolk added the bug Addresses a defect in current functionality. label Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/backup Issues and PRs that pertain to the backup service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: InvalidParameterValueException on newly created IAM role with Backup Access Policy
3 participants