Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DocDB & Neptune sweepers #34637

Merged
merged 46 commits into from
Nov 29, 2023
Merged

DocDB & Neptune sweepers #34637

merged 46 commits into from
Nov 29, 2023

Conversation

ewbankkit
Copy link
Contributor

Description

Makes DocDB & Neptune sweepers consistent (and as close to RDS sweepers as possible).

Relations

Closes #34618.
Closes #34500.
Closes #34499.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccDocDBEventSubscription_' PKG=docdb ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/docdb/... -v -count 1 -parallel 3  -run=TestAccDocDBEventSubscription_ -timeout 360m
=== RUN   TestAccDocDBEventSubscription_basic
=== PAUSE TestAccDocDBEventSubscription_basic
=== RUN   TestAccDocDBEventSubscription_nameGenerated
=== PAUSE TestAccDocDBEventSubscription_nameGenerated
=== RUN   TestAccDocDBEventSubscription_disappears
=== PAUSE TestAccDocDBEventSubscription_disappears
=== RUN   TestAccDocDBEventSubscription_enabled
=== PAUSE TestAccDocDBEventSubscription_enabled
=== RUN   TestAccDocDBEventSubscription_eventCategories
=== PAUSE TestAccDocDBEventSubscription_eventCategories
=== RUN   TestAccDocDBEventSubscription_tags
=== PAUSE TestAccDocDBEventSubscription_tags
=== CONT  TestAccDocDBEventSubscription_basic
=== CONT  TestAccDocDBEventSubscription_enabled
=== CONT  TestAccDocDBEventSubscription_tags
--- PASS: TestAccDocDBEventSubscription_basic (245.55s)
=== CONT  TestAccDocDBEventSubscription_eventCategories
--- PASS: TestAccDocDBEventSubscription_tags (268.38s)
=== CONT  TestAccDocDBEventSubscription_nameGenerated
--- PASS: TestAccDocDBEventSubscription_enabled (329.43s)
=== CONT  TestAccDocDBEventSubscription_disappears
--- PASS: TestAccDocDBEventSubscription_nameGenerated (220.42s)
--- PASS: TestAccDocDBEventSubscription_eventCategories (291.71s)
--- PASS: TestAccDocDBEventSubscription_disappears (229.65s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/docdb	564.688s
% make testacc TESTARGS='-run=TestAccNeptuneClusterSnapshot_' PKG=neptune ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/neptune/... -v -count 1 -parallel 3  -run=TestAccNeptuneClusterSnapshot_ -timeout 360m
=== RUN   TestAccNeptuneClusterSnapshot_basic
=== PAUSE TestAccNeptuneClusterSnapshot_basic
=== RUN   TestAccNeptuneClusterSnapshot_disappears
=== PAUSE TestAccNeptuneClusterSnapshot_disappears
=== CONT  TestAccNeptuneClusterSnapshot_basic
=== CONT  TestAccNeptuneClusterSnapshot_disappears
--- PASS: TestAccNeptuneClusterSnapshot_basic (287.73s)
--- PASS: TestAccNeptuneClusterSnapshot_disappears (301.90s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/neptune	307.707s
% make testacc TESTARGS='-run=TestAccDocDBClusterSnapshot_' PKG=docdb ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/docdb/... -v -count 1 -parallel 3  -run=TestAccDocDBClusterSnapshot_ -timeout 360m
=== RUN   TestAccDocDBClusterSnapshot_basic
=== PAUSE TestAccDocDBClusterSnapshot_basic
=== CONT  TestAccDocDBClusterSnapshot_basic
--- PASS: TestAccDocDBClusterSnapshot_basic (212.46s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/docdb	218.092s
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccDocDBGlobalCluster_\|TestAccDocDBCluster_' PKG=docdb ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/docdb/... -v -count 1 -parallel 2  -run=TestAccDocDBGlobalCluster_\|TestAccDocDBCluster_ -timeout 720m
=== RUN   TestAccDocDBCluster_basic
=== PAUSE TestAccDocDBCluster_basic
=== RUN   TestAccDocDBCluster_disappears
=== PAUSE TestAccDocDBCluster_disappears
=== RUN   TestAccDocDBCluster_identifierGenerated
=== PAUSE TestAccDocDBCluster_identifierGenerated
=== RUN   TestAccDocDBCluster_identifierPrefix
=== PAUSE TestAccDocDBCluster_identifierPrefix
=== RUN   TestAccDocDBCluster_tags
=== PAUSE TestAccDocDBCluster_tags
=== RUN   TestAccDocDBCluster_takeFinalSnapshot
=== PAUSE TestAccDocDBCluster_takeFinalSnapshot
=== RUN   TestAccDocDBCluster_missingUserNameCausesError
=== PAUSE TestAccDocDBCluster_missingUserNameCausesError
=== RUN   TestAccDocDBCluster_updateCloudWatchLogsExports
=== PAUSE TestAccDocDBCluster_updateCloudWatchLogsExports
=== RUN   TestAccDocDBCluster_kmsKey
=== PAUSE TestAccDocDBCluster_kmsKey
=== RUN   TestAccDocDBCluster_encrypted
=== PAUSE TestAccDocDBCluster_encrypted
=== RUN   TestAccDocDBCluster_backupsUpdate
=== PAUSE TestAccDocDBCluster_backupsUpdate
=== RUN   TestAccDocDBCluster_port
=== PAUSE TestAccDocDBCluster_port
=== RUN   TestAccDocDBCluster_deleteProtection
=== PAUSE TestAccDocDBCluster_deleteProtection
=== RUN   TestAccDocDBCluster_GlobalClusterIdentifier
=== PAUSE TestAccDocDBCluster_GlobalClusterIdentifier
=== RUN   TestAccDocDBCluster_GlobalClusterIdentifier_Add
=== PAUSE TestAccDocDBCluster_GlobalClusterIdentifier_Add
=== RUN   TestAccDocDBCluster_GlobalClusterIdentifier_Remove
=== PAUSE TestAccDocDBCluster_GlobalClusterIdentifier_Remove
=== RUN   TestAccDocDBCluster_GlobalClusterIdentifier_Update
=== PAUSE TestAccDocDBCluster_GlobalClusterIdentifier_Update
=== RUN   TestAccDocDBCluster_GlobalClusterIdentifier_PrimarySecondaryClusters
=== PAUSE TestAccDocDBCluster_GlobalClusterIdentifier_PrimarySecondaryClusters
=== RUN   TestAccDocDBCluster_updateEngineMajorVersion
=== PAUSE TestAccDocDBCluster_updateEngineMajorVersion
=== RUN   TestAccDocDBGlobalCluster_basic
=== PAUSE TestAccDocDBGlobalCluster_basic
=== RUN   TestAccDocDBGlobalCluster_disappears
=== PAUSE TestAccDocDBGlobalCluster_disappears
=== RUN   TestAccDocDBGlobalCluster_DatabaseName
=== PAUSE TestAccDocDBGlobalCluster_DatabaseName
=== RUN   TestAccDocDBGlobalCluster_DeletionProtection
=== PAUSE TestAccDocDBGlobalCluster_DeletionProtection
=== RUN   TestAccDocDBGlobalCluster_Engine
=== PAUSE TestAccDocDBGlobalCluster_Engine
=== RUN   TestAccDocDBGlobalCluster_EngineVersion
=== PAUSE TestAccDocDBGlobalCluster_EngineVersion
=== RUN   TestAccDocDBGlobalCluster_SourceDBClusterIdentifier_basic
=== PAUSE TestAccDocDBGlobalCluster_SourceDBClusterIdentifier_basic
=== RUN   TestAccDocDBGlobalCluster_SourceDBClusterIdentifier_storageEncrypted
=== PAUSE TestAccDocDBGlobalCluster_SourceDBClusterIdentifier_storageEncrypted
=== RUN   TestAccDocDBGlobalCluster_StorageEncrypted
=== PAUSE TestAccDocDBGlobalCluster_StorageEncrypted
=== CONT  TestAccDocDBCluster_basic
=== CONT  TestAccDocDBCluster_GlobalClusterIdentifier_Add
--- PASS: TestAccDocDBCluster_basic (168.43s)
=== CONT  TestAccDocDBGlobalCluster_DatabaseName
--- PASS: TestAccDocDBCluster_GlobalClusterIdentifier_Add (197.89s)
=== CONT  TestAccDocDBGlobalCluster_StorageEncrypted
--- PASS: TestAccDocDBGlobalCluster_DatabaseName (39.87s)
=== CONT  TestAccDocDBGlobalCluster_SourceDBClusterIdentifier_storageEncrypted
--- PASS: TestAccDocDBGlobalCluster_StorageEncrypted (40.84s)
=== CONT  TestAccDocDBGlobalCluster_SourceDBClusterIdentifier_basic
--- PASS: TestAccDocDBGlobalCluster_SourceDBClusterIdentifier_storageEncrypted (148.03s)
=== CONT  TestAccDocDBGlobalCluster_EngineVersion
--- PASS: TestAccDocDBGlobalCluster_SourceDBClusterIdentifier_basic (138.85s)
=== CONT  TestAccDocDBGlobalCluster_Engine
--- PASS: TestAccDocDBGlobalCluster_EngineVersion (22.50s)
=== CONT  TestAccDocDBGlobalCluster_DeletionProtection
--- PASS: TestAccDocDBGlobalCluster_Engine (27.50s)
=== CONT  TestAccDocDBCluster_updateEngineMajorVersion
=== RUN   TestAccDocDBCluster_updateEngineMajorVersion
    acctest.go:89: Amazon DocumentDB has identified an issue and is temporarily disallowing major version upgrades (MVU) in all regions.
--- SKIP: TestAccDocDBCluster_updateEngineMajorVersion (0.00s)
--- PASS: TestAccDocDBGlobalCluster_DeletionProtection (72.12s)
=== CONT  TestAccDocDBGlobalCluster_disappears
--- PASS: TestAccDocDBGlobalCluster_disappears (17.51s)
=== CONT  TestAccDocDBGlobalCluster_basic
--- PASS: TestAccDocDBGlobalCluster_basic (23.95s)
=== CONT  TestAccDocDBCluster_updateCloudWatchLogsExports
--- PASS: TestAccDocDBCluster_updateCloudWatchLogsExports (195.46s)
=== CONT  TestAccDocDBCluster_GlobalClusterIdentifier 
--- PASS: TestAccDocDBCluster_GlobalClusterIdentifier (200.49s)
=== CONT  TestAccDocDBCluster_deleteProtection
--- PASS: TestAccDocDBCluster_deleteProtection (281.59s)
=== CONT  TestAccDocDBCluster_port
=== CONT  TestAccDocDBCluster_backupsUpdate
--- PASS: TestAccDocDBCluster_port (306.71s)
=== CONT  TestAccDocDBCluster_encrypted
--- PASS: TestAccDocDBCluster_backupsUpdate (173.09s)
=== CONT  TestAccDocDBCluster_kmsKey
--- PASS: TestAccDocDBCluster_encrypted (166.96s)
=== CONT  TestAccDocDBCluster_identifierGenerated
--- PASS: TestAccDocDBCluster_kmsKey (163.07s)
=== CONT  TestAccDocDBCluster_identifierPrefix
--- PASS: TestAccDocDBCluster_identifierGenerated (164.81s)
=== CONT  TestAccDocDBCluster_GlobalClusterIdentifier_Update
--- PASS: TestAccDocDBCluster_identifierPrefix (123.74s)
=== CONT  TestAccDocDBCluster_GlobalClusterIdentifier_PrimarySecondaryClusters
--- PASS: TestAccDocDBCluster_GlobalClusterIdentifier_Update (176.53s)
=== CONT  TestAccDocDBCluster_missingUserNameCausesError
--- PASS: TestAccDocDBCluster_missingUserNameCausesError (8.95s)
=== CONT  TestAccDocDBCluster_takeFinalSnapshot
--- PASS: TestAccDocDBCluster_takeFinalSnapshot (300.18s)
=== CONT  TestAccDocDBCluster_disappears
--- PASS: TestAccDocDBCluster_disappears (162.69s)
=== CONT  TestAccDocDBCluster_GlobalClusterIdentifier_Remove
--- PASS: TestAccDocDBCluster_GlobalClusterIdentifier_Remove (163.64s)
=== CONT  TestAccDocDBCluster_tags
--- PASS: TestAccDocDBCluster_tags (185.26s)
--- PASS: TestAccDocDBCluster_GlobalClusterIdentifier_PrimarySecondaryClusters (2718.71s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/docdb	4545.540s
% make testacc TESTARGS='-run=TestAccNeptuneEngineVersionDataSource_' PKG=neptune ACCTEST_PARALLELISM=2       
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/neptune/... -v -count 1 -parallel 2  -run=TestAccNeptuneEngineVersionDataSource_ -timeout 360m
=== RUN   TestAccNeptuneEngineVersionDataSource_basic
=== PAUSE TestAccNeptuneEngineVersionDataSource_basic
=== RUN   TestAccNeptuneEngineVersionDataSource_preferred
=== PAUSE TestAccNeptuneEngineVersionDataSource_preferred
=== RUN   TestAccNeptuneEngineVersionDataSource_defaultOnly
=== PAUSE TestAccNeptuneEngineVersionDataSource_defaultOnly
=== CONT  TestAccNeptuneEngineVersionDataSource_basic
=== CONT  TestAccNeptuneEngineVersionDataSource_defaultOnly
--- PASS: TestAccNeptuneEngineVersionDataSource_basic (20.46s)
=== CONT  TestAccNeptuneEngineVersionDataSource_preferred
--- PASS: TestAccNeptuneEngineVersionDataSource_defaultOnly (20.56s)
--- PASS: TestAccNeptuneEngineVersionDataSource_preferred (18.52s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/neptune	44.555s
% make testacc TESTARGS='-run=TestAccNeptuneOrderableDBInstanceDataSource_' PKG=neptune ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/neptune/... -v -count 1 -parallel 2  -run=TestAccNeptuneOrderableDBInstanceDataSource_ -timeout 360m
=== RUN   TestAccNeptuneOrderableDBInstanceDataSource_basic
=== PAUSE TestAccNeptuneOrderableDBInstanceDataSource_basic
=== RUN   TestAccNeptuneOrderableDBInstanceDataSource_preferred
=== PAUSE TestAccNeptuneOrderableDBInstanceDataSource_preferred
=== CONT  TestAccNeptuneOrderableDBInstanceDataSource_basic
=== CONT  TestAccNeptuneOrderableDBInstanceDataSource_preferred
--- PASS: TestAccNeptuneOrderableDBInstanceDataSource_basic (19.57s)
--- PASS: TestAccNeptuneOrderableDBInstanceDataSource_preferred (21.50s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/neptune	26.942s
% make testacc TESTARGS='-run=TestAccNeptuneSubnetGroup_' PKG=neptune ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/neptune/... -v -count 1 -parallel 2  -run=TestAccNeptuneSubnetGroup_ -timeout 360m
=== RUN   TestAccNeptuneSubnetGroup_basic
=== PAUSE TestAccNeptuneSubnetGroup_basic
=== RUN   TestAccNeptuneSubnetGroup_disappears
=== PAUSE TestAccNeptuneSubnetGroup_disappears
=== RUN   TestAccNeptuneSubnetGroup_nameGenerated
=== PAUSE TestAccNeptuneSubnetGroup_nameGenerated
=== RUN   TestAccNeptuneSubnetGroup_namePrefix
=== PAUSE TestAccNeptuneSubnetGroup_namePrefix
=== RUN   TestAccNeptuneSubnetGroup_tags
=== PAUSE TestAccNeptuneSubnetGroup_tags
=== RUN   TestAccNeptuneSubnetGroup_update
=== PAUSE TestAccNeptuneSubnetGroup_update
=== CONT  TestAccNeptuneSubnetGroup_basic
=== CONT  TestAccNeptuneSubnetGroup_namePrefix
--- PASS: TestAccNeptuneSubnetGroup_basic (35.96s)
=== CONT  TestAccNeptuneSubnetGroup_update
--- PASS: TestAccNeptuneSubnetGroup_namePrefix (36.12s)
=== CONT  TestAccNeptuneSubnetGroup_tags
--- PASS: TestAccNeptuneSubnetGroup_update (52.71s)
=== CONT  TestAccNeptuneSubnetGroup_nameGenerated
--- PASS: TestAccNeptuneSubnetGroup_tags (77.56s)
=== CONT  TestAccNeptuneSubnetGroup_disappears
--- PASS: TestAccNeptuneSubnetGroup_nameGenerated (33.07s)
--- PASS: TestAccNeptuneSubnetGroup_disappears (28.19s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/neptune	147.765s
% make testacc TESTARGS='-run=TestAccNeptuneParameterGroup_' PKG=neptune ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/neptune/... -v -count 1 -parallel 2  -run=TestAccNeptuneParameterGroup_ -timeout 360m
=== RUN   TestAccNeptuneParameterGroup_basic
=== PAUSE TestAccNeptuneParameterGroup_basic
=== RUN   TestAccNeptuneParameterGroup_disappears
=== PAUSE TestAccNeptuneParameterGroup_disappears
=== RUN   TestAccNeptuneParameterGroup_nameGenerated
=== PAUSE TestAccNeptuneParameterGroup_nameGenerated
=== RUN   TestAccNeptuneParameterGroup_namePrefix
=== PAUSE TestAccNeptuneParameterGroup_namePrefix
=== RUN   TestAccNeptuneParameterGroup_description
=== PAUSE TestAccNeptuneParameterGroup_description
=== RUN   TestAccNeptuneParameterGroup_parameter
=== PAUSE TestAccNeptuneParameterGroup_parameter
=== RUN   TestAccNeptuneParameterGroup_tags
=== PAUSE TestAccNeptuneParameterGroup_tags
=== CONT  TestAccNeptuneParameterGroup_basic
=== CONT  TestAccNeptuneParameterGroup_description
--- PASS: TestAccNeptuneParameterGroup_description (26.11s)
=== CONT  TestAccNeptuneParameterGroup_nameGenerated
--- PASS: TestAccNeptuneParameterGroup_basic (26.19s)
=== CONT  TestAccNeptuneParameterGroup_namePrefix
--- PASS: TestAccNeptuneParameterGroup_nameGenerated (25.68s)
=== CONT  TestAccNeptuneParameterGroup_disappears
--- PASS: TestAccNeptuneParameterGroup_namePrefix (25.62s)
=== CONT  TestAccNeptuneParameterGroup_tags
--- PASS: TestAccNeptuneParameterGroup_disappears (19.03s)
=== CONT  TestAccNeptuneParameterGroup_parameter
--- PASS: TestAccNeptuneParameterGroup_tags (58.35s)
--- PASS: TestAccNeptuneParameterGroup_parameter (45.73s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/neptune	122.259s
% make testacc TESTARGS='-run=TestAccNeptuneClusterParameterGroup_' PKG=neptune ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/neptune/... -v -count 1 -parallel 2  -run=TestAccNeptuneClusterParameterGroup_ -timeout 360m
=== RUN   TestAccNeptuneClusterParameterGroup_basic
=== PAUSE TestAccNeptuneClusterParameterGroup_basic
=== RUN   TestAccNeptuneClusterParameterGroup_disappears
=== PAUSE TestAccNeptuneClusterParameterGroup_disappears
=== RUN   TestAccNeptuneClusterParameterGroup_nameGenerated
=== PAUSE TestAccNeptuneClusterParameterGroup_nameGenerated
=== RUN   TestAccNeptuneClusterParameterGroup_namePrefix
=== PAUSE TestAccNeptuneClusterParameterGroup_namePrefix
=== RUN   TestAccNeptuneClusterParameterGroup_tags
=== PAUSE TestAccNeptuneClusterParameterGroup_tags
=== RUN   TestAccNeptuneClusterParameterGroup_description
=== PAUSE TestAccNeptuneClusterParameterGroup_description
=== RUN   TestAccNeptuneClusterParameterGroup_parameter
=== PAUSE TestAccNeptuneClusterParameterGroup_parameter
=== RUN   TestAccNeptuneClusterParameterGroup_parameterDefault
=== PAUSE TestAccNeptuneClusterParameterGroup_parameterDefault
=== CONT  TestAccNeptuneClusterParameterGroup_basic
=== CONT  TestAccNeptuneClusterParameterGroup_tags
--- PASS: TestAccNeptuneClusterParameterGroup_basic (26.32s)
=== CONT  TestAccNeptuneClusterParameterGroup_parameter
--- PASS: TestAccNeptuneClusterParameterGroup_tags (62.27s)
=== CONT  TestAccNeptuneClusterParameterGroup_parameterDefault
--- PASS: TestAccNeptuneClusterParameterGroup_parameter (43.30s)
=== CONT  TestAccNeptuneClusterParameterGroup_description
--- PASS: TestAccNeptuneClusterParameterGroup_parameterDefault (22.61s)
=== CONT  TestAccNeptuneClusterParameterGroup_nameGenerated
--- PASS: TestAccNeptuneClusterParameterGroup_description (25.56s)
=== CONT  TestAccNeptuneClusterParameterGroup_namePrefix
--- PASS: TestAccNeptuneClusterParameterGroup_nameGenerated (24.24s)
=== CONT  TestAccNeptuneClusterParameterGroup_disappears
--- PASS: TestAccNeptuneClusterParameterGroup_namePrefix (23.76s)
--- PASS: TestAccNeptuneClusterParameterGroup_disappears (17.30s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/neptune	131.876s
% make testacc TESTARGS='-run=TestAccDocDBEngineVersionDataSource_' PKG=docdb ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/docdb/... -v -count 1 -parallel 2  -run=TestAccDocDBEngineVersionDataSource_ -timeout 360m
=== RUN   TestAccDocDBEngineVersionDataSource_basic
=== PAUSE TestAccDocDBEngineVersionDataSource_basic
=== RUN   TestAccDocDBEngineVersionDataSource_preferred
=== PAUSE TestAccDocDBEngineVersionDataSource_preferred
=== RUN   TestAccDocDBEngineVersionDataSource_defaultOnly
=== PAUSE TestAccDocDBEngineVersionDataSource_defaultOnly
=== CONT  TestAccDocDBEngineVersionDataSource_basic
=== CONT  TestAccDocDBEngineVersionDataSource_defaultOnly
--- PASS: TestAccDocDBEngineVersionDataSource_defaultOnly (18.82s)
=== CONT  TestAccDocDBEngineVersionDataSource_preferred
--- PASS: TestAccDocDBEngineVersionDataSource_basic (18.84s)
--- PASS: TestAccDocDBEngineVersionDataSource_preferred (15.76s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/docdb	39.938s
% make testacc TESTARGS='-run=TestAccDocDBOrderableDBInstanceDataSource_' PKG=docdb ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/docdb/... -v -count 1 -parallel 2  -run=TestAccDocDBOrderableDBInstanceDataSource_ -timeout 360m
=== RUN   TestAccDocDBOrderableDBInstanceDataSource_basic
=== PAUSE TestAccDocDBOrderableDBInstanceDataSource_basic
=== RUN   TestAccDocDBOrderableDBInstanceDataSource_preferred
=== PAUSE TestAccDocDBOrderableDBInstanceDataSource_preferred
=== CONT  TestAccDocDBOrderableDBInstanceDataSource_basic
=== CONT  TestAccDocDBOrderableDBInstanceDataSource_preferred
--- PASS: TestAccDocDBOrderableDBInstanceDataSource_basic (20.29s)
--- PASS: TestAccDocDBOrderableDBInstanceDataSource_preferred (21.29s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/docdb	26.898s
% make testacc TESTARGS='-run=TestAccDocDBClusterParameterGroup_' PKG=docdb ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/docdb/... -v -count 1 -parallel 2  -run=TestAccDocDBClusterParameterGroup_ -timeout 360m
=== RUN   TestAccDocDBClusterParameterGroup_basic
=== PAUSE TestAccDocDBClusterParameterGroup_basic
=== RUN   TestAccDocDBClusterParameterGroup_disappears
=== PAUSE TestAccDocDBClusterParameterGroup_disappears
=== RUN   TestAccDocDBClusterParameterGroup_nameGenerated
=== PAUSE TestAccDocDBClusterParameterGroup_nameGenerated
=== RUN   TestAccDocDBClusterParameterGroup_namePrefix
=== PAUSE TestAccDocDBClusterParameterGroup_namePrefix
=== RUN   TestAccDocDBClusterParameterGroup_description
=== PAUSE TestAccDocDBClusterParameterGroup_description
=== RUN   TestAccDocDBClusterParameterGroup_systemParameter
=== PAUSE TestAccDocDBClusterParameterGroup_systemParameter
=== RUN   TestAccDocDBClusterParameterGroup_parameter
=== PAUSE TestAccDocDBClusterParameterGroup_parameter
=== RUN   TestAccDocDBClusterParameterGroup_tags
=== PAUSE TestAccDocDBClusterParameterGroup_tags
=== CONT  TestAccDocDBClusterParameterGroup_basic
=== CONT  TestAccDocDBClusterParameterGroup_description
--- PASS: TestAccDocDBClusterParameterGroup_description (25.99s)
=== CONT  TestAccDocDBClusterParameterGroup_nameGenerated
--- PASS: TestAccDocDBClusterParameterGroup_basic (26.00s)
=== CONT  TestAccDocDBClusterParameterGroup_namePrefix
--- PASS: TestAccDocDBClusterParameterGroup_namePrefix (25.04s)
=== CONT  TestAccDocDBClusterParameterGroup_disappears
--- PASS: TestAccDocDBClusterParameterGroup_nameGenerated (25.06s)
=== CONT  TestAccDocDBClusterParameterGroup_parameter
--- PASS: TestAccDocDBClusterParameterGroup_disappears (19.17s)
=== CONT  TestAccDocDBClusterParameterGroup_tags
--- PASS: TestAccDocDBClusterParameterGroup_parameter (42.94s)
=== CONT  TestAccDocDBClusterParameterGroup_systemParameter
--- PASS: TestAccDocDBClusterParameterGroup_systemParameter (25.18s)
--- PASS: TestAccDocDBClusterParameterGroup_tags (59.23s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/docdb	134.823s
% make testacc TESTARGS='-run=TestAccDocDBCluster_storageType' PKG=docdb ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/docdb/... -v -count 1 -parallel 2  -run=TestAccDocDBCluster_storageType -timeout 360m
=== RUN   TestAccDocDBCluster_storageType
=== PAUSE TestAccDocDBCluster_storageType
=== CONT  TestAccDocDBCluster_storageType
--- PASS: TestAccDocDBCluster_storageType (286.48s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/docdb	292.774s

ewbankkit and others added 30 commits November 22, 2023 14:57
@ewbankkit
r/aws_docdb_event_subscription: Tidy up.
f5dbde0
@ewbankkit
r/aws_docdb_event_subscription: Tidy up sweeper.
077f467
@ewbankkit
Acceptance test output:
5ae370a 
% make testacc TESTARGS='-run=TestAccDocDBEventSubscription_' PKG=docdb ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/docdb/... -v -count 1 -parallel 3  -run=TestAccDocDBEventSubscription_ -timeout 360m
=== RUN   TestAccDocDBEventSubscription_basic
=== PAUSE TestAccDocDBEventSubscription_basic
=== RUN   TestAccDocDBEventSubscription_nameGenerated
=== PAUSE TestAccDocDBEventSubscription_nameGenerated
=== RUN   TestAccDocDBEventSubscription_disappears
=== PAUSE TestAccDocDBEventSubscription_disappears
=== RUN   TestAccDocDBEventSubscription_enabled
=== PAUSE TestAccDocDBEventSubscription_enabled
=== RUN   TestAccDocDBEventSubscription_eventCategories
=== PAUSE TestAccDocDBEventSubscription_eventCategories
=== RUN   TestAccDocDBEventSubscription_tags
=== PAUSE TestAccDocDBEventSubscription_tags
=== CONT  TestAccDocDBEventSubscription_basic
=== CONT  TestAccDocDBEventSubscription_enabled
=== CONT  TestAccDocDBEventSubscription_tags
--- PASS: TestAccDocDBEventSubscription_basic (245.55s)
=== CONT  TestAccDocDBEventSubscription_eventCategories
--- PASS: TestAccDocDBEventSubscription_tags (268.38s)
=== CONT  TestAccDocDBEventSubscription_nameGenerated
--- PASS: TestAccDocDBEventSubscription_enabled (329.43s)
=== CONT  TestAccDocDBEventSubscription_disappears
--- PASS: TestAccDocDBEventSubscription_nameGenerated (220.42s)
--- PASS: TestAccDocDBEventSubscription_eventCategories (291.71s)
--- PASS: TestAccDocDBEventSubscription_disappears (229.65s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/docdb	564.688s
@ewbankkit
r/aws_docdb_cluster_snapshot: Alphabetize attributes.
777626e
@ewbankkit
r/aws_neptune_cluster_snapshot: Tidy up.
cefc936
@ewbankkit
Acceptance test output:
f27c4a4 
% make testacc TESTARGS='-run=TestAccNeptuneClusterSnapshot_' PKG=neptune ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/neptune/... -v -count 1 -parallel 3  -run=TestAccNeptuneClusterSnapshot_ -timeout 360m
=== RUN   TestAccNeptuneClusterSnapshot_basic
=== PAUSE TestAccNeptuneClusterSnapshot_basic
=== RUN   TestAccNeptuneClusterSnapshot_disappears
=== PAUSE TestAccNeptuneClusterSnapshot_disappears
=== CONT  TestAccNeptuneClusterSnapshot_basic
=== CONT  TestAccNeptuneClusterSnapshot_disappears
--- PASS: TestAccNeptuneClusterSnapshot_basic (287.73s)
--- PASS: TestAccNeptuneClusterSnapshot_disappears (301.90s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/neptune	307.707s
@ewbankkit
r/aws_docdb_cluster_snapshot: Tidy up.
78960df
@ewbankkit
Acceptance test output:
4b6cab7 
% make testacc TESTARGS='-run=TestAccDocDBClusterSnapshot_' PKG=docdb ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/docdb/... -v -count 1 -parallel 3  -run=TestAccDocDBClusterSnapshot_ -timeout 360m
=== RUN   TestAccDocDBClusterSnapshot_basic
=== PAUSE TestAccDocDBClusterSnapshot_basic
=== CONT  TestAccDocDBClusterSnapshot_basic
--- PASS: TestAccDocDBClusterSnapshot_basic (212.46s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/docdb	218.092s
@ewbankkit
Add 'TestAccDocDBClusterSnapshot_disappears'.
b674828
@ewbankkit
Acceptance test output:
219221a 
% make testacc TESTARGS='-run=TestAccDocDBClusterSnapshot_disappears' PKG=docdb
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/docdb/... -v -count 1 -parallel 20  -run=TestAccDocDBClusterSnapshot_disappears -timeout 360m
=== RUN   TestAccDocDBClusterSnapshot_disappears
=== PAUSE TestAccDocDBClusterSnapshot_disappears
=== CONT  TestAccDocDBClusterSnapshot_disappears
--- PASS: TestAccDocDBClusterSnapshot_disappears (311.47s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/docdb	317.532s
@ewbankkit
r/aws_neptune_global_cluster: Tweak error messages.
b7a1623
@ewbankkit
docdb: Add 'findGlobalClusters' and friends.
e44fcf0
@ewbankkit
r/aws_neptune_cluster: Tweaks.
e4cd8a4
@ewbankkit
r/aws_docdb_cluster: Add 'removeClusterFromGlobalCluster'.
aeff2e8
@ewbankkit
r/aws_neptune_global_cluster: Tweak acceptance tests.
6475ea1
@ewbankkit
r/aws_docdb_cluster: Add 'waitDBClusterAvailable'.
c402a85
@ewbankkit
r/aws_docdb_global_cluster: Tidy up.
4b1a1e3
@ewbankkit
docdb: Tidy up sweepers.
cd0c768
@ewbankkit
TestAccDocDBCluster_updateEngineMajorVersion: Skip for now.
0e061c6
@ewbankkit
neptune: Add 'engineNeptune'.
3571beb
@ewbankkit
d/aws_neptune_engine_version: Tidy up.
d079f8a
@ewbankkit
d/aws_neptune_orderable_db_instance: Tidy up.
90bbc82
@williamlord-wise @ewbankkit
r/aws_neptune_parameter_group: Add name_prefix argument
1ff79dd
@williamlord-wise @ewbankkit
Changelog
f30daf9
@williamlord-wise @ewbankkit
Imports
f0b8303
@ewbankkit
Tweak CHANGELOG entry.
97b2894
@ewbankkit
r/aws_neptune_parameter_group: Document 'name_prefix'.
df494ea
@ewbankkit
r/aws_neptune_parameter_group: Tidy up Create.
1c79474
@ewbankkit
r/aws_neptune_subnet_group: Add 'findDBSubnetGroups'.
2ca51fa
@ewbankkit
r/aws_neptune_parameter_group: Tidy up Delete.
5849030
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/neptune Issues and PRs that pertain to the neptune service. service/docdb Issues and PRs that pertain to the docdb service. sweeper Pertains to changes to or issues with the sweeper. and removed size/XL Managed by automation to categorize the size of a PR. labels Nov 29, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Nov 29, 2023
@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 29, 2023
@ewbankkit ewbankkit mentioned this pull request Nov 29, 2023
Closed
@github-actions GitHub Actions
Copy link

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

@ewbankkit ewbankkit changed the title [WIP] DocDB & Neptune sweepers DocDB & Neptune sweepers Nov 29, 2023
@ewbankkit ewbankkit merged commit 38f0bff into main Nov 29, 2023
46 checks passed
@ewbankkit ewbankkit deleted the td-docdb-sweepers branch November 29, 2023 19:42
@github-actions github-actions bot added the size/XL Managed by automation to categorize the size of a PR. label Nov 29, 2023
@github-actions github-actions bot added this to the v5.29.0 milestone Nov 29, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

This functionality has been released in v5.29.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 1, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/docdb Issues and PRs that pertain to the docdb service. service/neptune Issues and PRs that pertain to the neptune service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.29.0
2 participants
@ewbankkit @williamlord-wise