-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_lexv2models_bot_locale: fix voice_settings.engine
validation
#34532
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Thank you for your contribution! 🚀 A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored. For additional information refer to the AWS SDK for Go Versions page in the contributor guide. |
The validator was incorrectly using the BotType enum. It has been updated to use the VoiceEngine enum instead.
A typo in the attribute definition was causing value conversion errors as the tfsdk struct tag value did not align with the key provided in the object definition.
e26bfff
to
0b2dc75
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccLexV2ModelsBotLocale_' PKG=lexv2models ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lexv2models/... -v -count 1 -parallel 2 -run=TestAccLexV2ModelsBotLocale_ -timeout 360m
=== RUN TestAccLexV2ModelsBotLocale_basic
=== PAUSE TestAccLexV2ModelsBotLocale_basic
=== RUN TestAccLexV2ModelsBotLocale_disappears
=== PAUSE TestAccLexV2ModelsBotLocale_disappears
=== RUN TestAccLexV2ModelsBotLocale_voiceSettings
=== PAUSE TestAccLexV2ModelsBotLocale_voiceSettings
=== CONT TestAccLexV2ModelsBotLocale_basic
=== CONT TestAccLexV2ModelsBotLocale_voiceSettings
--- PASS: TestAccLexV2ModelsBotLocale_voiceSettings (39.05s)
=== CONT TestAccLexV2ModelsBotLocale_disappears
--- PASS: TestAccLexV2ModelsBotLocale_basic (39.05s)
--- PASS: TestAccLexV2ModelsBotLocale_disappears (31.77s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/lexv2models 78.394s
This functionality has been released in v5.27.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Fixes validation of the
voice_settings.engine
argument to use the correct enum values ofstandard
andneural
. Also addresses a value conversion error caused by a typo in the struct tag for theengine
arguments underlying struct field. Adds an acceptance test and example with thevoice_settings
argument configured.Relations
Closes #34531
Relates #33949
References
Output from Acceptance Testing