Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_docdb_cluster: add support for allow_major_version_upgrade argument. #33790

Merged

Conversation

gbw
Copy link
Contributor

@gbw gbw commented Oct 5, 2023

Description

Adds support for allow_major_version_upgrade argument for the aws_docdb_cluster resource.

Relations

Closes #32721.
Closes #33764.
Relates #25140.
Relates #14709.

References

docdb Documentation

Output from Acceptance Testing

I lack permissions to test this.

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/docdb Issues and PRs that pertain to the docdb service. labels Oct 5, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 5, 2023
@gbw gbw marked this pull request as ready for review October 6, 2023 00:23
@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 6, 2023
@ewbankkit ewbankkit self-assigned this Oct 10, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 10, 2023
% make testacc TESTARGS='-run=TestAccDocDBCluster_updateEngineMajorVersion' PKG=docdb
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/docdb/... -v -count 1 -parallel 20  -run=TestAccDocDBCluster_updateEngineMajorVersion -timeout 360m
=== RUN   TestAccDocDBCluster_updateEngineMajorVersion
=== PAUSE TestAccDocDBCluster_updateEngineMajorVersion
=== CONT  TestAccDocDBCluster_updateEngineMajorVersion
--- PASS: TestAccDocDBCluster_updateEngineMajorVersion (2407.81s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/docdb	2421.276s
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccDocDBCluster_' PKG=docdb ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/docdb/... -v -count 1 -parallel 3  -run=TestAccDocDBCluster_ -timeout 720m
=== RUN   TestAccDocDBCluster_basic
=== PAUSE TestAccDocDBCluster_basic
=== RUN   TestAccDocDBCluster_namePrefix
=== PAUSE TestAccDocDBCluster_namePrefix
=== RUN   TestAccDocDBCluster_generatedName
=== PAUSE TestAccDocDBCluster_generatedName
=== RUN   TestAccDocDBCluster_GlobalClusterIdentifier
=== PAUSE TestAccDocDBCluster_GlobalClusterIdentifier
=== RUN   TestAccDocDBCluster_GlobalClusterIdentifier_Add
=== PAUSE TestAccDocDBCluster_GlobalClusterIdentifier_Add
=== RUN   TestAccDocDBCluster_GlobalClusterIdentifier_Remove
=== PAUSE TestAccDocDBCluster_GlobalClusterIdentifier_Remove
=== RUN   TestAccDocDBCluster_GlobalClusterIdentifier_Update
=== PAUSE TestAccDocDBCluster_GlobalClusterIdentifier_Update
=== RUN   TestAccDocDBCluster_GlobalClusterIdentifier_PrimarySecondaryClusters
=== PAUSE TestAccDocDBCluster_GlobalClusterIdentifier_PrimarySecondaryClusters
=== RUN   TestAccDocDBCluster_takeFinalSnapshot
=== PAUSE TestAccDocDBCluster_takeFinalSnapshot
=== RUN   TestAccDocDBCluster_missingUserNameCausesError
=== PAUSE TestAccDocDBCluster_missingUserNameCausesError
=== RUN   TestAccDocDBCluster_updateTags
=== PAUSE TestAccDocDBCluster_updateTags
=== RUN   TestAccDocDBCluster_updateCloudWatchLogsExports
=== PAUSE TestAccDocDBCluster_updateCloudWatchLogsExports
=== RUN   TestAccDocDBCluster_kmsKey
=== PAUSE TestAccDocDBCluster_kmsKey
=== RUN   TestAccDocDBCluster_encrypted
=== PAUSE TestAccDocDBCluster_encrypted
=== RUN   TestAccDocDBCluster_backupsUpdate
=== PAUSE TestAccDocDBCluster_backupsUpdate
=== RUN   TestAccDocDBCluster_port
=== PAUSE TestAccDocDBCluster_port
=== RUN   TestAccDocDBCluster_deleteProtection
=== PAUSE TestAccDocDBCluster_deleteProtection
=== RUN   TestAccDocDBCluster_updateEngineMajorVersion
=== PAUSE TestAccDocDBCluster_updateEngineMajorVersion
=== CONT  TestAccDocDBCluster_basic
=== CONT  TestAccDocDBCluster_missingUserNameCausesError
=== CONT  TestAccDocDBCluster_updateEngineMajorVersion
--- PASS: TestAccDocDBCluster_missingUserNameCausesError (12.10s)
=== CONT  TestAccDocDBCluster_deleteProtection
--- PASS: TestAccDocDBCluster_basic (163.94s)
=== CONT  TestAccDocDBCluster_port
--- PASS: TestAccDocDBCluster_deleteProtection (266.20s)
=== CONT  TestAccDocDBCluster_backupsUpdate
--- PASS: TestAccDocDBCluster_backupsUpdate (226.59s)
=== CONT  TestAccDocDBCluster_encrypted
--- PASS: TestAccDocDBCluster_port (347.60s)
=== CONT  TestAccDocDBCluster_kmsKey
--- PASS: TestAccDocDBCluster_encrypted (147.08s)
=== CONT  TestAccDocDBCluster_updateCloudWatchLogsExports
--- PASS: TestAccDocDBCluster_kmsKey (162.86s)
=== CONT  TestAccDocDBCluster_updateTags
--- PASS: TestAccDocDBCluster_updateCloudWatchLogsExports (205.46s)
=== CONT  TestAccDocDBCluster_GlobalClusterIdentifier_Remove
--- PASS: TestAccDocDBCluster_updateTags (195.99s)
=== CONT  TestAccDocDBCluster_takeFinalSnapshot
--- PASS: TestAccDocDBCluster_GlobalClusterIdentifier_Remove (157.16s)
=== CONT  TestAccDocDBCluster_GlobalClusterIdentifier_PrimarySecondaryClusters
--- PASS: TestAccDocDBCluster_takeFinalSnapshot (311.13s)
=== CONT  TestAccDocDBCluster_GlobalClusterIdentifier_Update
--- PASS: TestAccDocDBCluster_GlobalClusterIdentifier_Update (188.55s)
=== CONT  TestAccDocDBCluster_GlobalClusterIdentifier
--- PASS: TestAccDocDBCluster_GlobalClusterIdentifier (148.55s)
=== CONT  TestAccDocDBCluster_GlobalClusterIdentifier_Add
--- PASS: TestAccDocDBCluster_GlobalClusterIdentifier_Add (155.74s)
=== CONT  TestAccDocDBCluster_generatedName
--- PASS: TestAccDocDBCluster_generatedName (165.03s)
=== CONT  TestAccDocDBCluster_namePrefix
--- PASS: TestAccDocDBCluster_namePrefix (155.27s)
--- PASS: TestAccDocDBCluster_updateEngineMajorVersion (2288.82s)
--- PASS: TestAccDocDBCluster_GlobalClusterIdentifier_PrimarySecondaryClusters (3079.89s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/docdb	4099.768s

@ewbankkit
Copy link
Contributor

@gbw Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 6050e6f into hashicorp:main Oct 11, 2023
41 checks passed
@github-actions github-actions bot added this to the v5.21.0 milestone Oct 11, 2023
@github-actions
Copy link

This functionality has been released in v5.21.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@gbw gbw deleted the f-docdb_cluster_allow_major_version_upgrade branch October 21, 2023 22:57
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/docdb Issues and PRs that pertain to the docdb service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
3 participants