Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Resource]: aws_servicequotas_template #33688

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Sep 29, 2023

Description

The aws_servicequotas_template resource allows a management organization to add quota increases to a template to be applied across all member accounts.

Relations

Relates #9119

References

Output from Acceptance Testing

NOTE: Tests must be run from the management account of an organization, and in the us-east-1 region

% make testacc PKG=servicequotas TESTS=TestAccServiceQuotasTemplate_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/servicequotas/... -v -count 1 -parallel 20 -run='TestAccServiceQuotasTemplate_'  -timeout 360m

--- PASS: TestAccServiceQuotasTemplate_disappears (11.79s)
--- PASS: TestAccServiceQuotasTemplate_basic (14.05s)
--- PASS: TestAccServiceQuotasTemplate_value (22.16s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/servicequotas      25.330s

In a member account or the wrong region, tests will be automatically skipped:

% make testacc PKG=servicequotas TESTS=TestAccServiceQuotasTemplate_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/servicequotas/... -v -count 1 -parallel 20 -run='TestAccServiceQuotasTemplate_'  -timeout 360m

    template_test.go:152: skipping acceptance testing: operation error Service Quotas: ListServiceQuotaIncreaseRequestsInTemplate, https response error StatusCode: 400, RequestID: 8fd7d25f-c872-42f7-b472-33825df6dd79, AccessDeniedException: The request was called by a member account. To make this request, you must use the organization's master account.
--- SKIP: TestAccServiceQuotasTemplate_disappears (0.20s)
=== NAME  TestAccServiceQuotasTemplate_basic
    template_test.go:152: skipping acceptance testing: operation error Service Quotas: ListServiceQuotaIncreaseRequestsInTemplate, https response error StatusCode: 400, RequestID: 1e5f98f8-d73f-47bb-876d-5ed617d152dc, AccessDeniedException: The request was called by a member account. To make this request, you must use the organization's master account.
--- SKIP: TestAccServiceQuotasTemplate_basic (0.20s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/servicequotas      3.261s
% make testacc PKG=servicequotas TESTS=TestAccServiceQuotasTemplate_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/servicequotas/... -v -count 1 -parallel 20 -run='TestAccServiceQuotasTemplate_'  -timeout 360m

=== NAME  TestAccServiceQuotasTemplate_basic
    acctest.go:877: skipping tests; AWS_DEFAULT_REGION (us-west-2) not supported. Supported: [us-east-1]
--- SKIP: TestAccServiceQuotasTemplate_basic (0.49s)
=== NAME  TestAccServiceQuotasTemplate_disappears
    acctest.go:877: skipping tests; AWS_DEFAULT_REGION (us-west-2) not supported. Supported: [us-east-1]
--- SKIP: TestAccServiceQuotasTemplate_disappears (0.48s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/servicequotas      3.685s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/servicequotas Issues and PRs that pertain to the servicequotas service. generators Relates to code generators. labels Sep 29, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 29, 2023
@jar-b jar-b force-pushed the f-servicequota-template branch from ef2b3b8 to 9c41a66 Compare September 29, 2023 16:38
@jar-b jar-b force-pushed the f-servicequota-template branch from 9c41a66 to aee29b0 Compare September 29, 2023 17:38
@jar-b jar-b marked this pull request as ready for review September 29, 2023 18:04
@jar-b jar-b merged commit 77a2c08 into main Oct 2, 2023
41 checks passed
@jar-b jar-b deleted the f-servicequota-template branch October 2, 2023 18:41
@github-actions github-actions bot added this to the v5.20.0 milestone Oct 2, 2023
github-actions bot pushed a commit that referenced this pull request Oct 2, 2023
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

This functionality has been released in v5.20.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Nov 6, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/servicequotas Issues and PRs that pertain to the servicequotas service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant