Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_s3_bucket_website_configuration et al.: Migrate to AWS SDK for Go v2 #33537

Merged
merged 39 commits into from
Sep 22, 2023

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Sep 19, 2023

Description

Migrates the aws_s3_bucket_website_configuration resource to AWS SDK for Go v2.
Migrates the aws_s3_bucket_object_lock_configuration resource to AWS SDK for Go v2.
Migrates the aws_s3_bucket_analytics_configuration resource to AWS SDK for Go v2.
Migrates the aws_s3_bucket_server_side_encryption_configuration resource to AWS SDK for Go v2.
Migrates the aws_s3_bucket_acl resource to AWS SDK for Go v2.
Migrates the aws_s3_bucket_cors_configuration resource to AWS SDK for Go v2.

Relations

Closes #33569.
Relates #33431.
Relates #33358.
Relates #33330.
Relates #33304.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccS3BucketWebsiteConfiguration_' PKG=s3 ACCTEST_PARALLELISM=2 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 2  -run=TestAccS3BucketWebsiteConfiguration_ -timeout 180m
=== RUN   TestAccS3BucketWebsiteConfiguration_basic
=== PAUSE TestAccS3BucketWebsiteConfiguration_basic
=== RUN   TestAccS3BucketWebsiteConfiguration_disappears
=== PAUSE TestAccS3BucketWebsiteConfiguration_disappears
=== RUN   TestAccS3BucketWebsiteConfiguration_update
=== PAUSE TestAccS3BucketWebsiteConfiguration_update
=== RUN   TestAccS3BucketWebsiteConfiguration_Redirect
=== PAUSE TestAccS3BucketWebsiteConfiguration_Redirect
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRule_ConditionAndRedirect
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRule_ConditionAndRedirect
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRule_MultipleRules
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRule_MultipleRules
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRule_RedirectOnly
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRule_RedirectOnly
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirect
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirect
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirectWithEmptyString
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirectWithEmptyString
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRules_updateConditionAndRedirect
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRules_updateConditionAndRedirect
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRuleToRoutingRules
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRuleToRoutingRules
=== RUN   TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentNoChange
=== PAUSE TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentNoChange
=== RUN   TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentWithChange
=== PAUSE TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentWithChange
=== RUN   TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleNoChange
=== PAUSE TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleNoChange
=== RUN   TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleWithChange
=== PAUSE TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleWithChange
=== CONT  TestAccS3BucketWebsiteConfiguration_basic
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirectWithEmptyString
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirectWithEmptyString (48.45s)
=== CONT  TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleWithChange
--- PASS: TestAccS3BucketWebsiteConfiguration_basic (48.59s)
=== CONT  TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleNoChange
--- PASS: TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleNoChange (66.45s)
=== CONT  TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentWithChange
--- PASS: TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleWithChange (66.69s)
=== CONT  TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentNoChange
--- PASS: TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentNoChange (68.76s)
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRuleToRoutingRules
--- PASS: TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentWithChange (68.93s)
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRules_updateConditionAndRedirect
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRuleToRoutingRules (65.08s)
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRule_ConditionAndRedirect
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_updateConditionAndRedirect (68.58s)
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirect
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirect (53.43s)
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRule_RedirectOnly
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRule_RedirectOnly (37.79s)
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRule_MultipleRules
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRule_ConditionAndRedirect (119.56s)
=== CONT  TestAccS3BucketWebsiteConfiguration_update
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRule_MultipleRules (72.55s)
=== CONT  TestAccS3BucketWebsiteConfiguration_Redirect
--- PASS: TestAccS3BucketWebsiteConfiguration_update (69.62s)
=== CONT  TestAccS3BucketWebsiteConfiguration_disappears
--- PASS: TestAccS3BucketWebsiteConfiguration_Redirect (47.71s)
--- PASS: TestAccS3BucketWebsiteConfiguration_disappears (26.72s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	470.678s
% make testacc TESTARGS='-run=TestAccS3BucketWebsiteConfiguration_' PKG=s3 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 2  -run=TestAccS3BucketWebsiteConfiguration_ -timeout 180m
=== RUN   TestAccS3BucketWebsiteConfiguration_basic
=== PAUSE TestAccS3BucketWebsiteConfiguration_basic
=== RUN   TestAccS3BucketWebsiteConfiguration_disappears
=== PAUSE TestAccS3BucketWebsiteConfiguration_disappears
=== RUN   TestAccS3BucketWebsiteConfiguration_update
=== PAUSE TestAccS3BucketWebsiteConfiguration_update
=== RUN   TestAccS3BucketWebsiteConfiguration_Redirect
=== PAUSE TestAccS3BucketWebsiteConfiguration_Redirect
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRule_ConditionAndRedirect
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRule_ConditionAndRedirect
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRule_MultipleRules
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRule_MultipleRules
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRule_RedirectOnly
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRule_RedirectOnly
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirect
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirect
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirectWithEmptyString
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirectWithEmptyString
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRules_updateConditionAndRedirect
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRules_updateConditionAndRedirect
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRuleToRoutingRules
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRuleToRoutingRules
=== RUN   TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentNoChange
=== PAUSE TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentNoChange
=== RUN   TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentWithChange
=== PAUSE TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentWithChange
=== RUN   TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleNoChange
=== PAUSE TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleNoChange
=== RUN   TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleWithChange
=== PAUSE TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleWithChange
=== CONT  TestAccS3BucketWebsiteConfiguration_basic
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirectWithEmptyString
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirectWithEmptyString (45.44s)
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRule_ConditionAndRedirect
--- PASS: TestAccS3BucketWebsiteConfiguration_basic (45.88s)
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirect
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirect (45.82s)
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRule_RedirectOnly
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRule_RedirectOnly (46.44s)
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRule_MultipleRules
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRule_ConditionAndRedirect (108.25s)
=== CONT  TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentWithChange
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRule_MultipleRules (65.24s)
=== CONT  TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleWithChange
--- PASS: TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentWithChange (61.27s)
=== CONT  TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleNoChange
--- PASS: TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleWithChange (61.70s)
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRuleToRoutingRules
--- PASS: TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleNoChange (61.30s)
=== CONT  TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentNoChange
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRuleToRoutingRules (59.80s)
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRules_updateConditionAndRedirect
--- PASS: TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentNoChange (62.00s)
=== CONT  TestAccS3BucketWebsiteConfiguration_update
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_updateConditionAndRedirect (62.66s)
=== CONT  TestAccS3BucketWebsiteConfiguration_Redirect
--- PASS: TestAccS3BucketWebsiteConfiguration_update (66.70s)
=== CONT  TestAccS3BucketWebsiteConfiguration_disappears
--- PASS: TestAccS3BucketWebsiteConfiguration_disappears (25.25s)
--- PASS: TestAccS3BucketWebsiteConfiguration_Redirect (45.36s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	437.875s
% make testacc TESTARGS='-run=TestAccS3BucketAnalyticsConfiguration_' PKG=s3 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 2  -run=TestAccS3BucketAnalyticsConfiguration_ -timeout 180m
=== RUN   TestAccS3BucketAnalyticsConfiguration_basic
=== PAUSE TestAccS3BucketAnalyticsConfiguration_basic
=== RUN   TestAccS3BucketAnalyticsConfiguration_disappears
=== PAUSE TestAccS3BucketAnalyticsConfiguration_disappears
=== RUN   TestAccS3BucketAnalyticsConfiguration_updateBasic
=== PAUSE TestAccS3BucketAnalyticsConfiguration_updateBasic
=== RUN   TestAccS3BucketAnalyticsConfiguration_WithFilter_empty
=== PAUSE TestAccS3BucketAnalyticsConfiguration_WithFilter_empty
=== RUN   TestAccS3BucketAnalyticsConfiguration_WithFilter_prefix
=== PAUSE TestAccS3BucketAnalyticsConfiguration_WithFilter_prefix
=== RUN   TestAccS3BucketAnalyticsConfiguration_WithFilter_singleTag
=== PAUSE TestAccS3BucketAnalyticsConfiguration_WithFilter_singleTag
=== RUN   TestAccS3BucketAnalyticsConfiguration_WithFilter_multipleTags
=== PAUSE TestAccS3BucketAnalyticsConfiguration_WithFilter_multipleTags
=== RUN   TestAccS3BucketAnalyticsConfiguration_WithFilter_prefixAndTags
=== PAUSE TestAccS3BucketAnalyticsConfiguration_WithFilter_prefixAndTags
=== RUN   TestAccS3BucketAnalyticsConfiguration_WithFilter_remove
=== PAUSE TestAccS3BucketAnalyticsConfiguration_WithFilter_remove
=== RUN   TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_empty
=== PAUSE TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_empty
=== RUN   TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_default
=== PAUSE TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_default
=== RUN   TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_full
=== PAUSE TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_full
=== CONT  TestAccS3BucketAnalyticsConfiguration_basic
=== CONT  TestAccS3BucketAnalyticsConfiguration_WithFilter_multipleTags
--- PASS: TestAccS3BucketAnalyticsConfiguration_basic (95.13s)
=== CONT  TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_empty
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_empty (2.46s)
=== CONT  TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_full
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_multipleTags (116.20s)
=== CONT  TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_default
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_full (46.15s)
=== CONT  TestAccS3BucketAnalyticsConfiguration_WithFilter_remove
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_default (46.86s)
=== CONT  TestAccS3BucketAnalyticsConfiguration_WithFilter_prefixAndTags
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_remove (67.32s)
=== CONT  TestAccS3BucketAnalyticsConfiguration_WithFilter_empty
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_empty (2.10s)
=== CONT  TestAccS3BucketAnalyticsConfiguration_WithFilter_singleTag
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_prefixAndTags (51.87s)
=== CONT  TestAccS3BucketAnalyticsConfiguration_WithFilter_prefix
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_singleTag (67.59s)
=== CONT  TestAccS3BucketAnalyticsConfiguration_updateBasic
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_prefix (67.51s)
=== CONT  TestAccS3BucketAnalyticsConfiguration_disappears
--- PASS: TestAccS3BucketAnalyticsConfiguration_disappears (27.35s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_updateBasic (89.23s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	389.721s
% make testacc TESTARGS='-run=TestAccS3BucketServerSideEncryptionConfiguration_' PKG=s3 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 2  -run=TestAccS3BucketServerSideEncryptionConfiguration_ -timeout 180m
=== RUN   TestAccS3BucketServerSideEncryptionConfiguration_basic
=== PAUSE TestAccS3BucketServerSideEncryptionConfiguration_basic
=== RUN   TestAccS3BucketServerSideEncryptionConfiguration_ApplySEEByDefault_AES256
=== PAUSE TestAccS3BucketServerSideEncryptionConfiguration_ApplySEEByDefault_AES256
=== RUN   TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMS
=== PAUSE TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMS
=== RUN   TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMSDSSE
=== PAUSE TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMSDSSE
=== RUN   TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_UpdateSSEAlgorithm
=== PAUSE TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_UpdateSSEAlgorithm
=== RUN   TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMSWithMasterKeyARN
=== PAUSE TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMSWithMasterKeyARN
=== RUN   TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMSWithMasterKeyID
=== PAUSE TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMSWithMasterKeyID
=== RUN   TestAccS3BucketServerSideEncryptionConfiguration_BucketKeyEnabled
=== PAUSE TestAccS3BucketServerSideEncryptionConfiguration_BucketKeyEnabled
=== RUN   TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_BucketKeyEnabled
=== PAUSE TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_BucketKeyEnabled
=== RUN   TestAccS3BucketServerSideEncryptionConfiguration_migrate_noChange
=== PAUSE TestAccS3BucketServerSideEncryptionConfiguration_migrate_noChange
=== RUN   TestAccS3BucketServerSideEncryptionConfiguration_migrate_withChange
=== PAUSE TestAccS3BucketServerSideEncryptionConfiguration_migrate_withChange
=== CONT  TestAccS3BucketServerSideEncryptionConfiguration_basic
=== CONT  TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMSWithMasterKeyID
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMSWithMasterKeyID (47.24s)
=== CONT  TestAccS3BucketServerSideEncryptionConfiguration_migrate_noChange
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_basic (47.35s)
=== CONT  TestAccS3BucketServerSideEncryptionConfiguration_migrate_withChange
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_migrate_withChange (104.71s)
=== CONT  TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_BucketKeyEnabled
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_migrate_noChange (105.20s)
=== CONT  TestAccS3BucketServerSideEncryptionConfiguration_BucketKeyEnabled
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_BucketKeyEnabled (119.03s)
=== CONT  TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMSDSSE
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_BucketKeyEnabled (119.48s)
=== CONT  TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMSWithMasterKeyARN
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMSDSSE (46.11s)
=== CONT  TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_UpdateSSEAlgorithm
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMSWithMasterKeyARN (45.31s)
=== CONT  TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMS
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMS (45.81s)
=== CONT  TestAccS3BucketServerSideEncryptionConfiguration_ApplySEEByDefault_AES256
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_UpdateSSEAlgorithm (67.57s)
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_ApplySEEByDefault_AES256 (44.91s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	412.898s
% make testacc TESTARGS='-run=TestAccS3BucketACL_' PKG=s3 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 2  -run=TestAccS3BucketACL_ -timeout 180m
=== RUN   TestAccS3BucketACL_basic
=== PAUSE TestAccS3BucketACL_basic
=== RUN   TestAccS3BucketACL_disappears
=== PAUSE TestAccS3BucketACL_disappears
=== RUN   TestAccS3BucketACL_migrate_aclNoChange
=== PAUSE TestAccS3BucketACL_migrate_aclNoChange
=== RUN   TestAccS3BucketACL_migrate_aclWithChange
=== PAUSE TestAccS3BucketACL_migrate_aclWithChange
=== RUN   TestAccS3BucketACL_migrate_grantsWithChange
=== PAUSE TestAccS3BucketACL_migrate_grantsWithChange
=== RUN   TestAccS3BucketACL_updateACL
=== PAUSE TestAccS3BucketACL_updateACL
=== RUN   TestAccS3BucketACL_updateGrant
=== PAUSE TestAccS3BucketACL_updateGrant
=== RUN   TestAccS3BucketACL_ACLToGrant
=== PAUSE TestAccS3BucketACL_ACLToGrant
=== RUN   TestAccS3BucketACL_grantToACL
=== PAUSE TestAccS3BucketACL_grantToACL
=== CONT  TestAccS3BucketACL_basic
=== CONT  TestAccS3BucketACL_updateACL
--- PASS: TestAccS3BucketACL_basic (32.07s)
=== CONT  TestAccS3BucketACL_ACLToGrant
=== CONT  TestAccS3BucketACL_grantToACL
--- PASS: TestAccS3BucketACL_updateACL (54.26s)
--- PASS: TestAccS3BucketACL_ACLToGrant (52.62s)
=== CONT  TestAccS3BucketACL_migrate_aclWithChange
--- PASS: TestAccS3BucketACL_grantToACL (53.73s)
=== CONT  TestAccS3BucketACL_migrate_grantsWithChange
--- PASS: TestAccS3BucketACL_migrate_aclWithChange (49.19s)
=== CONT  TestAccS3BucketACL_updateGrant
--- PASS: TestAccS3BucketACL_migrate_grantsWithChange (47.84s)
=== CONT  TestAccS3BucketACL_migrate_aclNoChange
--- PASS: TestAccS3BucketACL_updateGrant (58.59s)
=== CONT  TestAccS3BucketACL_disappears
--- PASS: TestAccS3BucketACL_migrate_aclNoChange (48.13s)
--- PASS: TestAccS3BucketACL_disappears (38.48s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	236.236s
% make testacc TESTARGS='-run=TestAccS3BucketCORSConfiguration_' PKG=s3 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 3  -run=TestAccS3BucketCORSConfiguration_ -timeout 180m
=== RUN   TestAccS3BucketCORSConfiguration_basic
=== PAUSE TestAccS3BucketCORSConfiguration_basic
=== RUN   TestAccS3BucketCORSConfiguration_disappears
=== PAUSE TestAccS3BucketCORSConfiguration_disappears
=== RUN   TestAccS3BucketCORSConfiguration_update
=== PAUSE TestAccS3BucketCORSConfiguration_update
=== RUN   TestAccS3BucketCORSConfiguration_SingleRule
=== PAUSE TestAccS3BucketCORSConfiguration_SingleRule
=== RUN   TestAccS3BucketCORSConfiguration_MultipleRules
=== PAUSE TestAccS3BucketCORSConfiguration_MultipleRules
=== RUN   TestAccS3BucketCORSConfiguration_migrate_corsRuleNoChange
=== PAUSE TestAccS3BucketCORSConfiguration_migrate_corsRuleNoChange
=== RUN   TestAccS3BucketCORSConfiguration_migrate_corsRuleWithChange
=== PAUSE TestAccS3BucketCORSConfiguration_migrate_corsRuleWithChange
=== CONT  TestAccS3BucketCORSConfiguration_MultipleRules
=== CONT  TestAccS3BucketCORSConfiguration_update
=== CONT  TestAccS3BucketCORSConfiguration_basic
--- PASS: TestAccS3BucketCORSConfiguration_basic (50.94s)
=== CONT  TestAccS3BucketCORSConfiguration_SingleRule
--- PASS: TestAccS3BucketCORSConfiguration_MultipleRules (51.01s)
=== CONT  TestAccS3BucketCORSConfiguration_migrate_corsRuleWithChange
--- PASS: TestAccS3BucketCORSConfiguration_update (92.05s)
=== CONT  TestAccS3BucketCORSConfiguration_migrate_corsRuleNoChange
--- PASS: TestAccS3BucketCORSConfiguration_SingleRule (48.04s)
=== CONT  TestAccS3BucketCORSConfiguration_disappears
--- PASS: TestAccS3BucketCORSConfiguration_migrate_corsRuleWithChange (64.23s)
--- PASS: TestAccS3BucketCORSConfiguration_disappears (26.26s)
--- PASS: TestAccS3BucketCORSConfiguration_migrate_corsRuleNoChange (61.04s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	158.366s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/s3 Issues and PRs that pertain to the s3 service. labels Sep 19, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 19, 2023
% make testacc TESTARGS='-run=TestAccS3BucketWebsiteConfiguration_' PKG=s3 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 2  -run=TestAccS3BucketWebsiteConfiguration_ -timeout 180m
=== RUN   TestAccS3BucketWebsiteConfiguration_basic
=== PAUSE TestAccS3BucketWebsiteConfiguration_basic
=== RUN   TestAccS3BucketWebsiteConfiguration_disappears
=== PAUSE TestAccS3BucketWebsiteConfiguration_disappears
=== RUN   TestAccS3BucketWebsiteConfiguration_update
=== PAUSE TestAccS3BucketWebsiteConfiguration_update
=== RUN   TestAccS3BucketWebsiteConfiguration_Redirect
=== PAUSE TestAccS3BucketWebsiteConfiguration_Redirect
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRule_ConditionAndRedirect
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRule_ConditionAndRedirect
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRule_MultipleRules
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRule_MultipleRules
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRule_RedirectOnly
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRule_RedirectOnly
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirect
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirect
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirectWithEmptyString
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirectWithEmptyString
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRules_updateConditionAndRedirect
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRules_updateConditionAndRedirect
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRuleToRoutingRules
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRuleToRoutingRules
=== RUN   TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentNoChange
=== PAUSE TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentNoChange
=== RUN   TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentWithChange
=== PAUSE TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentWithChange
=== RUN   TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleNoChange
=== PAUSE TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleNoChange
=== RUN   TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleWithChange
=== PAUSE TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleWithChange
=== CONT  TestAccS3BucketWebsiteConfiguration_basic
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirectWithEmptyString
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirectWithEmptyString (48.45s)
=== CONT  TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleWithChange
--- PASS: TestAccS3BucketWebsiteConfiguration_basic (48.59s)
=== CONT  TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleNoChange
--- PASS: TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleNoChange (66.45s)
=== CONT  TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentWithChange
--- PASS: TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleWithChange (66.69s)
=== CONT  TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentNoChange
--- PASS: TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentNoChange (68.76s)
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRuleToRoutingRules
--- PASS: TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentWithChange (68.93s)
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRules_updateConditionAndRedirect
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRuleToRoutingRules (65.08s)
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRule_ConditionAndRedirect
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_updateConditionAndRedirect (68.58s)
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirect
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirect (53.43s)
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRule_RedirectOnly
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRule_RedirectOnly (37.79s)
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRule_MultipleRules
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRule_ConditionAndRedirect (119.56s)
=== CONT  TestAccS3BucketWebsiteConfiguration_update
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRule_MultipleRules (72.55s)
=== CONT  TestAccS3BucketWebsiteConfiguration_Redirect
--- PASS: TestAccS3BucketWebsiteConfiguration_update (69.62s)
=== CONT  TestAccS3BucketWebsiteConfiguration_disappears
--- PASS: TestAccS3BucketWebsiteConfiguration_Redirect (47.71s)
--- PASS: TestAccS3BucketWebsiteConfiguration_disappears (26.72s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	470.678s
% make testacc TESTARGS='-run=TestAccS3BucketObjectLockConfiguration_' PKG=s3 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 2  -run=TestAccS3BucketObjectLockConfiguration_ -timeout 180m
=== RUN   TestAccS3BucketObjectLockConfiguration_basic
=== PAUSE TestAccS3BucketObjectLockConfiguration_basic
=== RUN   TestAccS3BucketObjectLockConfiguration_disappears
=== PAUSE TestAccS3BucketObjectLockConfiguration_disappears
=== RUN   TestAccS3BucketObjectLockConfiguration_update
=== PAUSE TestAccS3BucketObjectLockConfiguration_update
=== RUN   TestAccS3BucketObjectLockConfiguration_migrate_noChange
=== PAUSE TestAccS3BucketObjectLockConfiguration_migrate_noChange
=== RUN   TestAccS3BucketObjectLockConfiguration_migrate_withChange
=== PAUSE TestAccS3BucketObjectLockConfiguration_migrate_withChange
=== RUN   TestAccS3BucketObjectLockConfiguration_noRule
=== PAUSE TestAccS3BucketObjectLockConfiguration_noRule
=== CONT  TestAccS3BucketObjectLockConfiguration_basic
=== CONT  TestAccS3BucketObjectLockConfiguration_migrate_noChange
--- PASS: TestAccS3BucketObjectLockConfiguration_basic (51.06s)
=== CONT  TestAccS3BucketObjectLockConfiguration_noRule
--- PASS: TestAccS3BucketObjectLockConfiguration_migrate_noChange (68.39s)
=== CONT  TestAccS3BucketObjectLockConfiguration_update
--- PASS: TestAccS3BucketObjectLockConfiguration_noRule (46.01s)
=== CONT  TestAccS3BucketObjectLockConfiguration_migrate_withChange
--- PASS: TestAccS3BucketObjectLockConfiguration_update (70.60s)
=== CONT  TestAccS3BucketObjectLockConfiguration_disappears
--- PASS: TestAccS3BucketObjectLockConfiguration_migrate_withChange (66.61s)
--- PASS: TestAccS3BucketObjectLockConfiguration_disappears (45.72s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	190.569s
@ewbankkit ewbankkit changed the title [WIP] r/aws_s3_bucket_website_configuration: Migrate to AWS SDK for Go v2 [WIP] r/aws_s3_bucket_website_configuration et al.: Migrate to AWS SDK for Go v2 Sep 19, 2023
…it tests as they don't play nice with Smithy.
% make testacc TESTARGS='-run=TestAccS3BucketAnalyticsConfiguration_' PKG=s3 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 2  -run=TestAccS3BucketAnalyticsConfiguration_ -timeout 180m
=== RUN   TestAccS3BucketAnalyticsConfiguration_basic
=== PAUSE TestAccS3BucketAnalyticsConfiguration_basic
=== RUN   TestAccS3BucketAnalyticsConfiguration_disappears
=== PAUSE TestAccS3BucketAnalyticsConfiguration_disappears
=== RUN   TestAccS3BucketAnalyticsConfiguration_updateBasic
=== PAUSE TestAccS3BucketAnalyticsConfiguration_updateBasic
=== RUN   TestAccS3BucketAnalyticsConfiguration_WithFilter_empty
=== PAUSE TestAccS3BucketAnalyticsConfiguration_WithFilter_empty
=== RUN   TestAccS3BucketAnalyticsConfiguration_WithFilter_prefix
=== PAUSE TestAccS3BucketAnalyticsConfiguration_WithFilter_prefix
=== RUN   TestAccS3BucketAnalyticsConfiguration_WithFilter_singleTag
=== PAUSE TestAccS3BucketAnalyticsConfiguration_WithFilter_singleTag
=== RUN   TestAccS3BucketAnalyticsConfiguration_WithFilter_multipleTags
=== PAUSE TestAccS3BucketAnalyticsConfiguration_WithFilter_multipleTags
=== RUN   TestAccS3BucketAnalyticsConfiguration_WithFilter_prefixAndTags
=== PAUSE TestAccS3BucketAnalyticsConfiguration_WithFilter_prefixAndTags
=== RUN   TestAccS3BucketAnalyticsConfiguration_WithFilter_remove
=== PAUSE TestAccS3BucketAnalyticsConfiguration_WithFilter_remove
=== RUN   TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_empty
=== PAUSE TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_empty
=== RUN   TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_default
=== PAUSE TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_default
=== RUN   TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_full
=== PAUSE TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_full
=== CONT  TestAccS3BucketAnalyticsConfiguration_basic
=== CONT  TestAccS3BucketAnalyticsConfiguration_WithFilter_multipleTags
--- PASS: TestAccS3BucketAnalyticsConfiguration_basic (95.13s)
=== CONT  TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_empty
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_empty (2.46s)
=== CONT  TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_full
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_multipleTags (116.20s)
=== CONT  TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_default
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_full (46.15s)
=== CONT  TestAccS3BucketAnalyticsConfiguration_WithFilter_remove
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_default (46.86s)
=== CONT  TestAccS3BucketAnalyticsConfiguration_WithFilter_prefixAndTags
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_remove (67.32s)
=== CONT  TestAccS3BucketAnalyticsConfiguration_WithFilter_empty
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_empty (2.10s)
=== CONT  TestAccS3BucketAnalyticsConfiguration_WithFilter_singleTag
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_prefixAndTags (51.87s)
=== CONT  TestAccS3BucketAnalyticsConfiguration_WithFilter_prefix
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_singleTag (67.59s)
=== CONT  TestAccS3BucketAnalyticsConfiguration_updateBasic
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_prefix (67.51s)
=== CONT  TestAccS3BucketAnalyticsConfiguration_disappears
--- PASS: TestAccS3BucketAnalyticsConfiguration_disappears (27.35s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_updateBasic (89.23s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	389.721s
@github-actions github-actions bot added the sweeper Pertains to changes to or issues with the sweeper. label Sep 20, 2023
% make testacc TESTARGS='-run=TestAccS3BucketServerSideEncryptionConfiguration_' PKG=s3 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 2  -run=TestAccS3BucketServerSideEncryptionConfiguration_ -timeout 180m
=== RUN   TestAccS3BucketServerSideEncryptionConfiguration_basic
=== PAUSE TestAccS3BucketServerSideEncryptionConfiguration_basic
=== RUN   TestAccS3BucketServerSideEncryptionConfiguration_ApplySEEByDefault_AES256
=== PAUSE TestAccS3BucketServerSideEncryptionConfiguration_ApplySEEByDefault_AES256
=== RUN   TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMS
=== PAUSE TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMS
=== RUN   TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMSDSSE
=== PAUSE TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMSDSSE
=== RUN   TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_UpdateSSEAlgorithm
=== PAUSE TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_UpdateSSEAlgorithm
=== RUN   TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMSWithMasterKeyARN
=== PAUSE TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMSWithMasterKeyARN
=== RUN   TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMSWithMasterKeyID
=== PAUSE TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMSWithMasterKeyID
=== RUN   TestAccS3BucketServerSideEncryptionConfiguration_BucketKeyEnabled
=== PAUSE TestAccS3BucketServerSideEncryptionConfiguration_BucketKeyEnabled
=== RUN   TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_BucketKeyEnabled
=== PAUSE TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_BucketKeyEnabled
=== RUN   TestAccS3BucketServerSideEncryptionConfiguration_migrate_noChange
=== PAUSE TestAccS3BucketServerSideEncryptionConfiguration_migrate_noChange
=== RUN   TestAccS3BucketServerSideEncryptionConfiguration_migrate_withChange
=== PAUSE TestAccS3BucketServerSideEncryptionConfiguration_migrate_withChange
=== CONT  TestAccS3BucketServerSideEncryptionConfiguration_basic
=== CONT  TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMSWithMasterKeyID
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMSWithMasterKeyID (47.24s)
=== CONT  TestAccS3BucketServerSideEncryptionConfiguration_migrate_noChange
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_basic (47.35s)
=== CONT  TestAccS3BucketServerSideEncryptionConfiguration_migrate_withChange
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_migrate_withChange (104.71s)
=== CONT  TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_BucketKeyEnabled
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_migrate_noChange (105.20s)
=== CONT  TestAccS3BucketServerSideEncryptionConfiguration_BucketKeyEnabled
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_BucketKeyEnabled (119.03s)
=== CONT  TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMSDSSE
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_BucketKeyEnabled (119.48s)
=== CONT  TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMSWithMasterKeyARN
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMSDSSE (46.11s)
=== CONT  TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_UpdateSSEAlgorithm
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMSWithMasterKeyARN (45.31s)
=== CONT  TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMS
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMS (45.81s)
=== CONT  TestAccS3BucketServerSideEncryptionConfiguration_ApplySEEByDefault_AES256
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_UpdateSSEAlgorithm (67.57s)
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_ApplySEEByDefault_AES256 (44.91s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	412.898s
% make testacc TESTARGS='-run=TestAccS3BucketCORSConfiguration_' PKG=s3 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 3  -run=TestAccS3BucketCORSConfiguration_ -timeout 180m
=== RUN   TestAccS3BucketCORSConfiguration_basic
=== PAUSE TestAccS3BucketCORSConfiguration_basic
=== RUN   TestAccS3BucketCORSConfiguration_disappears
=== PAUSE TestAccS3BucketCORSConfiguration_disappears
=== RUN   TestAccS3BucketCORSConfiguration_update
=== PAUSE TestAccS3BucketCORSConfiguration_update
=== RUN   TestAccS3BucketCORSConfiguration_SingleRule
=== PAUSE TestAccS3BucketCORSConfiguration_SingleRule
=== RUN   TestAccS3BucketCORSConfiguration_MultipleRules
=== PAUSE TestAccS3BucketCORSConfiguration_MultipleRules
=== RUN   TestAccS3BucketCORSConfiguration_migrate_corsRuleNoChange
=== PAUSE TestAccS3BucketCORSConfiguration_migrate_corsRuleNoChange
=== RUN   TestAccS3BucketCORSConfiguration_migrate_corsRuleWithChange
=== PAUSE TestAccS3BucketCORSConfiguration_migrate_corsRuleWithChange
=== CONT  TestAccS3BucketCORSConfiguration_MultipleRules
=== CONT  TestAccS3BucketCORSConfiguration_update
=== CONT  TestAccS3BucketCORSConfiguration_basic
--- PASS: TestAccS3BucketCORSConfiguration_basic (50.94s)
=== CONT  TestAccS3BucketCORSConfiguration_SingleRule
--- PASS: TestAccS3BucketCORSConfiguration_MultipleRules (51.01s)
=== CONT  TestAccS3BucketCORSConfiguration_migrate_corsRuleWithChange
--- PASS: TestAccS3BucketCORSConfiguration_update (92.05s)
=== CONT  TestAccS3BucketCORSConfiguration_migrate_corsRuleNoChange
--- PASS: TestAccS3BucketCORSConfiguration_SingleRule (48.04s)
=== CONT  TestAccS3BucketCORSConfiguration_disappears
--- PASS: TestAccS3BucketCORSConfiguration_migrate_corsRuleWithChange (64.23s)
--- PASS: TestAccS3BucketCORSConfiguration_disappears (26.26s)
--- PASS: TestAccS3BucketCORSConfiguration_migrate_corsRuleNoChange (61.04s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	158.366s
@ewbankkit ewbankkit changed the title [WIP] r/aws_s3_bucket_website_configuration et al.: Migrate to AWS SDK for Go v2 r/aws_s3_bucket_website_configuration et al.: Migrate to AWS SDK for Go v2 Sep 21, 2023
@ewbankkit
Copy link
Contributor Author

% make testacc TESTARGS='-run=TestAccS3BucketWebsiteConfiguration_\|TestAccS3BucketWebsiteConfiguration_\|TestAccS3BucketAnalyticsConfiguration_\|TestAccS3BucketServerSideEncryptionConfiguration_\|TestAccS3BucketACL_\|TestAccS3BucketAccelerateConfiguration_\|TestAccS3BucketVersioning_\|TestAccS3BucketCORSConfiguration_' PKG=s3 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 3  -run=TestAccS3BucketWebsiteConfiguration_\|TestAccS3BucketWebsiteConfiguration_\|TestAccS3BucketAnalyticsConfiguration_\|TestAccS3BucketServerSideEncryptionConfiguration_\|TestAccS3BucketACL_\|TestAccS3BucketAccelerateConfiguration_\|TestAccS3BucketVersioning_\|TestAccS3BucketCORSConfiguration_ -timeout 180m
=== RUN   TestAccS3BucketAccelerateConfiguration_basic
=== PAUSE TestAccS3BucketAccelerateConfiguration_basic
=== RUN   TestAccS3BucketAccelerateConfiguration_update
=== PAUSE TestAccS3BucketAccelerateConfiguration_update
=== RUN   TestAccS3BucketAccelerateConfiguration_disappears
=== PAUSE TestAccS3BucketAccelerateConfiguration_disappears
=== RUN   TestAccS3BucketAccelerateConfiguration_migrate_noChange
=== PAUSE TestAccS3BucketAccelerateConfiguration_migrate_noChange
=== RUN   TestAccS3BucketAccelerateConfiguration_migrate_withChange
=== PAUSE TestAccS3BucketAccelerateConfiguration_migrate_withChange
=== RUN   TestAccS3BucketACL_basic
=== PAUSE TestAccS3BucketACL_basic
=== RUN   TestAccS3BucketACL_disappears
=== PAUSE TestAccS3BucketACL_disappears
=== RUN   TestAccS3BucketACL_migrate_aclNoChange
=== PAUSE TestAccS3BucketACL_migrate_aclNoChange
=== RUN   TestAccS3BucketACL_migrate_aclWithChange
=== PAUSE TestAccS3BucketACL_migrate_aclWithChange
=== RUN   TestAccS3BucketACL_migrate_grantsWithChange
=== PAUSE TestAccS3BucketACL_migrate_grantsWithChange
=== RUN   TestAccS3BucketACL_updateACL
=== PAUSE TestAccS3BucketACL_updateACL
=== RUN   TestAccS3BucketACL_updateGrant
=== PAUSE TestAccS3BucketACL_updateGrant
=== RUN   TestAccS3BucketACL_ACLToGrant
=== PAUSE TestAccS3BucketACL_ACLToGrant
=== RUN   TestAccS3BucketACL_grantToACL
=== PAUSE TestAccS3BucketACL_grantToACL
=== RUN   TestAccS3BucketAnalyticsConfiguration_basic
=== PAUSE TestAccS3BucketAnalyticsConfiguration_basic
=== RUN   TestAccS3BucketAnalyticsConfiguration_disappears
=== PAUSE TestAccS3BucketAnalyticsConfiguration_disappears
=== RUN   TestAccS3BucketAnalyticsConfiguration_updateBasic
=== PAUSE TestAccS3BucketAnalyticsConfiguration_updateBasic
=== RUN   TestAccS3BucketAnalyticsConfiguration_WithFilter_empty
=== PAUSE TestAccS3BucketAnalyticsConfiguration_WithFilter_empty
=== RUN   TestAccS3BucketAnalyticsConfiguration_WithFilter_prefix
=== PAUSE TestAccS3BucketAnalyticsConfiguration_WithFilter_prefix
=== RUN   TestAccS3BucketAnalyticsConfiguration_WithFilter_singleTag
=== PAUSE TestAccS3BucketAnalyticsConfiguration_WithFilter_singleTag
=== RUN   TestAccS3BucketAnalyticsConfiguration_WithFilter_multipleTags
=== PAUSE TestAccS3BucketAnalyticsConfiguration_WithFilter_multipleTags
=== RUN   TestAccS3BucketAnalyticsConfiguration_WithFilter_prefixAndTags
=== PAUSE TestAccS3BucketAnalyticsConfiguration_WithFilter_prefixAndTags
=== RUN   TestAccS3BucketAnalyticsConfiguration_WithFilter_remove
=== PAUSE TestAccS3BucketAnalyticsConfiguration_WithFilter_remove
=== RUN   TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_empty
=== PAUSE TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_empty
=== RUN   TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_default
=== PAUSE TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_default
=== RUN   TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_full
=== PAUSE TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_full
=== RUN   TestAccS3BucketCORSConfiguration_basic
=== PAUSE TestAccS3BucketCORSConfiguration_basic
=== RUN   TestAccS3BucketCORSConfiguration_disappears
=== PAUSE TestAccS3BucketCORSConfiguration_disappears
=== RUN   TestAccS3BucketCORSConfiguration_update
=== PAUSE TestAccS3BucketCORSConfiguration_update
=== RUN   TestAccS3BucketCORSConfiguration_SingleRule
=== PAUSE TestAccS3BucketCORSConfiguration_SingleRule
=== RUN   TestAccS3BucketCORSConfiguration_MultipleRules
=== PAUSE TestAccS3BucketCORSConfiguration_MultipleRules
=== RUN   TestAccS3BucketCORSConfiguration_migrate_corsRuleNoChange
=== PAUSE TestAccS3BucketCORSConfiguration_migrate_corsRuleNoChange
=== RUN   TestAccS3BucketCORSConfiguration_migrate_corsRuleWithChange
=== PAUSE TestAccS3BucketCORSConfiguration_migrate_corsRuleWithChange
=== RUN   TestAccS3BucketServerSideEncryptionConfiguration_basic
=== PAUSE TestAccS3BucketServerSideEncryptionConfiguration_basic
=== RUN   TestAccS3BucketServerSideEncryptionConfiguration_ApplySEEByDefault_AES256
=== PAUSE TestAccS3BucketServerSideEncryptionConfiguration_ApplySEEByDefault_AES256
=== RUN   TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMS
=== PAUSE TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMS
=== RUN   TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMSDSSE
=== PAUSE TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMSDSSE
=== RUN   TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_UpdateSSEAlgorithm
=== PAUSE TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_UpdateSSEAlgorithm
=== RUN   TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMSWithMasterKeyARN
=== PAUSE TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMSWithMasterKeyARN
=== RUN   TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMSWithMasterKeyID
=== PAUSE TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMSWithMasterKeyID
=== RUN   TestAccS3BucketServerSideEncryptionConfiguration_BucketKeyEnabled
=== PAUSE TestAccS3BucketServerSideEncryptionConfiguration_BucketKeyEnabled
=== RUN   TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_BucketKeyEnabled
=== PAUSE TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_BucketKeyEnabled
=== RUN   TestAccS3BucketServerSideEncryptionConfiguration_migrate_noChange
=== PAUSE TestAccS3BucketServerSideEncryptionConfiguration_migrate_noChange
=== RUN   TestAccS3BucketServerSideEncryptionConfiguration_migrate_withChange
=== PAUSE TestAccS3BucketServerSideEncryptionConfiguration_migrate_withChange
=== RUN   TestAccS3BucketVersioning_basic
=== PAUSE TestAccS3BucketVersioning_basic
=== RUN   TestAccS3BucketVersioning_disappears
=== PAUSE TestAccS3BucketVersioning_disappears
=== RUN   TestAccS3BucketVersioning_disappears_bucket
=== PAUSE TestAccS3BucketVersioning_disappears_bucket
=== RUN   TestAccS3BucketVersioning_update
=== PAUSE TestAccS3BucketVersioning_update
=== RUN   TestAccS3BucketVersioning_MFADelete
=== PAUSE TestAccS3BucketVersioning_MFADelete
=== RUN   TestAccS3BucketVersioning_migrate_versioningDisabledNoChange
=== PAUSE TestAccS3BucketVersioning_migrate_versioningDisabledNoChange
=== RUN   TestAccS3BucketVersioning_migrate_versioningDisabledWithChange
=== PAUSE TestAccS3BucketVersioning_migrate_versioningDisabledWithChange
=== RUN   TestAccS3BucketVersioning_migrate_versioningEnabledNoChange
=== PAUSE TestAccS3BucketVersioning_migrate_versioningEnabledNoChange
=== RUN   TestAccS3BucketVersioning_migrate_versioningEnabledWithChange
=== PAUSE TestAccS3BucketVersioning_migrate_versioningEnabledWithChange
=== RUN   TestAccS3BucketVersioning_migrate_mfaDeleteNoChange
=== PAUSE TestAccS3BucketVersioning_migrate_mfaDeleteNoChange
=== RUN   TestAccS3BucketVersioning_Status_disabled
=== PAUSE TestAccS3BucketVersioning_Status_disabled
=== RUN   TestAccS3BucketVersioning_Status_disabledToEnabled
=== PAUSE TestAccS3BucketVersioning_Status_disabledToEnabled
=== RUN   TestAccS3BucketVersioning_Status_disabledToSuspended
=== PAUSE TestAccS3BucketVersioning_Status_disabledToSuspended
=== RUN   TestAccS3BucketVersioning_Status_enabledToDisabled
=== PAUSE TestAccS3BucketVersioning_Status_enabledToDisabled
=== RUN   TestAccS3BucketVersioning_Status_suspendedToDisabled
=== PAUSE TestAccS3BucketVersioning_Status_suspendedToDisabled
=== RUN   TestAccS3BucketWebsiteConfiguration_basic
=== PAUSE TestAccS3BucketWebsiteConfiguration_basic
=== RUN   TestAccS3BucketWebsiteConfiguration_disappears
=== PAUSE TestAccS3BucketWebsiteConfiguration_disappears
=== RUN   TestAccS3BucketWebsiteConfiguration_update
=== PAUSE TestAccS3BucketWebsiteConfiguration_update
=== RUN   TestAccS3BucketWebsiteConfiguration_Redirect
=== PAUSE TestAccS3BucketWebsiteConfiguration_Redirect
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRule_ConditionAndRedirect
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRule_ConditionAndRedirect
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRule_MultipleRules
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRule_MultipleRules
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRule_RedirectOnly
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRule_RedirectOnly
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirect
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirect
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirectWithEmptyString
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirectWithEmptyString
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRules_updateConditionAndRedirect
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRules_updateConditionAndRedirect
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRuleToRoutingRules
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRuleToRoutingRules
=== RUN   TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentNoChange
=== PAUSE TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentNoChange
=== RUN   TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentWithChange
=== PAUSE TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentWithChange
=== RUN   TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleNoChange
=== PAUSE TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleNoChange
=== RUN   TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleWithChange
=== PAUSE TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleWithChange
=== CONT  TestAccS3BucketAccelerateConfiguration_basic
=== CONT  TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_UpdateSSEAlgorithm
=== CONT  TestAccS3BucketAnalyticsConfiguration_WithFilter_singleTag
--- PASS: TestAccS3BucketAccelerateConfiguration_basic (51.05s)
=== CONT  TestAccS3BucketCORSConfiguration_update
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_singleTag (69.40s)
=== CONT  TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMSDSSE
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_UpdateSSEAlgorithm (72.87s)
=== CONT  TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMS
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMSDSSE (45.80s)
=== CONT  TestAccS3BucketServerSideEncryptionConfiguration_ApplySEEByDefault_AES256
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMS (45.54s)
=== CONT  TestAccS3BucketServerSideEncryptionConfiguration_basic
--- PASS: TestAccS3BucketCORSConfiguration_update (85.34s)
=== CONT  TestAccS3BucketCORSConfiguration_migrate_corsRuleWithChange
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_ApplySEEByDefault_AES256 (46.68s)
=== CONT  TestAccS3BucketCORSConfiguration_migrate_corsRuleNoChange
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_basic (46.03s)
=== CONT  TestAccS3BucketCORSConfiguration_MultipleRules
--- PASS: TestAccS3BucketCORSConfiguration_migrate_corsRuleWithChange (66.38s)
=== CONT  TestAccS3BucketCORSConfiguration_SingleRule
--- PASS: TestAccS3BucketCORSConfiguration_MultipleRules (50.19s)
=== CONT  TestAccS3BucketACL_updateACL
--- PASS: TestAccS3BucketCORSConfiguration_migrate_corsRuleNoChange (65.98s)
=== CONT  TestAccS3BucketAnalyticsConfiguration_WithFilter_prefix
--- PASS: TestAccS3BucketCORSConfiguration_SingleRule (47.17s)
=== CONT  TestAccS3BucketAnalyticsConfiguration_WithFilter_empty
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_empty (2.25s)
=== CONT  TestAccS3BucketAnalyticsConfiguration_updateBasic
--- PASS: TestAccS3BucketACL_updateACL (54.92s)
=== CONT  TestAccS3BucketAnalyticsConfiguration_disappears
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_prefix (52.66s)
=== CONT  TestAccS3BucketAnalyticsConfiguration_basic
--- PASS: TestAccS3BucketAnalyticsConfiguration_disappears (27.55s)
=== CONT  TestAccS3BucketACL_grantToACL
--- PASS: TestAccS3BucketAnalyticsConfiguration_basic (46.99s)
=== CONT  TestAccS3BucketACL_ACLToGrant
--- PASS: TestAccS3BucketAnalyticsConfiguration_updateBasic (93.31s)
=== CONT  TestAccS3BucketVersioning_Status_disabledToEnabled
--- PASS: TestAccS3BucketACL_grantToACL (54.30s)
=== CONT  TestAccS3BucketVersioning_Status_disabled
--- PASS: TestAccS3BucketACL_ACLToGrant (53.53s)
=== CONT  TestAccS3BucketVersioning_migrate_mfaDeleteNoChange
--- PASS: TestAccS3BucketVersioning_Status_disabled (33.88s)
=== CONT  TestAccS3BucketVersioning_Status_disabledToSuspended
--- PASS: TestAccS3BucketVersioning_Status_disabledToEnabled (76.83s)
=== CONT  TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleWithChange
--- PASS: TestAccS3BucketVersioning_migrate_mfaDeleteNoChange (67.29s)
=== CONT  TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleNoChange
--- PASS: TestAccS3BucketVersioning_Status_disabledToSuspended (76.72s)
=== CONT  TestAccS3BucketACL_updateGrant
--- PASS: TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleWithChange (47.70s)
=== CONT  TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentWithChange
--- PASS: TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleNoChange (65.87s)
=== CONT  TestAccS3BucketACL_basic
--- PASS: TestAccS3BucketACL_updateGrant (61.63s)
=== CONT  TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentNoChange
--- PASS: TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentWithChange (66.43s)
=== CONT  TestAccS3BucketACL_migrate_grantsWithChange
--- PASS: TestAccS3BucketACL_basic (32.26s)
=== CONT  TestAccS3BucketVersioning_migrate_versioningEnabledWithChange
--- PASS: TestAccS3BucketACL_migrate_grantsWithChange (51.43s)
=== CONT  TestAccS3BucketACL_migrate_aclWithChange
--- PASS: TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentNoChange (65.65s)
=== CONT  TestAccS3BucketACL_migrate_aclNoChange
--- PASS: TestAccS3BucketVersioning_migrate_versioningEnabledWithChange (67.25s)
=== CONT  TestAccS3BucketVersioning_migrate_versioningEnabledNoChange
--- PASS: TestAccS3BucketACL_migrate_aclWithChange (48.73s)
=== CONT  TestAccS3BucketACL_disappears
--- PASS: TestAccS3BucketACL_migrate_aclNoChange (47.94s)
=== CONT  TestAccS3BucketVersioning_migrate_versioningDisabledWithChange
--- PASS: TestAccS3BucketACL_disappears (39.39s)
=== CONT  TestAccS3BucketVersioning_migrate_versioningDisabledNoChange
--- PASS: TestAccS3BucketVersioning_migrate_versioningEnabledNoChange (66.26s)
=== CONT  TestAccS3BucketVersioning_MFADelete
--- PASS: TestAccS3BucketVersioning_migrate_versioningDisabledWithChange (66.10s)
=== CONT  TestAccS3BucketVersioning_update
--- PASS: TestAccS3BucketVersioning_migrate_versioningDisabledNoChange (48.49s)
=== CONT  TestAccS3BucketVersioning_disappears_bucket
--- PASS: TestAccS3BucketVersioning_MFADelete (51.45s)
=== CONT  TestAccS3BucketVersioning_disappears
--- PASS: TestAccS3BucketVersioning_disappears_bucket (42.73s)
=== CONT  TestAccS3BucketVersioning_basic
--- PASS: TestAccS3BucketVersioning_disappears (46.41s)
=== CONT  TestAccS3BucketServerSideEncryptionConfiguration_migrate_withChange
--- PASS: TestAccS3BucketVersioning_update (84.64s)
=== CONT  TestAccS3BucketServerSideEncryptionConfiguration_migrate_noChange
--- PASS: TestAccS3BucketVersioning_basic (51.77s)
=== CONT  TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_BucketKeyEnabled
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_migrate_withChange (65.13s)
=== CONT  TestAccS3BucketServerSideEncryptionConfiguration_BucketKeyEnabled
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_migrate_noChange (63.15s)
=== CONT  TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMSWithMasterKeyID
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_BucketKeyEnabled (70.63s)
=== CONT  TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMSWithMasterKeyARN
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMSWithMasterKeyID (46.07s)
=== CONT  TestAccS3BucketAnalyticsConfiguration_WithFilter_remove
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_BucketKeyEnabled (69.58s)
=== CONT  TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_empty
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_empty (2.11s)
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRule_ConditionAndRedirect
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMSWithMasterKeyARN (44.97s)
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRules_updateConditionAndRedirect
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_remove (65.27s)
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirectWithEmptyString
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_updateConditionAndRedirect (63.88s)
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirect
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirectWithEmptyString (46.14s)
=== CONT  TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_default
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRule_ConditionAndRedirect (114.65s)
=== CONT  TestAccS3BucketCORSConfiguration_disappears
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirect (46.08s)
=== CONT  TestAccS3BucketCORSConfiguration_basic
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_default (46.46s)
=== CONT  TestAccS3BucketAnalyticsConfiguration_WithFilter_prefixAndTags
--- PASS: TestAccS3BucketCORSConfiguration_disappears (26.33s)
=== CONT  TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_full
--- PASS: TestAccS3BucketCORSConfiguration_basic (46.95s)
=== CONT  TestAccS3BucketWebsiteConfiguration_disappears
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_full (46.88s)
=== CONT  TestAccS3BucketWebsiteConfiguration_Redirect
--- PASS: TestAccS3BucketWebsiteConfiguration_disappears (26.01s)
=== CONT  TestAccS3BucketWebsiteConfiguration_update
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_prefixAndTags (67.58s)
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRule_RedirectOnly
--- PASS: TestAccS3BucketWebsiteConfiguration_Redirect (30.83s)
=== CONT  TestAccS3BucketAccelerateConfiguration_migrate_withChange
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRule_RedirectOnly (47.22s)
=== CONT  TestAccS3BucketAccelerateConfiguration_migrate_noChange
--- PASS: TestAccS3BucketWebsiteConfiguration_update (66.76s)
=== CONT  TestAccS3BucketAccelerateConfiguration_disappears
--- PASS: TestAccS3BucketAccelerateConfiguration_migrate_withChange (66.97s)
=== CONT  TestAccS3BucketVersioning_Status_suspendedToDisabled
--- PASS: TestAccS3BucketAccelerateConfiguration_disappears (33.52s)
=== CONT  TestAccS3BucketWebsiteConfiguration_basic
--- PASS: TestAccS3BucketAccelerateConfiguration_migrate_noChange (69.73s)
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRule_MultipleRules
--- PASS: TestAccS3BucketVersioning_Status_suspendedToDisabled (51.56s)
=== CONT  TestAccS3BucketAccelerateConfiguration_update
--- PASS: TestAccS3BucketWebsiteConfiguration_basic (45.73s)
=== CONT  TestAccS3BucketAnalyticsConfiguration_WithFilter_multipleTags
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRule_MultipleRules (68.33s)
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRuleToRoutingRules
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_multipleTags (50.37s)
=== CONT  TestAccS3BucketVersioning_Status_enabledToDisabled
--- PASS: TestAccS3BucketAccelerateConfiguration_update (69.13s)
--- PASS: TestAccS3BucketVersioning_Status_enabledToDisabled (50.53s)
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRuleToRoutingRules (61.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	1374.172s

Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

% make testacc TESTARGS='-run=TestAccS3BucketWebsiteConfiguration_\|TestAccS3BucketWebsiteConfiguration_\|TestAccS3BucketAnalyticsConfiguration_\|TestAccS3BucketServerSideEncryptionConfiguration_\|TestAccS3BucketACL_\|TestAccS3BucketAccelerateConfiguration_\|TestAccS3BucketVer
sioning_\|TestAccS3BucketCORSConfiguration_' PKG=s3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20  -run=TestAccS3BucketWebsiteConfiguration_\|TestAccS3BucketWebsiteConfiguration_\|TestAccS3BucketAnalyticsConfiguration_\|TestAccS3BucketServerSideEncryptionConfiguration_\|TestAccS3BucketACL_\|TestAccS3BucketA
ccelerateConfiguration_\|TestAccS3BucketVersioning_\|TestAccS3BucketCORSConfiguration_ -timeout 180m

--- PASS: TestAccS3BucketAccelerateConfiguration_basic (58.56s)
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRules_updateConditionAndRedirect
--- PASS: TestAccS3BucketWebsiteConfiguration_disappears (58.83s)
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirectWithEmptyString
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRule_RedirectOnly (59.41s)
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirect
--- PASS: TestAccS3BucketVersioning_Status_disabled (60.00s)
=== CONT  TestAccS3BucketAnalyticsConfiguration_WithFilter_singleTag
--- PASS: TestAccS3BucketVersioning_Status_suspendedToDisabled (67.39s)
=== CONT  TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMSDSSE
--- PASS: TestAccS3BucketWebsiteConfiguration_basic (67.50s)
=== CONT  TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMS
--- PASS: TestAccS3BucketWebsiteConfiguration_Redirect (67.70s)
=== CONT  TestAccS3BucketServerSideEncryptionConfiguration_ApplySEEByDefault_AES256
--- PASS: TestAccS3BucketVersioning_disappears_bucket (69.85s)
=== CONT  TestAccS3BucketServerSideEncryptionConfiguration_basic
--- PASS: TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleNoChange (94.87s)
=== CONT  TestAccS3BucketCORSConfiguration_migrate_corsRuleWithChange
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRuleToRoutingRules (94.88s)
=== CONT  TestAccS3BucketCORSConfiguration_migrate_corsRuleNoChange
--- PASS: TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleWithChange (103.42s)
=== CONT  TestAccS3BucketCORSConfiguration_MultipleRules
--- PASS: TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentWithChange (104.30s)
=== CONT  TestAccS3BucketCORSConfiguration_SingleRule
--- PASS: TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentNoChange (104.32s)
=== CONT  TestAccS3BucketCORSConfiguration_update
--- PASS: TestAccS3BucketVersioning_Status_disabledToSuspended (107.48s)
=== CONT  TestAccS3BucketCORSConfiguration_disappears
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRule_MultipleRules (111.31s)
=== CONT  TestAccS3BucketCORSConfiguration_basic
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_UpdateSSEAlgorithm (112.47s)
=== CONT  TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_full
--- PASS: TestAccS3BucketWebsiteConfiguration_update (112.92s)
=== CONT  TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_default
--- PASS: TestAccS3BucketVersioning_Status_disabledToEnabled (114.41s)
=== CONT  TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_empty
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_empty (3.34s)
=== CONT  TestAccS3BucketAnalyticsConfiguration_WithFilter_remove
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirect (62.37s)
=== CONT  TestAccS3BucketAnalyticsConfiguration_WithFilter_prefixAndTags
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirectWithEmptyString (63.31s)
=== CONT  TestAccS3BucketAnalyticsConfiguration_WithFilter_multipleTags
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_ApplySEEByDefault_AES256 (60.60s)
=== CONT  TestAccS3BucketServerSideEncryptionConfiguration_migrate_noChange
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMS (61.44s)
=== CONT  TestAccS3BucketVersioning_disappears
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMSDSSE (61.58s)
=== CONT  TestAccS3BucketVersioning_basic
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_basic (59.31s)
=== CONT  TestAccS3BucketServerSideEncryptionConfiguration_migrate_withChange
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_updateConditionAndRedirect (99.20s)
=== CONT  TestAccS3BucketServerSideEncryptionConfiguration_BucketKeyEnabled
=== CONT  TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_BucketKeyEnabled
--- PASS: TestAccS3BucketCORSConfiguration_disappears (53.87s)
--- PASS: TestAccS3BucketVersioning_update (162.21s)
=== CONT  TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMSWithMasterKeyID
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_singleTag (103.88s)
=== CONT  TestAccS3BucketVersioning_Status_enabledToDisabled
--- PASS: TestAccS3BucketCORSConfiguration_MultipleRules (60.72s)
=== CONT  TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMSWithMasterKeyARN
--- PASS: TestAccS3BucketCORSConfiguration_SingleRule (63.01s)
=== CONT  TestAccS3BucketVersioning_migrate_versioningEnabledNoChange
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_full (59.71s)
=== CONT  TestAccS3BucketVersioning_migrate_versioningDisabledNoChange
--- PASS: TestAccS3BucketCORSConfiguration_basic (61.57s)
=== CONT  TestAccS3BucketVersioning_migrate_versioningDisabledWithChange
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRule_ConditionAndRedirect (173.12s)
=== CONT  TestAccS3BucketVersioning_MFADelete
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_default (62.03s)
=== CONT  TestAccS3BucketVersioning_migrate_versioningEnabledWithChange
--- PASS: TestAccS3BucketVersioning_disappears (56.86s)
=== CONT  TestAccS3BucketACL_updateACL
--- PASS: TestAccS3BucketCORSConfiguration_migrate_corsRuleNoChange (95.79s)
=== CONT  TestAccS3BucketAnalyticsConfiguration_disappears
--- PASS: TestAccS3BucketCORSConfiguration_migrate_corsRuleWithChange (96.18s)
=== CONT  TestAccS3BucketAnalyticsConfiguration_basic
--- PASS: TestAccS3BucketVersioning_basic (63.91s)
=== CONT  TestAccS3BucketAnalyticsConfiguration_WithFilter_prefix
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_remove (101.60s)
=== CONT  TestAccS3BucketACL_grantToACL
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_migrate_noChange (93.20s)
=== CONT  TestAccS3BucketAnalyticsConfiguration_WithFilter_empty
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_prefixAndTags (99.87s)
=== CONT  TestAccS3BucketACL_ACLToGrant
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMSWithMasterKeyID (59.50s)
=== CONT  TestAccS3BucketAnalyticsConfiguration_updateBasic
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMSWithMasterKeyARN (60.48s)
=== CONT  TestAccS3BucketACL_updateGrant
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_migrate_withChange (95.49s)
=== CONT  TestAccS3BucketAccelerateConfiguration_migrate_noChange
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_empty (3.16s)
=== CONT  TestAccS3BucketACL_basic
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_multipleTags (102.84s)
=== CONT  TestAccS3BucketAccelerateConfiguration_migrate_withChange
--- PASS: TestAccS3BucketVersioning_Status_enabledToDisabled (63.89s)
=== CONT  TestAccS3BucketACL_migrate_grantsWithChange
--- PASS: TestAccS3BucketVersioning_MFADelete (65.87s)
=== CONT  TestAccS3BucketACL_disappears
--- PASS: TestAccS3BucketAnalyticsConfiguration_disappears (53.05s)
=== CONT  TestAccS3BucketACL_migrate_aclNoChange
--- PASS: TestAccS3BucketAnalyticsConfiguration_basic (57.96s)
=== CONT  TestAccS3BucketACL_migrate_aclWithChange
=== CONT  TestAccS3BucketAccelerateConfiguration_disappears
--- PASS: TestAccS3BucketCORSConfiguration_update (145.16s)
--- PASS: TestAccS3BucketVersioning_migrate_versioningEnabledNoChange (97.30s)
=== CONT  TestAccS3BucketAccelerateConfiguration_update
--- PASS: TestAccS3BucketVersioning_migrate_versioningDisabledNoChange (93.38s)
=== CONT  TestAccS3BucketVersioning_migrate_mfaDeleteNoChange
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_BucketKeyEnabled (109.84s)
--- PASS: TestAccS3BucketVersioning_migrate_versioningDisabledWithChange (97.55s)
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_BucketKeyEnabled (109.31s)
--- PASS: TestAccS3BucketVersioning_migrate_versioningEnabledWithChange (96.57s)
--- PASS: TestAccS3BucketACL_basic (56.11s)
--- PASS: TestAccS3BucketACL_updateACL (99.29s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_prefix (94.87s)
--- PASS: TestAccS3BucketACL_disappears (53.21s)
--- PASS: TestAccS3BucketAccelerateConfiguration_disappears (46.04s)
--- PASS: TestAccS3BucketAccelerateConfiguration_migrate_noChange (78.80s)
--- PASS: TestAccS3BucketAccelerateConfiguration_migrate_withChange (78.75s)
--- PASS: TestAccS3BucketACL_grantToACL (84.77s)
--- PASS: TestAccS3BucketACL_migrate_grantsWithChange (76.96s)
--- PASS: TestAccS3BucketACL_ACLToGrant (84.69s)
--- PASS: TestAccS3BucketACL_migrate_aclNoChange (65.57s)
--- PASS: TestAccS3BucketACL_updateGrant (87.19s)
--- PASS: TestAccS3BucketACL_migrate_aclWithChange (64.60s)
--- PASS: TestAccS3BucketVersioning_migrate_mfaDeleteNoChange (55.23s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_updateBasic (99.67s)
--- PASS: TestAccS3BucketAccelerateConfiguration_update (58.40s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/s3 326.326s

@ewbankkit ewbankkit added the bug Addresses a defect in current functionality. label Sep 22, 2023
@ewbankkit ewbankkit merged commit 1346c46 into main Sep 22, 2023
53 checks passed
@ewbankkit ewbankkit deleted the f-aws_s3_bucket_website_configuration-aws-sdk-v2 branch September 22, 2023 15:53
@github-actions github-actions bot added this to the v5.19.0 milestone Sep 22, 2023
github-actions bot pushed a commit that referenced this pull request Sep 22, 2023
@github-actions github-actions bot removed the bug Addresses a defect in current functionality. label Sep 26, 2023
@hashicorp hashicorp deleted a comment from github-actions bot Sep 26, 2023
@github-actions
Copy link

This functionality has been released in v5.19.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@el-chazmo
Copy link

I appreciate that this is Merged, but is anyone still having this issue?
I'm on v5.19 But still getting
2023-10-03T00:08:23Z command.go:185: Error: reading Amazon S3 (Simple Storage) Bucket (xxx.xxx.xxx): couldn't find resource

Copy link

github-actions bot commented Nov 3, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2023
@justinretzolk justinretzolk added the aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. label Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/s3 Issues and PRs that pertain to the s3 service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Intermittent failure when creating s3 bucket policy on clean install
4 participants