r/neptune_cluster: fix ignored kms key on snapshot restore #15240.

[triggan]

Description

The KMS Key parameter is presently ignored when restoring a snapshot to a new cluster. Users will use this parameter if they want to change the KMS encryption key of the new cluster to be different than that of the key used by the snapshot. It is also used when a user wants to create a new encrypted cluster from an unencrypted snapshot, per Issue #15240 .

This PR also modifies the existing test for restoring from a snapshot to include the KMS key parameter.

Relations

Closes #15240.
Closes #15303.

References

https://docs.aws.amazon.com/neptune/latest/apiref/API_RestoreDBClusterFromSnapshot.html

Output from Acceptance Testing

$ make testacc TESTS=TestAccNeptuneCluster_restoreFromSnapshot PKG=neptune
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/neptune/... -v -count 1 -parallel 20 -run='TestAccNeptuneCluster_restoreFromSnapshot'  -timeout 180m
=== RUN   TestAccNeptuneCluster_restoreFromSnapshot
=== PAUSE TestAccNeptuneCluster_restoreFromSnapshot
=== CONT  TestAccNeptuneCluster_restoreFromSnapshot
--- PASS: TestAccNeptuneCluster_restoreFromSnapshot (437.43s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/neptune    437.541s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @triggan 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[triggan]

Note also that PR #15303 could potentially be closed with this PR, as it was an earlier attempt to fix this issue and now has many merge conflicts.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccNeptuneCluster_restoreFromSnapshot\|TestAccNeptuneCluster_basic' PKG=neptune ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/neptune/... -v -count 1 -parallel 2  -run=TestAccNeptuneCluster_restoreFromSnapshot\|TestAccNeptuneCluster_basic -timeout 180m
=== RUN   TestAccNeptuneCluster_basic
=== PAUSE TestAccNeptuneCluster_basic
=== RUN   TestAccNeptuneCluster_restoreFromSnapshot
=== PAUSE TestAccNeptuneCluster_restoreFromSnapshot
=== CONT  TestAccNeptuneCluster_basic
=== CONT  TestAccNeptuneCluster_restoreFromSnapshot
--- PASS: TestAccNeptuneCluster_basic (223.12s)
--- PASS: TestAccNeptuneCluster_restoreFromSnapshot (474.22s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/neptune	493.385s

[ewbankkit]

@triggan Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.17.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.