Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: optional name argument in d/aws_ram_resource_share #33153

Closed
Omarimcblack opened this issue Aug 23, 2023 · 3 comments · Fixed by #36062
Closed

[Enhancement]: optional name argument in d/aws_ram_resource_share #33153

Omarimcblack opened this issue Aug 23, 2023 · 3 comments · Fixed by #36062
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ram Issues and PRs that pertain to the ram service.
Milestone

Comments

@Omarimcblack
Copy link
Contributor

Omarimcblack commented Aug 23, 2023

Description

In data source aws_ram_resource_share the argument name is a required parameter.

name - (Required) Name of the resource share to retrieve.

it however is not required by the underlying API

  get-resource-shares
[--resource-share-arns <value>]
[--resource-share-status <value>]
--resource-owner <value>
[--name <value>]
[--tag-filters <value>]
...

If this could function in the same way data source aws_vpc works, where id is an optional input.

id - (Optional) ID of the specific VPC to retrieve.

Affected Resource(s) and/or Data Source(s)

aws_ram_resource_share

Potential Terraform Configuration

name - (Optional) Name of the resource share to retrieve.

References

No response

Would you like to implement a fix?

No

@Omarimcblack Omarimcblack added the enhancement Requests to existing resources that expand the functionality or scope. label Aug 23, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Aug 23, 2023
@ewbankkit ewbankkit added the service/ram Issues and PRs that pertain to the ram service. label Aug 23, 2023
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Aug 23, 2023
@github-actions github-actions bot added this to the v5.41.0 milestone Mar 14, 2024
Copy link

This functionality has been released in v5.41.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ram Issues and PRs that pertain to the ram service.
Projects
None yet
3 participants