Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

medialive/channel: add expand/flatten/docs for InputAttachment.AutomaticInputFailoverSettings. #33129

Conversation

gbw
Copy link
Contributor

@gbw gbw commented Aug 22, 2023

Description

Add missing expand/flatten functions and documentation for AutomaticInputFailoverSettings in InputAttachment.

Relations

N/A

References

InputAttachment documentation

Output from Acceptance Testing

I lack privileges to test this.

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/medialive Issues and PRs that pertain to the medialive service. labels Aug 22, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Aug 22, 2023
@gbw gbw force-pushed the f-add_input_attachment_automatic_input_failover_settings branch 2 times, most recently from c7b86d6 to 54f5397 Compare August 22, 2023 08:42
@gbw gbw force-pushed the f-add_input_attachment_automatic_input_failover_settings branch from 54f5397 to 5bd2de6 Compare August 22, 2023 08:44
@gbw gbw marked this pull request as ready for review August 22, 2023 09:08
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. bug Addresses a defect in current functionality. labels Aug 22, 2023
@johnsonaj johnsonaj self-assigned this Aug 31, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 31, 2023
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

$ make testacc TESTARGS='-run=TestAccMediaLiveChannel_' PKG=medialive

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/medialive/... -v -count 1 -parallel 20  -run=TestAccMediaLiveChannel_ -timeout 180m
--- PASS: TestAccMediaLiveChannel_AudioDescriptions_codecSettings (88.54s)
--- PASS: TestAccMediaLiveChannel_M2TS_settings (98.71s)
--- PASS: TestAccMediaLiveChannel_disappears (118.77s)
--- PASS: TestAccMediaLiveChannel_UDP_outputSettings (125.01s)
--- PASS: TestAccMediaLiveChannel_update (146.33s)
--- PASS: TestAccMediaLiveChannel_VideoDescriptions_CodecSettings_h264Settings (173.98s)
--- PASS: TestAccMediaLiveChannel_hls (204.54s)
--- PASS: TestAccMediaLiveChannel_updateTags (206.85s)
--- PASS: TestAccMediaLiveChannel_MsSmooth_outputSettings (217.70s)
--- PASS: TestAccMediaLiveChannel_basic (228.79s)
--- PASS: TestAccMediaLiveChannel_captionDescriptions (272.79s)
--- PASS: TestAccMediaLiveChannel_VideoDescriptions_CodecSettings_h265Settings (294.62s)
--- PASS: TestAccMediaLiveChannel_status (362.66s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/medialive	366.311s

@johnsonaj
Copy link
Contributor

@gbw thank you for the contribution! 🎉

@johnsonaj johnsonaj merged commit 3764a3c into hashicorp:main Sep 1, 2023
@github-actions github-actions bot added this to the v5.16.0 milestone Sep 1, 2023
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

This functionality has been released in v5.16.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Oct 8, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 8, 2023
@gbw gbw deleted the f-add_input_attachment_automatic_input_failover_settings branch October 21, 2023 22:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/medialive Issues and PRs that pertain to the medialive service. size/L Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants