resource/aws_cloudformation_stack: Sets outputs as Computed when other fields change

[gdavison]

Description

When the output values of an aws_cloudformation_stack change, the outputs attribute is not correctly marked as Computed, so changes are not picked up by dependent resources or Terraform output values. The values in state are correctly updated.

When any configurable, non-ForceNew parameters are changed, now marks the outputs attribute as Computed.

Relations

Closes #32744

Output from Acceptance Testing

% make testacc PKG=cloudformation TESTS=TestAccCloudFormationStack_

--- PASS: TestAccCloudFormationStack_disappears (69.58s)
--- PASS: TestAccCloudFormationStack_yaml (78.66s)
--- PASS: TestAccCloudFormationStack_onFailure (83.11s)
--- PASS: TestAccCloudFormationStack_WithURLWithParams_withYAML (85.38s)
--- PASS: TestAccCloudFormationStack_withTransform (87.62s)
--- PASS: TestAccCloudFormationStack_basic (92.09s)
--- PASS: TestAccCloudFormationStack_updateFailure (93.19s)
--- PASS: TestAccCloudFormationStack_outputsUpdated (93.77s)
--- PASS: TestAccCloudFormationStack_templateUpdate (94.36s)
--- PASS: TestAccCloudFormationStack_allAttributes (101.44s)
--- PASS: TestAccCloudFormationStack_WithURLWithParams_noUpdate (103.51s)
--- PASS: TestAccCloudFormationStack_withParams (119.98s)
--- PASS: TestAccCloudFormationStack_defaultParams (125.39s)
--- PASS: TestAccCloudFormationStack_WithURL_withParams (127.70s)
--- PASS: TestAccCloudFormationStack_CreationFailure_doNothing (194.04s)
--- PASS: TestAccCloudFormationStack_CreationFailure_delete (197.94s)
--- PASS: TestAccCloudFormationStack_CreationFailure_rollback (198.03s)

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccCloudFormationStack_' PKG=cloudformation ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudformation/... -v -count 1 -parallel 3  -run=TestAccCloudFormationStack_ -timeout 180m
=== RUN   TestAccCloudFormationStack_basic
=== PAUSE TestAccCloudFormationStack_basic
=== RUN   TestAccCloudFormationStack_CreationFailure_doNothing
=== PAUSE TestAccCloudFormationStack_CreationFailure_doNothing
=== RUN   TestAccCloudFormationStack_CreationFailure_delete
=== PAUSE TestAccCloudFormationStack_CreationFailure_delete
=== RUN   TestAccCloudFormationStack_CreationFailure_rollback
=== PAUSE TestAccCloudFormationStack_CreationFailure_rollback
=== RUN   TestAccCloudFormationStack_updateFailure
=== PAUSE TestAccCloudFormationStack_updateFailure
=== RUN   TestAccCloudFormationStack_disappears
=== PAUSE TestAccCloudFormationStack_disappears
=== RUN   TestAccCloudFormationStack_yaml
=== PAUSE TestAccCloudFormationStack_yaml
=== RUN   TestAccCloudFormationStack_defaultParams
=== PAUSE TestAccCloudFormationStack_defaultParams
=== RUN   TestAccCloudFormationStack_allAttributes
=== PAUSE TestAccCloudFormationStack_allAttributes
=== RUN   TestAccCloudFormationStack_withParams
=== PAUSE TestAccCloudFormationStack_withParams
=== RUN   TestAccCloudFormationStack_WithURL_withParams
=== PAUSE TestAccCloudFormationStack_WithURL_withParams
=== RUN   TestAccCloudFormationStack_WithURLWithParams_withYAML
=== PAUSE TestAccCloudFormationStack_WithURLWithParams_withYAML
=== RUN   TestAccCloudFormationStack_WithURLWithParams_noUpdate
=== PAUSE TestAccCloudFormationStack_WithURLWithParams_noUpdate
=== RUN   TestAccCloudFormationStack_withTransform
=== PAUSE TestAccCloudFormationStack_withTransform
=== RUN   TestAccCloudFormationStack_onFailure
=== PAUSE TestAccCloudFormationStack_onFailure
=== RUN   TestAccCloudFormationStack_outputsUpdated
=== PAUSE TestAccCloudFormationStack_outputsUpdated
=== RUN   TestAccCloudFormationStack_templateUpdate
=== PAUSE TestAccCloudFormationStack_templateUpdate
=== CONT  TestAccCloudFormationStack_basic
=== CONT  TestAccCloudFormationStack_withParams
=== CONT  TestAccCloudFormationStack_disappears
--- PASS: TestAccCloudFormationStack_disappears (51.25s)
=== CONT  TestAccCloudFormationStack_CreationFailure_rollback
--- PASS: TestAccCloudFormationStack_basic (69.89s)
=== CONT  TestAccCloudFormationStack_updateFailure
--- PASS: TestAccCloudFormationStack_withParams (101.29s)
=== CONT  TestAccCloudFormationStack_defaultParams
--- PASS: TestAccCloudFormationStack_updateFailure (68.68s)
=== CONT  TestAccCloudFormationStack_allAttributes
--- PASS: TestAccCloudFormationStack_defaultParams (101.48s)
=== CONT  TestAccCloudFormationStack_CreationFailure_delete
--- PASS: TestAccCloudFormationStack_allAttributes (72.03s)
=== CONT  TestAccCloudFormationStack_yaml
--- PASS: TestAccCloudFormationStack_CreationFailure_rollback (173.94s)
=== CONT  TestAccCloudFormationStack_CreationFailure_doNothing
--- PASS: TestAccCloudFormationStack_yaml (53.13s)
=== CONT  TestAccCloudFormationStack_withTransform
--- PASS: TestAccCloudFormationStack_withTransform (55.68s)
=== CONT  TestAccCloudFormationStack_templateUpdate
--- PASS: TestAccCloudFormationStack_CreationFailure_delete (163.41s)
=== CONT  TestAccCloudFormationStack_outputsUpdated
--- PASS: TestAccCloudFormationStack_templateUpdate (75.34s)
=== CONT  TestAccCloudFormationStack_onFailure
--- PASS: TestAccCloudFormationStack_CreationFailure_doNothing (172.75s)
=== CONT  TestAccCloudFormationStack_WithURLWithParams_withYAML
--- PASS: TestAccCloudFormationStack_outputsUpdated (77.20s)
=== CONT  TestAccCloudFormationStack_WithURLWithParams_noUpdate
--- PASS: TestAccCloudFormationStack_onFailure (64.18s)
=== CONT  TestAccCloudFormationStack_WithURL_withParams
--- PASS: TestAccCloudFormationStack_WithURLWithParams_withYAML (68.35s)
--- PASS: TestAccCloudFormationStack_WithURLWithParams_noUpdate (93.75s)
--- PASS: TestAccCloudFormationStack_WithURL_withParams (115.71s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudformation	580.335s

[github-actions]

This functionality has been released in v5.13.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.