Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore additional error when deleting fleet #32866

Conversation

erpel
Copy link
Contributor

@erpel erpel commented Aug 4, 2023

Description

This adds another error message from the AWS api to be ignored when trying to delete an AWS EMR Instance Fleet which does not support "delete". Its lifecycle is instead linked to the EMR cluster.

Relations

Closes #31375

References

Output from Acceptance Testing

The acceptance testing failed but I'm fairly certain this is due to the locked down nature of the AWS Accounts that I have access to in my org. I would be very grateful if someone with a known working acceptance testing setup could reproduce this and maybe add their output.
I verified the fix with a cluster setup that was failing for my org using the published provider versions.

% make testacc TESTARGS='-run=TestAccEMRCluster_ebs\|TestAccEMRCluster_basic' PKG=emr ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/emr/... -v -count 1 -parallel 2  -run=TestAccEMRCluster_ebs\|TestAccEMRCluster_basic -timeout 180m
=== RUN   TestAccEMRCluster_basic
=== PAUSE TestAccEMRCluster_basic
=== RUN   TestAccEMRCluster_ebs
=== PAUSE TestAccEMRCluster_ebs
=== CONT  TestAccEMRCluster_basic
=== CONT  TestAccEMRCluster_ebs
    cluster_test.go:1537: Step 1/2 error: Error running apply: exit status 1
        
        Error: running EMR Job Flow: ValidationException: Invalid InstanceProfile: EMR_EC2_DefaultRole.
        	status code: 400, request id: e7786da7-64bd-4280-adf3-6b41ae0028b5
        
          with aws_emr_cluster.test,
          on terraform_plugin_test.tf line 88, in resource "aws_emr_cluster" "test":
          88: resource "aws_emr_cluster" "test" {
        
--- FAIL: TestAccEMRCluster_ebs (189.08s)
--- PASS: TestAccEMRCluster_basic (457.25s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/emr	459.257s
FAIL
make: *** [testacc] Error 1

@github-actions
Copy link

github-actions bot commented Aug 4, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/emr Issues and PRs that pertain to the emr service. needs-triage Waiting for first response or review from a maintainer. labels Aug 4, 2023
@erpel erpel marked this pull request as ready for review August 4, 2023 15:46
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 4, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit
Copy link
Contributor

@erpel Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 4256058 into hashicorp:main Aug 4, 2023
@github-actions github-actions bot added this to the v5.12.0 milestone Aug 4, 2023
@github-actions
Copy link

This functionality has been released in v5.12.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/emr Issues and PRs that pertain to the emr service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
2 participants