-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: surface licencemanager InvalidParameterValueException error #32845
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccLicenseManagerLicenseConfiguration_' PKG=licensemanager ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/licensemanager/... -v -count 1 -parallel 2 -run=TestAccLicenseManagerLicenseConfiguration_ -timeout 180m
=== RUN TestAccLicenseManagerLicenseConfiguration_basic
=== PAUSE TestAccLicenseManagerLicenseConfiguration_basic
=== RUN TestAccLicenseManagerLicenseConfiguration_disappears
=== PAUSE TestAccLicenseManagerLicenseConfiguration_disappears
=== RUN TestAccLicenseManagerLicenseConfiguration_tags
=== PAUSE TestAccLicenseManagerLicenseConfiguration_tags
=== RUN TestAccLicenseManagerLicenseConfiguration_update
=== PAUSE TestAccLicenseManagerLicenseConfiguration_update
=== CONT TestAccLicenseManagerLicenseConfiguration_basic
=== CONT TestAccLicenseManagerLicenseConfiguration_update
--- PASS: TestAccLicenseManagerLicenseConfiguration_basic (47.97s)
=== CONT TestAccLicenseManagerLicenseConfiguration_tags
--- PASS: TestAccLicenseManagerLicenseConfiguration_update (80.92s)
=== CONT TestAccLicenseManagerLicenseConfiguration_disappears
--- PASS: TestAccLicenseManagerLicenseConfiguration_disappears (37.07s)
--- PASS: TestAccLicenseManagerLicenseConfiguration_tags (115.25s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/licensemanager 169.457s
@silvaalbert Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.14.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Fixes bug in which InvalidParameterValueException errors were not surfaced during the destruction of a resource, and the resource was removed from state silently
Relations
Closes #32832
Output from Acceptance Testing