Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_lightsail_key_pair: tags #32606

Merged
merged 6 commits into from
Jul 20, 2023
Merged

r/aws_lightsail_key_pair: tags #32606

merged 6 commits into from
Jul 20, 2023

Conversation

johnsonaj
Copy link
Contributor

@johnsonaj johnsonaj commented Jul 20, 2023

Description

Add tags to resource

Relations

Closes #32522

References

Output from Acceptance Testing

$ make testacc TESTARGS='-run=TestAccLightsailKeyPair_' PKG=lightsail

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 20  -run=TestAccLightsailKeyPair_ -timeout 180m
--- PASS: TestAccLightsailKeyPair_disappears (29.87s)
--- PASS: TestAccLightsailKeyPair_encrypted (32.25s)
--- PASS: TestAccLightsailKeyPair_publicKey (33.22s)
--- PASS: TestAccLightsailKeyPair_basic (33.37s)
--- PASS: TestAccLightsailKeyPair_namePrefix (33.80s)
--- PASS: TestAccLightsailKeyPair_tags (60.10s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lightsail	63.406s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/lightsail Issues and PRs that pertain to the lightsail service. tags Pertains to resource tagging. generators Relates to code generators. labels Jul 20, 2023
@johnsonaj johnsonaj added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 20, 2023
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Jul 20, 2023
@johnsonaj johnsonaj marked this pull request as ready for review July 20, 2023 00:37
@johnsonaj johnsonaj force-pushed the f-aws_lightsail_key_pair-tags branch from 0e38828 to ed72227 Compare July 20, 2023 00:39
@ewbankkit ewbankkit self-requested a review July 20, 2023 13:26
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccLightsailKeyPair_' PKG=lightsail ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 2  -run=TestAccLightsailKeyPair_ -timeout 180m
=== RUN   TestAccLightsailKeyPair_basic
=== PAUSE TestAccLightsailKeyPair_basic
=== RUN   TestAccLightsailKeyPair_publicKey
=== PAUSE TestAccLightsailKeyPair_publicKey
=== RUN   TestAccLightsailKeyPair_encrypted
=== PAUSE TestAccLightsailKeyPair_encrypted
=== RUN   TestAccLightsailKeyPair_namePrefix
=== PAUSE TestAccLightsailKeyPair_namePrefix
=== RUN   TestAccLightsailKeyPair_tags
=== PAUSE TestAccLightsailKeyPair_tags
=== RUN   TestAccLightsailKeyPair_disappears
=== PAUSE TestAccLightsailKeyPair_disappears
=== CONT  TestAccLightsailKeyPair_basic
=== CONT  TestAccLightsailKeyPair_namePrefix
--- PASS: TestAccLightsailKeyPair_basic (36.59s)
=== CONT  TestAccLightsailKeyPair_encrypted
--- PASS: TestAccLightsailKeyPair_namePrefix (37.65s)
=== CONT  TestAccLightsailKeyPair_publicKey
--- PASS: TestAccLightsailKeyPair_encrypted (36.86s)
=== CONT  TestAccLightsailKeyPair_disappears
--- PASS: TestAccLightsailKeyPair_publicKey (36.62s)
=== CONT  TestAccLightsailKeyPair_tags
--- PASS: TestAccLightsailKeyPair_disappears (34.56s)
--- PASS: TestAccLightsailKeyPair_tags (76.41s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lightsail	156.369s

@ewbankkit
Copy link
Contributor

Needs a CHANGELOG entry.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@johnsonaj johnsonaj merged commit 86562aa into main Jul 20, 2023
@johnsonaj johnsonaj deleted the f-aws_lightsail_key_pair-tags branch July 20, 2023 15:43
@github-actions github-actions bot added this to the v5.9.0 milestone Jul 20, 2023
github-actions bot pushed a commit that referenced this pull request Jul 20, 2023
@github-actions
Copy link

This functionality has been released in v5.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. generators Relates to code generators. service/lightsail Issues and PRs that pertain to the lightsail service. size/L Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: add option to include tags in aws_lightsail_key_pair
2 participants