Add path object to rewrite on gateway route #32449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
size/L
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome @markitovtr1 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
justinretzolk
added
enhancement
ewbankkit
approved these changes
Jul 19, 2023
There was a problem hiding this comment.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccAppMesh_serial/GatewayRoute' PKG=appmesh
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appmesh/... -v -count 1 -parallel 20 -run=TestAccAppMesh_serial/GatewayRoute -timeout 180m
=== RUN TestAccAppMesh_serial
=== PAUSE TestAccAppMesh_serial
=== CONT TestAccAppMesh_serial
=== RUN TestAccAppMesh_serial/GatewayRoute
=== RUN TestAccAppMesh_serial/GatewayRoute/httpRouteWithPort
=== RUN TestAccAppMesh_serial/GatewayRoute/http2RouteTargetPort
=== RUN TestAccAppMesh_serial/GatewayRoute/dataSourceBasic
=== RUN TestAccAppMesh_serial/GatewayRoute/httpRoute
=== RUN TestAccAppMesh_serial/GatewayRoute/httpRouteTargetPort
=== RUN TestAccAppMesh_serial/GatewayRoute/http2Route
=== RUN TestAccAppMesh_serial/GatewayRoute/http2RouteWithPort
=== RUN TestAccAppMesh_serial/GatewayRoute/http2RouteWithQueryParameter
=== RUN TestAccAppMesh_serial/GatewayRoute/grpcRoute
=== RUN TestAccAppMesh_serial/GatewayRoute/grpcRouteTargetPort
=== RUN TestAccAppMesh_serial/GatewayRoute/tags
=== RUN TestAccAppMesh_serial/GatewayRoute/disappears
=== RUN TestAccAppMesh_serial/GatewayRoute/grpcRouteWithPort
=== RUN TestAccAppMesh_serial/GatewayRoute/httpRouteWithPath
=== RUN TestAccAppMesh_serial/GatewayRoute/basic
--- PASS: TestAccAppMesh_serial (785.23s)
--- PASS: TestAccAppMesh_serial/GatewayRoute (785.23s)
--- PASS: TestAccAppMesh_serial/GatewayRoute/httpRouteWithPort (98.44s)
--- PASS: TestAccAppMesh_serial/GatewayRoute/http2RouteTargetPort (44.66s)
--- PASS: TestAccAppMesh_serial/GatewayRoute/dataSourceBasic (23.13s)
--- PASS: TestAccAppMesh_serial/GatewayRoute/httpRoute (96.82s)
--- PASS: TestAccAppMesh_serial/GatewayRoute/httpRouteTargetPort (43.25s)
--- PASS: TestAccAppMesh_serial/GatewayRoute/http2Route (93.93s)
--- PASS: TestAccAppMesh_serial/GatewayRoute/http2RouteWithPort (94.11s)
--- PASS: TestAccAppMesh_serial/GatewayRoute/http2RouteWithQueryParameter (25.02s)
--- PASS: TestAccAppMesh_serial/GatewayRoute/grpcRoute (43.11s)
--- PASS: TestAccAppMesh_serial/GatewayRoute/grpcRouteTargetPort (45.18s)
--- PASS: TestAccAppMesh_serial/GatewayRoute/tags (61.50s)
--- PASS: TestAccAppMesh_serial/GatewayRoute/disappears (21.65s)
--- PASS: TestAccAppMesh_serial/GatewayRoute/grpcRouteWithPort (43.33s)
--- PASS: TestAccAppMesh_serial/GatewayRoute/httpRouteWithPath (25.44s)
--- PASS: TestAccAppMesh_serial/GatewayRoute/basic (25.66s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/appmesh 790.792s
|
@markitovtr1 Thanks for the contribution 🎉 👏. |
|
This functionality has been released in v5.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds path object to spec > http(2)_route > action > rewrite in the same format as spec documentation.
Relations
Closes #32448
References
Check AWS CLI create-gateway-route documentation
Output from Acceptance Testing