-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource/aws_ssm_parameter: Ignore Update if only overwrite
parameter changes
#32372
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccSSMParameter_' PKG=ssm ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ssm/... -v -count 1 -parallel 2 -run=TestAccSSMParameter_ -timeout 180m
=== RUN TestAccSSMParameter_basic
=== PAUSE TestAccSSMParameter_basic
=== RUN TestAccSSMParameter_updateValue
=== PAUSE TestAccSSMParameter_updateValue
=== RUN TestAccSSMParameter_updateDescription
=== PAUSE TestAccSSMParameter_updateDescription
=== RUN TestAccSSMParameter_tier
=== PAUSE TestAccSSMParameter_tier
=== RUN TestAccSSMParameter_Tier_intelligentTieringToStandard
=== PAUSE TestAccSSMParameter_Tier_intelligentTieringToStandard
=== RUN TestAccSSMParameter_Tier_intelligentTieringToAdvanced
=== PAUSE TestAccSSMParameter_Tier_intelligentTieringToAdvanced
=== RUN TestAccSSMParameter_Tier_intelligentTieringOnCreation
=== PAUSE TestAccSSMParameter_Tier_intelligentTieringOnCreation
=== RUN TestAccSSMParameter_Tier_intelligentTieringOnUpdate
=== PAUSE TestAccSSMParameter_Tier_intelligentTieringOnUpdate
=== RUN TestAccSSMParameter_disappears
=== PAUSE TestAccSSMParameter_disappears
=== RUN TestAccSSMParameter_Overwrite_basic
=== PAUSE TestAccSSMParameter_Overwrite_basic
=== RUN TestAccSSMParameter_Overwrite_cascade
=== PAUSE TestAccSSMParameter_Overwrite_cascade
=== RUN TestAccSSMParameter_Overwrite_tags
=== PAUSE TestAccSSMParameter_Overwrite_tags
=== RUN TestAccSSMParameter_Overwrite_noOverwriteTags
=== PAUSE TestAccSSMParameter_Overwrite_noOverwriteTags
=== RUN TestAccSSMParameter_Overwrite_updateToTags
=== PAUSE TestAccSSMParameter_Overwrite_updateToTags
=== RUN TestAccSSMParameter_Overwrite_removeAttribute
=== PAUSE TestAccSSMParameter_Overwrite_removeAttribute
=== RUN TestAccSSMParameter_tags
=== PAUSE TestAccSSMParameter_tags
=== RUN TestAccSSMParameter_updateType
=== PAUSE TestAccSSMParameter_updateType
=== RUN TestAccSSMParameter_Overwrite_updateDescription
=== PAUSE TestAccSSMParameter_Overwrite_updateDescription
=== RUN TestAccSSMParameter_changeNameForcesNew
=== PAUSE TestAccSSMParameter_changeNameForcesNew
=== RUN TestAccSSMParameter_fullPath
=== PAUSE TestAccSSMParameter_fullPath
=== RUN TestAccSSMParameter_Secure_basic
=== PAUSE TestAccSSMParameter_Secure_basic
=== RUN TestAccSSMParameter_Secure_insecure
=== PAUSE TestAccSSMParameter_Secure_insecure
=== RUN TestAccSSMParameter_Secure_insecureChangeSecure
=== PAUSE TestAccSSMParameter_Secure_insecureChangeSecure
=== RUN TestAccSSMParameter_DataType_ec2Image
=== PAUSE TestAccSSMParameter_DataType_ec2Image
=== RUN TestAccSSMParameter_DataType_ssmIntegration
=== PAUSE TestAccSSMParameter_DataType_ssmIntegration
=== RUN TestAccSSMParameter_Secure_key
=== PAUSE TestAccSSMParameter_Secure_key
=== RUN TestAccSSMParameter_Secure_keyUpdate
=== PAUSE TestAccSSMParameter_Secure_keyUpdate
=== CONT TestAccSSMParameter_basic
=== CONT TestAccSSMParameter_Overwrite_removeAttribute
--- PASS: TestAccSSMParameter_Overwrite_removeAttribute (84.88s)
=== CONT TestAccSSMParameter_Tier_intelligentTieringOnUpdate
--- PASS: TestAccSSMParameter_basic (30.94s)
=== CONT TestAccSSMParameter_Overwrite_updateToTags
--- PASS: TestAccSSMParameter_Tier_intelligentTieringOnUpdate (45.15s)
=== CONT TestAccSSMParameter_Overwrite_noOverwriteTags
--- PASS: TestAccSSMParameter_Overwrite_noOverwriteTags (26.89s)
=== CONT TestAccSSMParameter_Overwrite_tags
--- PASS: TestAccSSMParameter_Overwrite_updateToTags (45.76s)
=== CONT TestAccSSMParameter_Overwrite_cascade
--- PASS: TestAccSSMParameter_Overwrite_tags (26.81s)
=== CONT TestAccSSMParameter_Overwrite_basic
--- PASS: TestAccSSMParameter_Overwrite_cascade (56.67s)
=== CONT TestAccSSMParameter_disappears
--- PASS: TestAccSSMParameter_disappears (19.06s)
=== CONT TestAccSSMParameter_Secure_insecure
--- PASS: TestAccSSMParameter_Overwrite_basic (62.69s)
=== CONT TestAccSSMParameter_Secure_keyUpdate
--- PASS: TestAccSSMParameter_Secure_keyUpdate (47.65s)
=== CONT TestAccSSMParameter_Secure_key
--- PASS: TestAccSSMParameter_Secure_insecure (61.61s)
=== CONT TestAccSSMParameter_DataType_ssmIntegration
--- PASS: TestAccSSMParameter_DataType_ssmIntegration (27.97s)
=== CONT TestAccSSMParameter_DataType_ec2Image
--- PASS: TestAccSSMParameter_Secure_key (30.40s)
=== CONT TestAccSSMParameter_Secure_insecureChangeSecure
--- PASS: TestAccSSMParameter_DataType_ec2Image (50.10s)
=== CONT TestAccSSMParameter_changeNameForcesNew
--- PASS: TestAccSSMParameter_Secure_insecureChangeSecure (62.81s)
=== CONT TestAccSSMParameter_Secure_basic
--- PASS: TestAccSSMParameter_Secure_basic (29.54s)
=== CONT TestAccSSMParameter_fullPath
--- PASS: TestAccSSMParameter_changeNameForcesNew (49.67s)
=== CONT TestAccSSMParameter_Tier_intelligentTieringToStandard
--- PASS: TestAccSSMParameter_fullPath (26.31s)
=== CONT TestAccSSMParameter_Tier_intelligentTieringOnCreation
--- PASS: TestAccSSMParameter_Tier_intelligentTieringOnCreation (27.97s)
=== CONT TestAccSSMParameter_Tier_intelligentTieringToAdvanced
--- PASS: TestAccSSMParameter_Tier_intelligentTieringToStandard (63.73s)
=== CONT TestAccSSMParameter_updateType
--- PASS: TestAccSSMParameter_updateType (48.80s)
=== CONT TestAccSSMParameter_Overwrite_updateDescription
--- PASS: TestAccSSMParameter_Tier_intelligentTieringToAdvanced (71.20s)
=== CONT TestAccSSMParameter_updateDescription
--- PASS: TestAccSSMParameter_Overwrite_updateDescription (48.76s)
=== CONT TestAccSSMParameter_tier
--- PASS: TestAccSSMParameter_updateDescription (50.06s)
=== CONT TestAccSSMParameter_tags
--- PASS: TestAccSSMParameter_tier (64.82s)
=== CONT TestAccSSMParameter_updateValue
--- PASS: TestAccSSMParameter_tags (64.53s)
--- PASS: TestAccSSMParameter_updateValue (48.09s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ssm 621.453s
This functionality has been released in v5.7.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Ignores Update if only
overwrite
parameter changes. Prevents the errorwhen removing parameter.
Closes #31655.
Output from Acceptance Testing