fix: add missing 'id' values in pool map (#32106)

[trc-ikeskin]

Description

Add missing values for 'id' attribute for IPAM pools returned by the aws_vpc_ipam_pools data source

Relations

Closes #32106

References

Output from Acceptance Testing

make testacc TESTS=TestAccIPAMPoolsDataSource PKG=ec2
    
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccIPAMPoolsDataSource'  -timeout 180m
    === RUN   TestAccIPAMPoolsDataSource_basic
    === PAUSE TestAccIPAMPoolsDataSource_basic
    === RUN   TestAccIPAMPoolsDataSource_empty
    === PAUSE TestAccIPAMPoolsDataSource_empty
    === CONT  TestAccIPAMPoolsDataSource_basic
    === CONT  TestAccIPAMPoolsDataSource_empty
    --- PASS: TestAccIPAMPoolsDataSource_empty (9.80s)
    --- PASS: TestAccIPAMPoolsDataSource_basic (79.66s)
    PASS
    ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        88.286s

...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @trc-ikeskin 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[trc-ikeskin]

@justinretzolk Any maintainers available to implement this fix?

[justinretzolk]

Hey @trc-ikeskin 👋 Thank you for checking in on this! Unfortunately I can't provide an ETA on when this will be reviewed/merged due to the potential of shifting priorities. We prioritize by count of 👍 reactions and a few other things (more information on our prioritization guide if you're interested).

[drewmullen]

1 Small comment in the changelog but not big enough of a deal to block. Note the website docs already contained id and not the (now removed) ipam_pool_id so no changes required there

Thanks for finding, reporting, and fixing this bug! And thanks for your patience!

$ make testacc TESTS=TestAccIPAMPoolsDataSource PKG=ec2
=== RUN   TestAccIPAMPoolsDataSource_basic
=== PAUSE TestAccIPAMPoolsDataSource_basic
=== RUN   TestAccIPAMPoolsDataSource_empty
=== PAUSE TestAccIPAMPoolsDataSource_empty
=== CONT  TestAccIPAMPoolsDataSource_basic
=== CONT  TestAccIPAMPoolsDataSource_empty
--- PASS: TestAccIPAMPoolsDataSource_empty (20.09s)
--- PASS: TestAccIPAMPoolsDataSource_basic (151.88s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        154.091s

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccIPAMPoolsDataSource_basic' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccIPAMPoolsDataSource_basic -timeout 360m
=== RUN   TestAccIPAMPoolsDataSource_basic
=== PAUSE TestAccIPAMPoolsDataSource_basic
=== CONT  TestAccIPAMPoolsDataSource_basic
--- PASS: TestAccIPAMPoolsDataSource_basic (78.16s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	84.132s

[ewbankkit]

@trc-ikeskin Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.24.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.