-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump go.mod to 1.20 #32108
bump go.mod to 1.20 #32108
Conversation
Community NoteVoting for Prioritization
For Submitters
|
We may need to call out the potentially now unsupported platforms (see https://tip.golang.org/doc/go1.20#ports) in the release notes. Or maybe not. I can't remember how where our internal discussions landed on this. |
In theory we can replace uses of |
In Go 1.20, the math/rand package now automatically seeds the global random number generator with a random value. This makes package level calls to rand.Seed() with a non-deterministic value unnecessary. Additonal details can be found in the Go 1.20 release notes, under the math/rand section: - https://tip.golang.org/doc/go1.20
Do we want to call out the DNS changes -- https://tip.golang.org/doc/go1.20#minor_library_changes -- as they are explicitly mentioned in #30876. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
This functionality has been released in v5.5.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Updates
go.mod
to Go1.20
. Also replaces package-scoped calls torand.Seed()
with randomized values, as Go 1.20 now seeds the global number generator inmath/rand
with a randomized value by default. From the 1.20 release notes:Relations
Relates #32082 (see failed checks).
Closes #30876.