-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement]: add tgw route table in aws_networkmanager_attachment_accepter ✨ #32023
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
make testacc TESTARGS='-run=TestAccNetworkManagerTransitGatewayRouteTableAttachment_basic' PKG=networkmanager ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkmanager/... -v -count 1 -parallel 2 -run=TestAccNetworkManagerTransitGatewayRouteTableAttachment_basic -timeout 180m
=== RUN TestAccNetworkManagerTransitGatewayRouteTableAttachment_basic
=== PAUSE TestAccNetworkManagerTransitGatewayRouteTableAttachment_basic
=== CONT TestAccNetworkManagerTransitGatewayRouteTableAttachment_basic
--- PASS: TestAccNetworkManagerTransitGatewayRouteTableAttachment_basic (1517.11s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager 1522.930s
@b-diggity Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.5.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Adding the ability to accept Transit Gateway Route Table attachments in the
aws_networkmanager_attachment_accepter
resource. Currently, when trying to accept a Transit Gateway Route Table attachment, the following error is thrown:Error: expected attachment_type to be one of [VPC SITE_TO_SITE_VPN CONNECT], got TRANSIT_GATEWAY_ROUTE_TABLE
Relations
Closes #26420 (note: I'm closing this issues since this appears to be the only remaining type not supported by the accepter)
References
https://docs.aws.amazon.com/networkmanager/latest/APIReference/API_ListAttachments.html#API_ListAttachments_RequestSyntax
https://github.com/aws/aws-sdk-go/blob/main/service/networkmanager/api.go#L23525
Output from Acceptance Testing
Note to admins/maintainers: I need help with testing this PR.