-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CREATING_SNAPSHOT status while waiting for MWAA version upgrade #31833
Add CREATING_SNAPSHOT status while waiting for MWAA version upgrade #31833
Conversation
In a successful MWAA version upgrade scenario, the status will show UPDATING, then CREATING_SNAPSHOT as Amazon MWAA captures a backup of metadata. Finally, the status will return first to UPDATING, then to AVAILABLE when the procedure is done.
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @MayurHadole 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
…sion of Apache Airflow forces replacement of the resource.
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% ACCTEST_TIMEOUT=360m make testacc TESTARGS='-run=TestAccMWAAEnvironment_log\|TestAccMWAAEnvironment_pluginsS3ObjectVersion\|TestAccMWAAEnvironment_updateAirflowVersionMinor' PKG=mwaa
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/mwaa/... -v -count 1 -parallel 20 -run=TestAccMWAAEnvironment_log\|TestAccMWAAEnvironment_pluginsS3ObjectVersion\|TestAccMWAAEnvironment_updateAirflowVersionMinor -timeout 360m
=== RUN TestAccMWAAEnvironment_log
=== PAUSE TestAccMWAAEnvironment_log
=== RUN TestAccMWAAEnvironment_pluginsS3ObjectVersion
=== PAUSE TestAccMWAAEnvironment_pluginsS3ObjectVersion
=== RUN TestAccMWAAEnvironment_updateAirflowVersionMinor
=== PAUSE TestAccMWAAEnvironment_updateAirflowVersionMinor
=== CONT TestAccMWAAEnvironment_log
=== CONT TestAccMWAAEnvironment_updateAirflowVersionMinor
=== CONT TestAccMWAAEnvironment_pluginsS3ObjectVersion
--- PASS: TestAccMWAAEnvironment_pluginsS3ObjectVersion (4896.54s)
--- PASS: TestAccMWAAEnvironment_log (5075.34s)
--- PASS: TestAccMWAAEnvironment_updateAirflowVersionMinor (7121.57s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/mwaa 7127.134s
@MayurHadole Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.2.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
MWAA now supports in-place version upgrades.
In a successful MWAA version upgrade scenario, the status will show UPDATING, then CREATING_SNAPSHOT as Amazon MWAA captures a backup of metadata. Finally, the status will return first to UPDATING, then to AVAILABLE when the procedure is done.
This PR adds CREATING_SNAPSHOT status as a valid status along with UPDATING status when waiting for MWAA upgrade
Relations
Closes #31825.
Closes #21640.
References
https://aws.amazon.com/blogs/big-data/introducing-in-place-version-upgrades-with-amazon-mwaa/
https://docs.aws.amazon.com/mwaa/latest/userguide/upgrading-environment.html
Output from Acceptance Testing