Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_dx_connection: Migrate vlan_id from TypeString to TypeInt in state #31735

Merged
merged 4 commits into from
Jun 2, 2023

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Jun 2, 2023

Description

Fixes a regression introduced in v5.1.0.
Migrates vlan_id from TypeString to TypeInt in Terraform state.

Relations

Closes #31732.
Relates #31480.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccDirectConnectConnection_vlanIDMigration\|TestAccDirectConnectConnection_basic' PKG=directconnect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/directconnect/... -v -count 1 -parallel 20  -run=TestAccDirectConnectConnection_vlanIDMigration\|TestAccDirectConnectConnection_basic -timeout 180m
=== RUN   TestAccDirectConnectConnection_basic
=== PAUSE TestAccDirectConnectConnection_basic
=== RUN   TestAccDirectConnectConnection_vlanIDMigration501
=== PAUSE TestAccDirectConnectConnection_vlanIDMigration501
=== RUN   TestAccDirectConnectConnection_vlanIDMigration510
=== PAUSE TestAccDirectConnectConnection_vlanIDMigration510
=== CONT  TestAccDirectConnectConnection_basic
=== CONT  TestAccDirectConnectConnection_vlanIDMigration510
=== CONT  TestAccDirectConnectConnection_vlanIDMigration501
--- PASS: TestAccDirectConnectConnection_basic (28.52s)
--- PASS: TestAccDirectConnectConnection_vlanIDMigration510 (82.28s)
--- PASS: TestAccDirectConnectConnection_vlanIDMigration501 (88.83s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/directconnect	94.114s

@ewbankkit ewbankkit changed the title r/aws_dx_connection: Migrate vlan_id from TypeString to TypeInt in state r/aws_dx_connection: Migrate vlan_id from TypeString to TypeInt in state Jun 2, 2023
@github-actions
Copy link

github-actions bot commented Jun 2, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. service/directconnect Issues and PRs that pertain to the directconnect service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 2, 2023
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. labels Jun 2, 2023
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

$ make testacc TESTARGS='-run=TestAccDirectConnectConnection_vlanIDMigration\|TestAccDirectConnectConnection_basic' PKG=directconnect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/directconnect/... -v -count 1 -parallel 20  -run=TestAccDirectConnectConnection_vlanIDMigration\|TestAccDirectConnectConnection_basic -timeout 180m

--- PASS: TestAccDirectConnectConnection_basic (21.45s)
--- PASS: TestAccDirectConnectConnection_vlanIDMigration510 (41.68s)
--- PASS: TestAccDirectConnectConnection_vlanIDMigration501 (41.68s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/directconnect      45.043s

@ewbankkit ewbankkit merged commit 0e96029 into main Jun 2, 2023
@ewbankkit ewbankkit deleted the b-aws_dx_connection.vlan_id-state branch June 2, 2023 15:00
@github-actions github-actions bot added this to the v5.2.0 milestone Jun 2, 2023
github-actions bot pushed a commit that referenced this pull request Jun 2, 2023
@github-actions
Copy link

github-actions bot commented Jun 9, 2023

This functionality has been released in v5.2.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/directconnect Issues and PRs that pertain to the directconnect service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Existing aws_dx_connection cannot be decoded from state
2 participants