-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New resource: aws_iot_billing_group #31237
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @jmmarko 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
is this fix available now ? |
The PR is waiting for review and to be merged. Please vote above to raise the priority of the PR. Thanks. |
This reverts commit fd4f841.
This reverts commit ad5b5a8.
# Conflicts: # internal/service/iot/service_package_gen.go
% make testacc TESTARGS='-run=TestAccIoTBillingGroup_' PKG=iot ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/iot/... -v -count 1 -parallel 2 -run=TestAccIoTBillingGroup_ -timeout 360m === RUN TestAccIoTBillingGroup_basic === PAUSE TestAccIoTBillingGroup_basic === RUN TestAccIoTBillingGroup_disappears === PAUSE TestAccIoTBillingGroup_disappears === RUN TestAccIoTBillingGroup_tags === PAUSE TestAccIoTBillingGroup_tags === RUN TestAccIoTBillingGroup_properties === PAUSE TestAccIoTBillingGroup_properties === CONT TestAccIoTBillingGroup_basic === CONT TestAccIoTBillingGroup_tags --- PASS: TestAccIoTBillingGroup_basic (24.54s) === CONT TestAccIoTBillingGroup_properties --- PASS: TestAccIoTBillingGroup_tags (57.27s) === CONT TestAccIoTBillingGroup_disappears --- PASS: TestAccIoTBillingGroup_properties (39.06s) --- PASS: TestAccIoTBillingGroup_disappears (16.68s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/iot 79.191s
% make testacc TESTARGS='-run=TestAccIoTEventConfigurations_serial' PKG=iot ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/iot/... -v -count 1 -parallel 20 -run=TestAccIoTEventConfigurations_serial -timeout 360m === RUN TestAccIoTEventConfigurations_serial === PAUSE TestAccIoTEventConfigurations_serial === CONT TestAccIoTEventConfigurations_serial === RUN TestAccIoTEventConfigurations_serial/basic --- PASS: TestAccIoTEventConfigurations_serial (22.69s) --- PASS: TestAccIoTEventConfigurations_serial/basic (22.69s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/iot 28.351s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccIoTBillingGroup_' PKG=iot ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iot/... -v -count 1 -parallel 2 -run=TestAccIoTBillingGroup_ -timeout 360m
=== RUN TestAccIoTBillingGroup_basic
=== PAUSE TestAccIoTBillingGroup_basic
=== RUN TestAccIoTBillingGroup_disappears
=== PAUSE TestAccIoTBillingGroup_disappears
=== RUN TestAccIoTBillingGroup_tags
=== PAUSE TestAccIoTBillingGroup_tags
=== RUN TestAccIoTBillingGroup_properties
=== PAUSE TestAccIoTBillingGroup_properties
=== CONT TestAccIoTBillingGroup_basic
=== CONT TestAccIoTBillingGroup_tags
--- PASS: TestAccIoTBillingGroup_basic (24.54s)
=== CONT TestAccIoTBillingGroup_properties
--- PASS: TestAccIoTBillingGroup_tags (57.27s)
=== CONT TestAccIoTBillingGroup_disappears
--- PASS: TestAccIoTBillingGroup_properties (39.06s)
--- PASS: TestAccIoTBillingGroup_disappears (16.68s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/iot 79.191s
% make testacc TESTARGS='-run=TestAccIoTEventConfigurations_serial' PKG=iot
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iot/... -v -count 1 -parallel 20 -run=TestAccIoTEventConfigurations_serial -timeout 360m
=== RUN TestAccIoTEventConfigurations_serial
=== PAUSE TestAccIoTEventConfigurations_serial
=== CONT TestAccIoTEventConfigurations_serial
=== RUN TestAccIoTEventConfigurations_serial/basic
--- PASS: TestAccIoTEventConfigurations_serial (22.69s)
--- PASS: TestAccIoTEventConfigurations_serial/basic (22.69s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/iot 28.351s
@jmmarko Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.26.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Add resource: aws_iot_billing_group
Relations
Closes #31030.
Closes #22750.
Closes #10629.
References
Create: https://docs.aws.amazon.com/cli/latest/reference/iot/create-billing-group.html
Update: https://docs.aws.amazon.com/cli/latest/reference/iot/update-billing-group.html
Delete: https://docs.aws.amazon.com/cli/latest/reference/iot/delete-billing-group.html
Describe: https://docs.aws.amazon.com/cli/latest/reference/iot/describe-billing-group.html
Output from Acceptance Testing