Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource: aws_iot_billing_group #31237

Merged
merged 24 commits into from
Nov 13, 2023

Conversation

jmmarko
Copy link
Contributor

@jmmarko jmmarko commented May 5, 2023

Description

Add resource: aws_iot_billing_group

Relations

Closes #31030.
Closes #22750.
Closes #10629.

References

Create: https://docs.aws.amazon.com/cli/latest/reference/iot/create-billing-group.html
Update: https://docs.aws.amazon.com/cli/latest/reference/iot/update-billing-group.html
Delete: https://docs.aws.amazon.com/cli/latest/reference/iot/delete-billing-group.html
Describe: https://docs.aws.amazon.com/cli/latest/reference/iot/describe-billing-group.html

Output from Acceptance Testing

$ make testacc TESTS=TestAccIoTBillingGroup PKG=iot 

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iot/... -v -count 1 -parallel 20 -run='TestAccIoTBillingGroup'  -timeout 180m
=== RUN   TestAccIoTBillingGroup_basic
=== PAUSE TestAccIoTBillingGroup_basic
=== RUN   TestAccIoTBillingGroup_disappears
=== PAUSE TestAccIoTBillingGroup_disappears
=== RUN   TestAccIoTBillingGroup_tags
=== PAUSE TestAccIoTBillingGroup_tags
=== RUN   TestAccIoTBillingGroup_properties
=== PAUSE TestAccIoTBillingGroup_properties
=== CONT  TestAccIoTBillingGroup_basic
=== CONT  TestAccIoTBillingGroup_tags
=== CONT  TestAccIoTBillingGroup_properties
=== CONT  TestAccIoTBillingGroup_disappears
--- PASS: TestAccIoTBillingGroup_disappears (10.77s)
--- PASS: TestAccIoTBillingGroup_basic (14.10s)
--- PASS: TestAccIoTBillingGroup_properties (21.35s)
--- PASS: TestAccIoTBillingGroup_tags (28.68s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/iot        30.823s

@github-actions
Copy link

github-actions bot commented May 5, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/iot Issues and PRs that pertain to the iot service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels May 5, 2023
@jmmarko jmmarko marked this pull request as ready for review May 5, 2023 22:35
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @jmmarko 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels May 9, 2023
@abhinaysutrakar
Copy link

is this fix available now ?

@jmmarko
Copy link
Contributor Author

jmmarko commented May 22, 2023

is this fix available now ?

The PR is waiting for review and to be merged. Please vote above to raise the priority of the PR. Thanks.

# Conflicts:
#	internal/service/iot/service_package_gen.go
% make testacc TESTARGS='-run=TestAccIoTBillingGroup_' PKG=iot ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iot/... -v -count 1 -parallel 2  -run=TestAccIoTBillingGroup_ -timeout 360m
=== RUN   TestAccIoTBillingGroup_basic
=== PAUSE TestAccIoTBillingGroup_basic
=== RUN   TestAccIoTBillingGroup_disappears
=== PAUSE TestAccIoTBillingGroup_disappears
=== RUN   TestAccIoTBillingGroup_tags
=== PAUSE TestAccIoTBillingGroup_tags
=== RUN   TestAccIoTBillingGroup_properties
=== PAUSE TestAccIoTBillingGroup_properties
=== CONT  TestAccIoTBillingGroup_basic
=== CONT  TestAccIoTBillingGroup_tags
--- PASS: TestAccIoTBillingGroup_basic (24.54s)
=== CONT  TestAccIoTBillingGroup_properties
--- PASS: TestAccIoTBillingGroup_tags (57.27s)
=== CONT  TestAccIoTBillingGroup_disappears
--- PASS: TestAccIoTBillingGroup_properties (39.06s)
--- PASS: TestAccIoTBillingGroup_disappears (16.68s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iot	79.191s
% make testacc TESTARGS='-run=TestAccIoTEventConfigurations_serial' PKG=iot
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iot/... -v -count 1 -parallel 20  -run=TestAccIoTEventConfigurations_serial -timeout 360m
=== RUN   TestAccIoTEventConfigurations_serial
=== PAUSE TestAccIoTEventConfigurations_serial
=== CONT  TestAccIoTEventConfigurations_serial
=== RUN   TestAccIoTEventConfigurations_serial/basic
--- PASS: TestAccIoTEventConfigurations_serial (22.69s)
    --- PASS: TestAccIoTEventConfigurations_serial/basic (22.69s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iot	28.351s
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccIoTBillingGroup_' PKG=iot ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iot/... -v -count 1 -parallel 2  -run=TestAccIoTBillingGroup_ -timeout 360m
=== RUN   TestAccIoTBillingGroup_basic
=== PAUSE TestAccIoTBillingGroup_basic
=== RUN   TestAccIoTBillingGroup_disappears
=== PAUSE TestAccIoTBillingGroup_disappears
=== RUN   TestAccIoTBillingGroup_tags
=== PAUSE TestAccIoTBillingGroup_tags
=== RUN   TestAccIoTBillingGroup_properties
=== PAUSE TestAccIoTBillingGroup_properties
=== CONT  TestAccIoTBillingGroup_basic
=== CONT  TestAccIoTBillingGroup_tags
--- PASS: TestAccIoTBillingGroup_basic (24.54s)
=== CONT  TestAccIoTBillingGroup_properties
--- PASS: TestAccIoTBillingGroup_tags (57.27s)
=== CONT  TestAccIoTBillingGroup_disappears
--- PASS: TestAccIoTBillingGroup_properties (39.06s)
--- PASS: TestAccIoTBillingGroup_disappears (16.68s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iot	79.191s
% make testacc TESTARGS='-run=TestAccIoTEventConfigurations_serial' PKG=iot                      
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iot/... -v -count 1 -parallel 20  -run=TestAccIoTEventConfigurations_serial -timeout 360m
=== RUN   TestAccIoTEventConfigurations_serial
=== PAUSE TestAccIoTEventConfigurations_serial
=== CONT  TestAccIoTEventConfigurations_serial
=== RUN   TestAccIoTEventConfigurations_serial/basic
--- PASS: TestAccIoTEventConfigurations_serial (22.69s)
    --- PASS: TestAccIoTEventConfigurations_serial/basic (22.69s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iot	28.351s

@github-actions github-actions bot added the verify Pertains to the verify package (i.e., provider-level validating, diff suppression, etc.) label Nov 13, 2023
@ewbankkit ewbankkit merged commit d5dde51 into hashicorp:main Nov 13, 2023
43 checks passed
@ewbankkit
Copy link
Contributor

@jmmarko Thanks for the contribution 🎉 👏.

@github-actions github-actions bot added this to the v5.26.0 milestone Nov 13, 2023
Copy link

This functionality has been released in v5.26.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. service/iot Issues and PRs that pertain to the iot service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. verify Pertains to the verify package (i.e., provider-level validating, diff suppression, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Resource]: IoT Billing Groups Add AWS IoT Core Event configuration
7 participants