-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: add copy_tags_to_snapshot
argument to resource/aws_docdb_cluster_instance
#31022
Enhancement: add copy_tags_to_snapshot
argument to resource/aws_docdb_cluster_instance
#31022
Conversation
Community NoteVoting for Prioritization
For Submitters
|
👍 |
1 similar comment
👍 |
Hi, Thanks for fixing this issue. |
👍 |
% make testacc TESTARGS='-run=TestAccDocDBClusterInstance_basic' PKG=docdb ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/docdb/... -v -count 1 -parallel 20 -run=TestAccDocDBClusterInstance_basic -timeout 360m === RUN TestAccDocDBClusterInstance_basic === PAUSE TestAccDocDBClusterInstance_basic === CONT TestAccDocDBClusterInstance_basic --- PASS: TestAccDocDBClusterInstance_basic (1190.80s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/docdb 1195.872s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccDocDBClusterInstance_' PKG=docdb ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/docdb/... -v -count 1 -parallel 3 -run=TestAccDocDBClusterInstance_ -timeout 720m
=== RUN TestAccDocDBClusterInstance_basic
=== PAUSE TestAccDocDBClusterInstance_basic
=== RUN TestAccDocDBClusterInstance_performanceInsights
=== PAUSE TestAccDocDBClusterInstance_performanceInsights
=== RUN TestAccDocDBClusterInstance_az
=== PAUSE TestAccDocDBClusterInstance_az
=== RUN TestAccDocDBClusterInstance_namePrefix
=== PAUSE TestAccDocDBClusterInstance_namePrefix
=== RUN TestAccDocDBClusterInstance_generatedName
=== PAUSE TestAccDocDBClusterInstance_generatedName
=== RUN TestAccDocDBClusterInstance_kmsKey
=== PAUSE TestAccDocDBClusterInstance_kmsKey
=== RUN TestAccDocDBClusterInstance_disappears
=== PAUSE TestAccDocDBClusterInstance_disappears
=== RUN TestAccDocDBClusterInstance_copyTagsToSnapshot
=== PAUSE TestAccDocDBClusterInstance_copyTagsToSnapshot
=== CONT TestAccDocDBClusterInstance_basic
=== CONT TestAccDocDBClusterInstance_generatedName
=== CONT TestAccDocDBClusterInstance_az
--- PASS: TestAccDocDBClusterInstance_az (1069.26s)
=== CONT TestAccDocDBClusterInstance_disappears
--- PASS: TestAccDocDBClusterInstance_basic (1088.30s)
=== CONT TestAccDocDBClusterInstance_copyTagsToSnapshot
--- PASS: TestAccDocDBClusterInstance_generatedName (1127.13s)
=== CONT TestAccDocDBClusterInstance_performanceInsights
--- PASS: TestAccDocDBClusterInstance_disappears (1092.69s)
=== CONT TestAccDocDBClusterInstance_kmsKey
--- PASS: TestAccDocDBClusterInstance_copyTagsToSnapshot (1076.12s)
=== CONT TestAccDocDBClusterInstance_namePrefix
--- PASS: TestAccDocDBClusterInstance_performanceInsights (1443.29s)
--- PASS: TestAccDocDBClusterInstance_kmsKey (1016.71s)
--- PASS: TestAccDocDBClusterInstance_namePrefix (1126.53s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/docdb 3296.191s
@tamiros Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.21.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR adds the argument
copy_tags_to_snapshot
to the resourceaws_docdb_cluster_instance
.This feature flag seems to be available/visible only via CLI, API and CloudFormation. Can't seem to find it in the Web Console.
Relations
Closes #31018.
References
Output from Acceptance Testing