Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add skip_destroy onto lambda_layer_permission #29571

Merged
merged 5 commits into from
Jun 1, 2023

Conversation

James-DeLorenzo
Copy link
Contributor

@James-DeLorenzo James-DeLorenzo commented Feb 22, 2023

Description

Adds similar functionality of skip_destroy from lambda layer to lambda layer permissions.

Relations

Closes #23547

References

Referenced PR #11997 to update the code, but not really sure how to add proper testing.

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/lambda Issues and PRs that pertain to the lambda service. needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. labels Feb 22, 2023
@breathingdust breathingdust added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 6, 2023
@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed size/XS Managed by automation to categorize the size of a PR. labels May 12, 2023
@nam054 nam054 added this to the v5.1.0 milestone May 12, 2023
@nam054
Copy link
Contributor

nam054 commented Jun 1, 2023

LGTM 🚀 Thank you for your contribution!

> make testacc TESTARGS='-run=TestAccLambdaLayerVersionPermission_' PKG=lambda
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 20  -run=TestAccLambdaLayerVersionPermission_ -timeout 180m
=== RUN   TestAccLambdaLayerVersionPermission_basic_byARN
=== PAUSE TestAccLambdaLayerVersionPermission_basic_byARN
=== RUN   TestAccLambdaLayerVersionPermission_basic_byName
=== PAUSE TestAccLambdaLayerVersionPermission_basic_byName
=== RUN   TestAccLambdaLayerVersionPermission_org
=== PAUSE TestAccLambdaLayerVersionPermission_org
=== RUN   TestAccLambdaLayerVersionPermission_account
=== PAUSE TestAccLambdaLayerVersionPermission_account
=== RUN   TestAccLambdaLayerVersionPermission_disappears
=== PAUSE TestAccLambdaLayerVersionPermission_disappears
=== RUN   TestAccLambdaLayerVersionPermission_skipDestroy
=== PAUSE TestAccLambdaLayerVersionPermission_skipDestroy
=== CONT  TestAccLambdaLayerVersionPermission_basic_byARN
=== CONT  TestAccLambdaLayerVersionPermission_account
=== CONT  TestAccLambdaLayerVersionPermission_org
=== CONT  TestAccLambdaLayerVersionPermission_basic_byName
=== CONT  TestAccLambdaLayerVersionPermission_skipDestroy
=== CONT  TestAccLambdaLayerVersionPermission_disappears
--- PASS: TestAccLambdaLayerVersionPermission_basic_byName (19.50s)
--- PASS: TestAccLambdaLayerVersionPermission_basic_byARN (28.83s)
--- PASS: TestAccLambdaLayerVersionPermission_org (33.29s)
--- PASS: TestAccLambdaLayerVersionPermission_account (36.98s)
--- PASS: TestAccLambdaLayerVersionPermission_disappears (39.14s)
--- PASS: TestAccLambdaLayerVersionPermission_skipDestroy (42.50s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lambda     45.721s

@nam054 nam054 merged commit 2fdd370 into hashicorp:main Jun 1, 2023
@github-actions
Copy link

github-actions bot commented Jun 1, 2023

This functionality has been released in v5.1.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jul 2, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/lambda Issues and PRs that pertain to the lambda service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a skip_destroy parameter to aws_lambda_layer_version_permission
3 participants