Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ecs_task_definition allow root_directory with authorization_config #26880

Merged
merged 3 commits into from
Jun 12, 2023

Conversation

odie5533
Copy link
Contributor

@odie5533 odie5533 commented Sep 20, 2022

Description

Allow an ecs_task_definition EFS configuration to specify a root_directory, even when using authorization_config.

Relations

Fixes #26793
Fixes #18010
Relates #19549

References

Allow ecs_task_definition to specify a root_directory even when using
authorization_config.
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Please review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/ecs Issues and PRs that pertain to the ecs service. size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Sep 20, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @odie5533 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 20, 2022
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

$ make testacc PKG=ecs TESTS=TestAccECSTaskDefinition_EFSVolume_accessPoint
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 20 -run='TestAccECSTaskDefinition_EFSVolume_accessPoint'  -timeout 180m
=== RUN   TestAccECSTaskDefinition_EFSVolume_accessPoint
=== PAUSE TestAccECSTaskDefinition_EFSVolume_accessPoint
=== CONT  TestAccECSTaskDefinition_EFSVolume_accessPoint
--- PASS: TestAccECSTaskDefinition_EFSVolume_accessPoint (32.17s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ecs        35.483s
$ make testacc PKG=ecs TESTS=TestAccECSTaskDefinition_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 20 -run='TestAccECSTaskDefinition_'  -timeout 180m

--- PASS: TestAccECSTaskDefinition_invalidContainerDefinition (5.74s)
=== CONT  TestAccECSTaskDefinition_tags
--- PASS: TestAccECSTaskDefinition_taskRoleARN (49.10s)
=== CONT  TestAccECSTaskDefinition_Fargate_runtimePlatformWithoutArch
--- PASS: TestAccECSTaskDefinition_runtimePlatform (49.21s)
=== CONT  TestAccECSTaskDefinition_EFSVolume_minimal
--- PASS: TestAccECSTaskDefinition_DockerVolume_taskScoped (49.30s)
=== CONT  TestAccECSTaskDefinition_Fargate_runtimePlatform
--- PASS: TestAccECSTaskDefinition_networkMode (49.32s)
=== CONT  TestAccECSTaskDefinition_EFSVolume_transitEncryption
--- PASS: TestAccECSTaskDefinition_Fargate_ephemeralStorage (49.33s)
=== CONT  TestAccECSTaskDefinition_DockerVolume_basic
--- PASS: TestAccECSTaskDefinition_arrays (49.35s)
=== CONT  TestAccECSTaskDefinition_DockerVolume_minimal
--- PASS: TestAccECSTaskDefinition_inferenceAccelerator (49.38s)
=== CONT  TestAccECSTaskDefinition_scratchVolume
--- PASS: TestAccECSTaskDefinition_ipcMode (49.42s)
=== CONT  TestAccECSTaskDefinition_executionRole
--- PASS: TestAccECSTaskDefinition_pidMode (50.40s)
--- PASS: TestAccECSTaskDefinition_constraint (53.03s)
--- PASS: TestAccECSTaskDefinition_EFSVolume_basic (58.01s)
--- PASS: TestAccECSTaskDefinition_proxy (61.20s)
--- PASS: TestAccECSTaskDefinition_EFSVolume_accessPoint (63.94s)
--- PASS: TestAccECSTaskDefinition_Fargate_basic (66.07s)
--- PASS: TestAccECSTaskDefinition_disappears (69.05s)
--- PASS: TestAccECSTaskDefinition_basic (73.76s)
--- PASS: TestAccECSTaskDefinition_changeVolumesForcesNewResource (74.31s)
--- PASS: TestAccECSTaskDefinition_DockerVolume_minimal (33.23s)
--- PASS: TestAccECSTaskDefinition_scratchVolume (33.70s)
--- PASS: TestAccECSTaskDefinition_DockerVolume_basic (33.88s)
--- PASS: TestAccECSTaskDefinition_Fargate_runtimePlatform (34.20s)
--- PASS: TestAccECSTaskDefinition_Fargate_runtimePlatformWithoutArch (34.51s)
--- PASS: TestAccECSTaskDefinition_executionRole (34.53s)
--- PASS: TestAccECSTaskDefinition_EFSVolume_minimal (40.64s)
--- PASS: TestAccECSTaskDefinition_EFSVolume_transitEncryption (40.63s)
--- PASS: TestAccECSTaskDefinition_tags (88.08s)
--- PASS: TestAccECSTaskDefinition_service (130.18s)
--- PASS: TestAccECSTaskDefinition_fsxWinFileSystem (3131.77s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ecs        3134.912s

@jar-b jar-b merged commit 1704c3c into hashicorp:main Jun 12, 2023
@jar-b
Copy link
Member

jar-b commented Jun 12, 2023

Thanks for your contribution, @odie5533! 👏

@github-actions github-actions bot added this to the v5.3.0 milestone Jun 12, 2023
@github-actions
Copy link

This functionality has been released in v5.3.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/ecs Issues and PRs that pertain to the ecs service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
3 participants