Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_fms_policy: Added policy_option config block for FMS policy #25362

Merged
merged 15 commits into from
Jul 13, 2023
Merged

r/aws_fms_policy: Added policy_option config block for FMS policy #25362

merged 15 commits into from
Jul 13, 2023

Conversation

daftkid
Copy link
Contributor

@daftkid daftkid commented Jun 15, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #25088

Output from acceptance testing:
Sorry, I'm not able to run Acceptance Tests right now, could you please run them for this PR?

$ make testacc TESTS=testAccPolicy_policyOption PKG=fms
$ make testacc TESTS=testAccPolicy_ PKG=fms

...

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/fms Issues and PRs that pertain to the fms service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/L Managed by automation to categorize the size of a PR. labels Jun 15, 2022
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 16, 2022
@mrtnfchs
Copy link

mrtnfchs commented Sep 7, 2022

Are there plans to merge this PR any time soon ?

@stevec1980
Copy link

are there any plans to merge this soon?

@mgomezzul
Copy link

any update on this topic?

@daftkid daftkid force-pushed the f-add_fms_policy_option branch from 5badc8c to abfa444 Compare May 19, 2023 10:13
@johnsonaj johnsonaj self-assigned this Jul 13, 2023
@github-actions github-actions bot added service/ssm Issues and PRs that pertain to the ssm service. sweeper Pertains to changes to or issues with the sweeper. labels Jul 13, 2023
@johnsonaj johnsonaj removed service/ssm Issues and PRs that pertain to the ssm service. sweeper Pertains to changes to or issues with the sweeper. labels Jul 13, 2023
@github-actions github-actions bot added service/ssm Issues and PRs that pertain to the ssm service. sweeper Pertains to changes to or issues with the sweeper. labels Jul 13, 2023
johnsonaj
johnsonaj approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@johnsonaj
Copy link
Contributor

@daftkid thank you for the contribution! 🎉

@johnsonaj johnsonaj merged commit b24adcc into hashicorp:main Jul 13, 2023
@github-actions github-actions bot added this to the v5.8.0 milestone Jul 13, 2023
@github-actions
Copy link

This functionality has been released in v5.8.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2023
@daftkid daftkid deleted the f-add_fms_policy_option branch October 10, 2023 09:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jbennett-nex jbennett-nex jbennett-nex left review comments

@johnsonaj johnsonaj johnsonaj approved these changes

Assignees

@johnsonaj johnsonaj

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/fms Issues and PRs that pertain to the fms service. service/ssm Issues and PRs that pertain to the ssm service. size/L Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.8.0
Development

Successfully merging this pull request may close these issues.

Support PolicyOption for AWS Firewall Manager Policies
7 participants
@daftkid @mrtnfchs @stevec1980 @mgomezzul @johnsonaj @jbennett-nex @justinretzolk