Gateway Load Balancer Support

[bflad]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Reference: #14601
Closes #16129

Release note for CHANGELOG:

* data-source/aws_route_table: Add `route` `vpc_endpoint_id` attribute
* resource/aws_default_route_table: Add `route` configuration block `vpc_endpoint_id` argument
* resource/aws_lb: Support `load_balancer_type` argument value of `gateway`
* resource/aws_lb_target_group: Support `protocol` argument value of `GENEVE`
* resource/aws_route: Add `vpc_endpoint_id` argument
* resource/aws_route_table: Add `route` configuration block `vpc_endpoint_id` argument
* resource/aws_vpc_endpoint: Support `vpc_endpoint_type` argument value `GatewayLoadBalancer`
* resource/aws_vpc_endpoint_service: Add `gateway_load_balancer_arns` argument

Output from acceptance testing:

--- PASS: TestAccAWSDefaultRouteTable_ConditionalCidrBlock (79.58s)
--- PASS: TestAccAWSDefaultRouteTable_Route (98.46s)
--- PASS: TestAccAWSDefaultRouteTable_Route_TransitGatewayID (392.89s)
--- PASS: TestAccAWSDefaultRouteTable_Route_VpcEndpointId (311.16s)
--- PASS: TestAccAWSDefaultRouteTable_basic (55.44s)
--- PASS: TestAccAWSDefaultRouteTable_disappears_Vpc (27.64s)
--- PASS: TestAccAWSDefaultRouteTable_swap (81.87s)
--- PASS: TestAccAWSDefaultRouteTable_tags (78.09s)
--- PASS: TestAccAWSDefaultRouteTable_vpc_endpoint (70.70s)

--- PASS: TestAccAWSLBTargetGroup_BackwardsCompatibility (35.91s)
--- PASS: TestAccAWSLBTargetGroup_Protocol_Geneve (13.38s)
--- PASS: TestAccAWSLBTargetGroup_Protocol_Tcp_HealthCheck_Protocol (38.43s)
--- PASS: TestAccAWSLBTargetGroup_Protocol_Tls (17.19s)
--- PASS: TestAccAWSLBTargetGroup_TCP_HTTPHealthCheck (61.45s)
--- PASS: TestAccAWSLBTargetGroup_basic (14.05s)
--- PASS: TestAccAWSLBTargetGroup_basicUdp (13.38s)
--- PASS: TestAccAWSLBTargetGroup_changeNameForceNew (81.69s)
--- PASS: TestAccAWSLBTargetGroup_changePortForceNew (81.96s)
--- PASS: TestAccAWSLBTargetGroup_changeProtocolForceNew (86.51s)
--- PASS: TestAccAWSLBTargetGroup_changeVpcForceNew (81.25s)
--- PASS: TestAccAWSLBTargetGroup_defaults_application (43.62s)
--- PASS: TestAccAWSLBTargetGroup_defaults_network (69.36s)
--- PASS: TestAccAWSLBTargetGroup_enableHealthCheck (80.28s)
--- PASS: TestAccAWSLBTargetGroup_generatedName (37.88s)
--- PASS: TestAccAWSLBTargetGroup_namePrefix (34.40s)
--- PASS: TestAccAWSLBTargetGroup_networkLB_TargetGroup (74.50s)
--- PASS: TestAccAWSLBTargetGroup_networkLB_TargetGroupWithProxy (56.08s)
--- PASS: TestAccAWSLBTargetGroup_stickinessDefaultALB (48.09s)
--- PASS: TestAccAWSLBTargetGroup_stickinessDefaultNLB (101.07s)
--- PASS: TestAccAWSLBTargetGroup_stickinessInvalidALB (59.08s)
--- PASS: TestAccAWSLBTargetGroup_stickinessInvalidNLB (51.65s)
--- PASS: TestAccAWSLBTargetGroup_stickinessValidALB (78.75s)
--- PASS: TestAccAWSLBTargetGroup_stickinessValidNLB (123.29s)
--- PASS: TestAccAWSLBTargetGroup_tags (107.63s)
--- PASS: TestAccAWSLBTargetGroup_updateHealthCheck (87.24s)
--- PASS: TestAccAWSLBTargetGroup_updateSticknessEnabled (105.44s)
--- PASS: TestAccAWSLBTargetGroup_withoutHealthcheck (11.08s)

--- PASS: TestAccAWSLB_ALB_AccessLogs (328.05s)
--- PASS: TestAccAWSLB_ALB_AccessLogs_Prefix (292.59s)
--- PASS: TestAccAWSLB_ALB_basic (221.14s)
--- PASS: TestAccAWSLB_BackwardsCompatibility (157.55s)
--- PASS: TestAccAWSLB_LoadBalancerType_Gateway (112.95s)
--- PASS: TestAccAWSLB_NLB_AccessLogs (389.86s)
--- PASS: TestAccAWSLB_NLB_AccessLogs_Prefix (312.70s)
--- PASS: TestAccAWSLB_NLB_basic (215.95s)
--- PASS: TestAccAWSLB_NLB_privateipv4address (206.78s)
--- PASS: TestAccAWSLB_applicationLoadBalancer_updateDeletionProtection (287.46s)
--- PASS: TestAccAWSLB_applicationLoadBalancer_updateDropInvalidHeaderFields (336.41s)
--- PASS: TestAccAWSLB_applicationLoadBalancer_updateHttp2 (327.80s)
--- PASS: TestAccAWSLB_generatedName (233.50s)
--- PASS: TestAccAWSLB_generatesNameForZeroValue (223.68s)
--- PASS: TestAccAWSLB_namePrefix (222.50s)
--- PASS: TestAccAWSLB_networkLoadbalancer_subnet_change (223.68s)
--- PASS: TestAccAWSLB_networkLoadbalancer_updateCrossZone (338.95s)
--- PASS: TestAccAWSLB_noSecurityGroup (155.95s)
--- PASS: TestAccAWSLB_tags (293.86s)
--- PASS: TestAccAWSLB_updatedIpAddressType (217.83s)
--- PASS: TestAccAWSLB_updatedSecurityGroups (282.45s)
--- PASS: TestAccAWSLB_updatedSubnets (220.56s)
--- SKIP: TestAccAWSLB_ALB_outpost (1.95s)

--- PASS: TestAccAWSRouteDataSource_TransitGatewayID (339.24s)
--- PASS: TestAccAWSRouteDataSource_basic (98.80s)
--- SKIP: TestAccAWSRouteDataSource_LocalGatewayID (5.08s)

--- PASS: TestAccAWSRouteTable_ConditionalCidrBlock (63.69s)
--- PASS: TestAccAWSRouteTable_RequireRouteDestination (71.60s)
--- PASS: TestAccAWSRouteTable_RequireRouteTarget (14.34s)
--- PASS: TestAccAWSRouteTable_Route_ConfigMode (85.64s)
--- PASS: TestAccAWSRouteTable_Route_TransitGatewayID (344.45s)
--- PASS: TestAccAWSRouteTable_Route_VpcEndpointId (254.26s)
--- PASS: TestAccAWSRouteTable_basic (52.42s)
--- PASS: TestAccAWSRouteTable_instance (111.34s)
--- PASS: TestAccAWSRouteTable_ipv6 (27.17s)
--- PASS: TestAccAWSRouteTable_tags (81.13s)
--- PASS: TestAccAWSRouteTable_vgwRoutePropagation (54.28s)
--- PASS: TestAccAWSRouteTable_vpcPeering (46.40s)
--- SKIP: TestAccAWSRouteTable_Route_LocalGatewayID (1.74s)

--- PASS: TestAccAWSRoute_ConditionalCidrBlock (43.72s)
--- PASS: TestAccAWSRoute_TransitGatewayID_DestinationCidrBlock (343.04s)
--- PASS: TestAccAWSRoute_VpcEndpointId (301.53s)
--- PASS: TestAccAWSRoute_basic (45.59s)
--- PASS: TestAccAWSRoute_changeCidr (48.46s)
--- PASS: TestAccAWSRoute_changeRouteTable (45.74s)
--- PASS: TestAccAWSRoute_disappears (42.60s)
--- PASS: TestAccAWSRoute_doesNotCrashWithVPCEndpoint (38.97s)
--- PASS: TestAccAWSRoute_ipv6Support (39.79s)
--- PASS: TestAccAWSRoute_ipv6ToInstance (110.26s)
--- PASS: TestAccAWSRoute_ipv6ToInternetGateway (37.12s)
--- PASS: TestAccAWSRoute_ipv6ToNetworkInterface (134.33s)
--- PASS: TestAccAWSRoute_ipv6ToPeeringConnection (20.75s)
--- PASS: TestAccAWSRoute_noopdiff (94.82s)
--- SKIP: TestAccAWSRoute_LocalGatewayID (1.49s)

--- PASS: TestAccAWSVpcEndpointConnectionNotification_basic (230.14s)
--- PASS: TestAccAWSVpcEndpointRouteTableAssociation_basic (32.57s)
--- PASS: TestAccAWSVpcEndpointServiceAllowedPrincipal_basic (224.14s)
--- PASS: TestAccAWSVpcEndpointService_AllowedPrincipals (256.49s)
--- PASS: TestAccAWSVpcEndpointService_GatewayLoadBalancerArns (302.99s)
--- PASS: TestAccAWSVpcEndpointService_basic (232.57s)
--- PASS: TestAccAWSVpcEndpointService_disappears (249.77s)
--- PASS: TestAccAWSVpcEndpointService_tags (381.45s)

--- PASS: TestAccAWSVpcEndpoint_VpcEndpointType_GatewayLoadBalancer (235.67s)
--- PASS: TestAccAWSVpcEndpoint_disappears (22.83s)
--- PASS: TestAccAWSVpcEndpoint_gatewayBasic (24.77s)
--- PASS: TestAccAWSVpcEndpoint_gatewayPolicy (41.01s)
--- PASS: TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicy (47.12s)
--- PASS: TestAccAWSVpcEndpoint_interfaceBasic (77.87s)
--- PASS: TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnCreate (238.12s)
--- PASS: TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnUpdate (294.45s)
--- PASS: TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup (400.21s)
--- PASS: TestAccAWSVpcEndpoint_tags (49.18s)

--- PASS: TestAccDataSourceAwsRouteTable_basic (55.10s)
--- PASS: TestAccDataSourceAwsRouteTable_main (45.70s)

--- PASS: TestAccDataSourceAwsRouteTables_basic (61.82s)

[YakDriver]

The original TC run (commercial) had some failures. I re-ran them and this is what I found:

--- FAIL: TestAccAWSRoute53VpcAssociationAuthorization_disappears (1.06s) (doesn't normally fail)
--- FAIL: TestAccAWSRoute53ZoneAssociation_CrossAccount (1.12s) (doesn't normally fail)
--- FAIL: TestAccAWSRoute53VpcAssociationAuthorization_basic (1.19s) (doesn't normally fail)
--- FAIL: TestAccAWSLB_networkLoadbalancerEIP (7.85s) (pre-existing failure)
--- PASS: TestAccAWSLBListenerRule_Action_Order (190.31s)
--- PASS: TestAccAWSLBListenerRule_conditionPathPattern (198.14s)
--- PASS: TestAccAWSLBListenerRule_Action_Order_Recreates (198.84s)
--- PASS: TestAccAWSLBListener_redirect (209.54s)
--- PASS: TestAccAWSVpcEndpointSubnetAssociation_multiple (580.59s)

Subsequent local runs yielded (a34797c):

GovCloud

--- PASS: TestAccAWSRoute53VpcAssociationAuthorization_disappears (61.66s)
--- PASS: TestAccAWSRoute53VpcAssociationAuthorization_basic (64.66s)
--- PASS: TestAccAWSRoute53ZoneAssociation_CrossAccount (98.62s)

Commercial:

--- PASS: TestAccAWSRoute53VpcAssociationAuthorization_disappears (99.66s)
--- PASS: TestAccAWSRoute53VpcAssociationAuthorization_basic (101.95s)
--- PASS: TestAccAWSRoute53ZoneAssociation_CrossAccount (172.57s)

[bflad]

tctest removes the _ separator when calculating which tests to run, so it can be a little overzealous with which tests it runs (e.g. none of the Route 53 testing is relevant but it all matches the TestAccAWSRoute prefix from the aws_route testing). All this is more the reason to ensure we create resources with the proper service naming in the resource naming.

The only potentially concerning test is the below, but its a pre-existing failure on the main branch, which I'll submit a separate fix.

=== CONT  TestAccAWSLB_networkLoadbalancerEIP
TestAccAWSLB_networkLoadbalancerEIP: resource_aws_lb_test.go:241: Step 1/1 error: Error running pre-apply plan: 2020/11/10 23:20:59 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.10.0
Error: Incorrect attribute value type
on config604754392/terraform_plugin_test.tf line 45, in resource "aws_route_table_association" "a":
45:   subnet_id      = aws_subnet.public[*].id[count.index]
|----------------
| aws_subnet.public is tuple with 4 elements
| count.index is 2
Inappropriate value for attribute "subnet_id": string required.
Error: Incorrect attribute value type
on config604754392/terraform_plugin_test.tf line 45, in resource "aws_route_table_association" "a":
45:   subnet_id      = aws_subnet.public[*].id[count.index]
|----------------
| aws_subnet.public is tuple with 4 elements
| count.index is 3
Inappropriate value for attribute "subnet_id": string required.

[bflad]

Configuration fix for TestAccAWSLB_networkLoadbalancerEIP submitted here: #16134

[YakDriver]

Looks great to me! Just a few comments.

[ghost]

This has been released in version 3.15.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!