-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource/rds_cluster_endpoint: add Create Timeout #14862
Conversation
@anGie44 is the creation time dependent on something practitioners manage (e.g. database size)? Typically we want to avoid providing customizable timeouts when operators have no influence/need to adjust it. |
good question @bflad! as far as i could tell the cluster/instance specs don't directly affect this creation time. as part of the issue's task, I interpreted the 2nd bullet point as if this timeout should be customizable by users but since there's no overall effect, will remove the Timeout from the resource schema 👍 |
@anGie44 oh that's my bad on that second bullet point in the issue -- copypasta from another issue 🍝 😖 |
6a391f5
to
1939143
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 🚀
Output from acceptance testing:
--- PASS: TestAccAWSRDSClusterEndpoint_basic (1119.73s)
--- PASS: TestAccAWSRDSClusterEndpoint_tags (1120.53s)
This has been released in version 3.5.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Closes #14570
Release note for CHANGELOG:
Output from acceptance testing: