Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/fsx_windows_file_system - add storage type #14316

Merged
merged 3 commits into from
Jul 28, 2020
Merged

r/fsx_windows_file_system - add storage type #14316

merged 3 commits into from
Jul 28, 2020

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Jul 23, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12553

Release note for CHANGELOG:

resource_aws_fsx_windows_file_system - add `storage_type` argument.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
--- PASS: TestAccAWSFsxWindowsFileSystem_storageTypeHdd (3350.79s)
--- PASS: TestAccAWSFsxWindowsFileSystem_basic (3006.13s)

@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/fsx Issues and PRs that pertain to the fsx service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 23, 2020
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 23, 2020
@DrFaust92 DrFaust92 self-assigned this Jul 23, 2020
@DrFaust92 DrFaust92 marked this pull request as ready for review July 23, 2020 15:33
@DrFaust92 DrFaust92 requested review from a team and ewbankkit and removed request for a team July 23, 2020 15:33
@ewbankkit
Copy link
Contributor

Verified acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSFsxWindowsFileSystem_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSFsxWindowsFileSystem_basic -timeout 120m
=== RUN   TestAccAWSFsxWindowsFileSystem_basic
=== PAUSE TestAccAWSFsxWindowsFileSystem_basic
=== CONT  TestAccAWSFsxWindowsFileSystem_basic
--- PASS: TestAccAWSFsxWindowsFileSystem_basic (3185.39s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	3185.469s
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSFsxWindowsFileSystem_storageTypeHdd'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSFsxWindowsFileSystem_storageTypeHdd -timeout 120m
=== RUN   TestAccAWSFsxWindowsFileSystem_storageTypeHdd
=== PAUSE TestAccAWSFsxWindowsFileSystem_storageTypeHdd
=== CONT  TestAccAWSFsxWindowsFileSystem_storageTypeHdd
--- PASS: TestAccAWSFsxWindowsFileSystem_storageTypeHdd (3444.05s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	3444.092s

@breathingdust
Copy link
Member

LGTM 🚀 Thanks @DrFaust92!

Verified Acceptance Tests

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSFsxWindowsFileSystem_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSFsxWindowsFileSystem_basic -timeout 120m
=== RUN   TestAccAWSFsxWindowsFileSystem_basic
=== PAUSE TestAccAWSFsxWindowsFileSystem_basic
=== CONT  TestAccAWSFsxWindowsFileSystem_basic
--- PASS: TestAccAWSFsxWindowsFileSystem_basic (3233.23s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	3235.741s
make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSFsxWindowsFileSystem_storageTypeHdd'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSFsxWindowsFileSystem_storageTypeHdd -timeout 120m
=== RUN   TestAccAWSFsxWindowsFileSystem_storageTypeHdd
=== PAUSE TestAccAWSFsxWindowsFileSystem_storageTypeHdd
=== CONT  TestAccAWSFsxWindowsFileSystem_storageTypeHdd
--- PASS: TestAccAWSFsxWindowsFileSystem_storageTypeHdd (2331.65s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	2333.889s

@breathingdust breathingdust added this to the v3.0.0 milestone Jul 28, 2020
@breathingdust breathingdust merged commit 614fc67 into hashicorp:master Jul 28, 2020
breathingdust added a commit that referenced this pull request Jul 28, 2020
@breathingdust
Update CHANGELOG.md for #14316
55cf291
@ghost
Copy link

ghost commented Jul 31, 2020

This has been released in version 3.0.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@DrFaust92 DrFaust92 deleted the r/fsx_windows_storage_type branch August 27, 2020 18:01
@ghost
Copy link

ghost commented Aug 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@breathingdust breathingdust

@maryelizbeth maryelizbeth

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/fsx Issues and PRs that pertain to the fsx service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

HDD support for aws_fsx_windows_file_system
4 participants
@DrFaust92 @ewbankkit @breathingdust @maryelizbeth